Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Mon, 16 Oct 2023 15:08:04 +0100
From:   Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To:     Terry Bowman <Terry.Bowman@amd.com>
CC:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Dan Williams" <dan.j.williams@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v11 10/20] cxl/pci: Introduce config option PCIEAER_CXL
Message-ID: <20231016150804.000054aa@Huawei.com>
In-Reply-To: <da5bc564-76c4-4078-97ab-1d543933071e@amd.com>
References: <20230927154339.1600738-1-rrichter@amd.com>
        <20230927154339.1600738-11-rrichter@amd.com>
        <20231002154628.00004f9b@Huawei.com>
        <21fa3d41-3585-40b4-b919-d3b66557e9d8@amd.com>
        <da5bc564-76c4-4078-97ab-1d543933071e@amd.com>
Organization: Huawei Technologies Research and Development (UK) Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Precedence: bulk


> >>> diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c
> >>> index 04107058739b..61ca21c020fa 100644
> >>> --- a/drivers/cxl/mem.c
> >>> +++ b/drivers/cxl/mem.c
> >>> @@ -157,6 +157,8 @@ static int cxl_mem_probe(struct device *dev)
> >>>  	else
> >>>  		endpoint_parent = &parent_port->dev;
> >>>  
> >>> +	devm_cxl_setup_parent_dport(dev, dport);  
> >>
> >> devm calls can always fail (because if nothing else you have to register
> >> some cleanup and that involves an allocation.  If you want to ignore
> >> that I'd expect a comment here.
> >>  
> > 
> > We will add error handling here.
> > 
> > Regards,
> > Terry
> >  
> 
> Found devm_cxl_setup_parent_dport() is a NULL function without return value.
Hmm. Then it's not a devm function. 

I went looking and can't find it registering any cleanup so
just rename it to cxl_setup_parent_dport()

>  
> Regards,
> Terry