Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Mon, 16 Oct 2023 16:09:58 +0200
From:   Robert Richter <rrichter@amd.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc:     Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>, linux-cxl@vger.kernel.org,
        linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Terry Bowman <terry.bowman@amd.com>
Subject: Re: [PATCH v11 07/20] cxl/hdm: Use stored Component Register
 mappings to map HDM decoder capability
Message-ID: <ZS1ENmg1OfNluhXm@rric.localdomain>
References: <20230927154339.1600738-1-rrichter@amd.com>
 <20230927154339.1600738-8-rrichter@amd.com>
 <20231002154351.0000136a@Huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231002154351.0000136a@Huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aRJttsuBAJdZ6tV58Ny5KwmLJCGQGj2+5iz1UgajN17OL683ZN5LmD4sItij?=
 =?us-ascii?Q?Ad1m8CAMtNMgkDwX45j6MnfIWhcudFsMEBLf472otNjjUhifS+rSSHRrxZKq?=
 =?us-ascii?Q?OtUpHPrF71cQ5AoYrye0OYmytb/15WrkbrMGiXWqykFAzA2EHJEpeVJZTj3v?=
 =?us-ascii?Q?6K9JSUzUFKZWn5hTY0L7Dx51oMaIQQAjX0sv2mmsMPX/qFcbvzLpPhJO+sGU?=
 =?us-ascii?Q?MrHzm/3cRjq9+PFykNwfvi1PKmyEA+ycY2EouAcATVUTLauya6Uew0s+auMb?=
 =?us-ascii?Q?Y5AGqP9cC3sxXbk32v0UDxT6FlVCEGGbRDvDHjc4dCM6/5By67Me68bTCL0p?=
 =?us-ascii?Q?V9gI3Nd9qxSA40Z+Cd2/lUGeHVCo4MMWO5l2Hm4PcNrorVAFkyyqjtjeoi94?=
 =?us-ascii?Q?GHGZPx2sV7qk6v9qjXlpQpwD/yhfWfzs6QfluBzkSin2VDyF6cN73ygIGmiZ?=
 =?us-ascii?Q?pIzXls26Ws593VrYACcBXEckCXapgyi4f48vfqhU5aK25BCrLlx1+I/VBTjn?=
 =?us-ascii?Q?ln+Ecm8PjfVGqvxL265T8AUMPN4om1Hmnij4CkP5nZ7d3fVMX3+//toUPbMT?=
 =?us-ascii?Q?V2fK67Sssa/vnaZHJTJwVD6JxSfflKA9v48wA2wqkDfORmBlN77JdsbdcHK2?=
 =?us-ascii?Q?Ytlg/TtffUJ4+EXssODMmUGerRUo5xWOJ0x8XYETtUmqoCMItBGmDc/Qu+0z?=
 =?us-ascii?Q?igd2rszHJRQTVGaih8Mv3b6cmyBpPMGXXK/60Mukve+SUn79JxwOr4QyIEG7?=
 =?us-ascii?Q?EZw/1UYfAYNCyF4XJIafKqPfuT8T7wkdWBpQWwsQrwf6/Mhf0q/gXNLokYC7?=
 =?us-ascii?Q?5FUz77Eo9fMBTDtAiL33iO+LaZzvz9C9idLO7Ct7Mq0ZOBi3p4Fa6YieeUrk?=
 =?us-ascii?Q?33Sk7xi306+AiBdSQ0BJCyYQ6olj/Y9BER/tewH1kDPDoPrz4e4U5wRtP9n+?=
 =?us-ascii?Q?xAxzJeoRuLzEcmn0nNh/vqTTsbESxJVLq3QmmAisovytycFibh4//tRYao1w?=
 =?us-ascii?Q?5sk8VQ1emsUwBeJ8C7x3XeFt5nY5yijSevEtFRBvNvnP5VEuvKl6WP5MMdO5?=
 =?us-ascii?Q?F4BDIYQQjTYDOQWUcXi+mcQkP/6IjisE2YNQCcY1Qtk05KaAVBFeNDAk4zrq?=
 =?us-ascii?Q?DG055ki6mRW7cgWC0anCaLDgn6j/DGRfWT59+oFKxM6jAFSzQ7ZPZevPb87D?=
 =?us-ascii?Q?5iUJif+behBI8JrWLQlOYCVF6S0WET9K8plWQ/j1Edz2eeiLjASlpAi6FCmR?=
 =?us-ascii?Q?mmbRDTiyIryiWiWU1W7SZIZa5RWU4lJ6M85u4Npl3whCs2XkzGkrDxsn1F4W?=
 =?us-ascii?Q?KrRaBDilQwkDuGCnDqk+2k4+PIDVXgVTkhl/9IvUibeiA1RXoZnZyYYkMmNJ?=
 =?us-ascii?Q?GiWsNlhMBgdUiwwKs9QdCMK0RaLjuHz8Y3cKal/2Zf6a3d3kBDzOD4p1fJk5?=
 =?us-ascii?Q?OOkqzshTDJh4bpQhRtv8AM05SFDpnkJXG9H1PwlV/AMQ4QzbGwmNYwGjuzCa?=
 =?us-ascii?Q?8XK9b84/Gy0GttkRBd8SJ0U6M7366W2uUVWAh83KdgtKPED3tNf0r3Tn5GhX?=
 =?us-ascii?Q?hcU4nBz2520xFnWOSriaZ0WFOlBVSN7LYwYpfKT6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59679528-f78c-40f3-5c33-08dbce519897
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3657.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 14:10:05.4055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t1Q5z25rYwI5zQBGI9PG5pXu2vApgbArVDE2gF2+t0MConvzmd2+ZS50tU9REB52ovTs6zwX8YDQA17RFVj1zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4425
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 07:10:24 -0700 (PDT)

On 02.10.23 15:43:51, Jonathan Cameron wrote:
> On Wed, 27 Sep 2023 17:43:26 +0200
> Robert Richter <rrichter@amd.com> wrote:
> 
> > Now, that the Component Register mappings are stored, use them to
> > enable and map the HDM decoder capabilities. The Component Registers
> > do not need to be probed again for this, remove probing code.
> > 
> > The HDM capability applies to Endpoints, USPs and VH Host Bridges. The
> > Endpoint's component register mappings are located in the cxlds and
> > else in the port's structure. Duplicate the cxlds->reg_map in
> > port->reg_map for endpoint ports.
> > 
> > Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> > Signed-off-by: Robert Richter <rrichter@amd.com>
> > Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> > [rework to drop cxl_port_get_comp_map()]
> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> A few comments inline.
> 
> Also, Dan's SoB doesn't make sense if you are the Author and he's not
> the one sending the email.  The fun of patches bounced back and forwards
> is sometimes you have to tweak this stuff on each posting... :(

Yeah, there was some back and forth with the code going on: Terry
changed a little, Dan was taking it and reposting, Terry was also
submitting the previous series, Dave reviewed it. So I decided here to
just swap Terry and my SOBs as I was posting the series now and left
the remaining to Dan the way as it will look like when he will apply
the patch, which means updating the SOB chain again. This keeps the
comment for the change he made to the patch.

-Robert

> 
> > ---
> >  drivers/cxl/core/hdm.c  | 48 ++++++++++++++++-------------------------
> >  drivers/cxl/core/port.c | 29 +++++++++++++++++++------
> >  drivers/cxl/mem.c       |  5 ++---
> >  3 files changed, 43 insertions(+), 39 deletions(-)