Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <78f321db-bc09-06e8-b4ef-ac56ab91e187@intel.com>
Date:   Mon, 16 Oct 2023 16:19:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] staging: qlge: Add bool type to qlge_idc_wait()
Content-Language: en-US
To:     Gilbert Adikankwu <gilbertadikankwu@gmail.com>,
        Nam Cao <namcao@linutronix.de>
CC:     <outreachy@lists.linux.dev>, <manishc@marvell.com>,
        <GR-Linux-NIC-Dev@marvell.com>, <coiby.xu@gmail.com>,
        <gregkh@linuxfoundation.org>, <netdev@vger.kernel.org>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
References: <ZSoxLxs45bIuBrHg@gilbert-PC>
 <20231014065813.mQvFyjWb@linutronix.de>
 <20231014071423.UgDor1v0@linutronix.de> <ZSpIPippZFtMw2aG@gilbert-PC>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <ZSpIPippZFtMw2aG@gilbert-PC>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmJkdWNSM3MzRm5IcW9WZnlsWVFXcEFOKzhHckdIYTBPSmJReWNxWTJrK1c1?=
 =?utf-8?B?QzArZEx5Z09GaEtCZm9MdjdQMHhxOUgwSHhxZHpONVVhU2NFZVQ0MDVzVkNP?=
 =?utf-8?B?VGtYSzhINWJYeU9NT0liWUFHYm8yMmh0TDNVSWdsL3VWelRmeFg0U0Z6N2VG?=
 =?utf-8?B?QVkzUlJsVkhudUdGMGQralV2YlA2MlhTd3ovRENVbEFtWUdua2xEbFppYVc5?=
 =?utf-8?B?SFRKdTA5Ym5YY0ttK3dZK3dRV2lQVEcyZHErdjBNOWRsNFAwMjh1M3NBWXVx?=
 =?utf-8?B?b2p5Y0FGTzg5R2RRK3cyYmR2REpRTDNrcjdaN1E4bWhtN3JHaEdHVGVqRW5k?=
 =?utf-8?B?YVNFS1lyL2N5bHVwcnNPb0hUYUJPT3RHWkdaUjdxY2pDdjYvMjBWNFJOb2sw?=
 =?utf-8?B?cHZYazNMTlB3M1VYcDBmeWxCS2NuSWQ1OXAyUHVldWtkT2ZxQkZLbUNBOG9Q?=
 =?utf-8?B?R3E4c09ldkZoSmtoWStZNkZCN255cS9PSURxcTh5TGtOaVRlbFFtWldjUHNa?=
 =?utf-8?B?dnBNbGlndjFkdmtQcHVUODdkcEdOZVZBamsvWjJpN0ZTanhGOWxSSzc0Um1q?=
 =?utf-8?B?NStWNHhuQ3JGVTZSL2RyTmszU3dNdmV2ZVl0RHk5cVcwb0U1Si8vSDhqTkpF?=
 =?utf-8?B?RVl4T1FtZUUybW52Ym92c1lqcjl4YUpTZ1dKbWxJd1QzVW12TndBMlMwUEhY?=
 =?utf-8?B?LzREdk1pa2t0NFcwK1ZJU2hNN05hQ2JnWXAyOUs5ZTdaemNEeXZqalhHNjJT?=
 =?utf-8?B?eHBJMk80OUtRaVkvZit4RU4yVHluY2hqWHJVYWh2QkRUd0o3eFJ1ZFhqK3Jx?=
 =?utf-8?B?RmVWS3M5TEVMRHNuc0I5bEkxNmNQRVJraWJBSWVGRUhHa3FON0JuZVhYSDQ4?=
 =?utf-8?B?Tm9jTDU3ZzhKWHcrSHpYNEZ6QTVzdUpoRCt3WVpvMktEZFl1ZXNBNlBsY0da?=
 =?utf-8?B?cFU4aWZ6eWZ5Y3dZUzJvbGFKUjVQcUsxMFkvN0xyc2p5VWJmTjZtc2Nzckds?=
 =?utf-8?B?WVdtcU8vSitUUU1xcm1JV1Z1Q0J3VHlkbUNxL0tkenRNV1doTTNtWHlUTlRE?=
 =?utf-8?B?MU94Q2Q5VDNnMmxMNnNUbUtKdE1MWjZsSXRhRDRoeE5VVmJuM0Q1Y1NWaDZw?=
 =?utf-8?B?bVo1djJidTZJNWhzeVdEWEFORXdCSDUzWWxvVVl5L1ErdmRiZVhPSjQ5cGhC?=
 =?utf-8?B?NTFmaGhibnpTaGVmTGFKYjJkRjVRd0kwenNTR3llT3c3RndncWNad0Zwb2xJ?=
 =?utf-8?B?RmF4TVpxSkI0andKc0Y3a1V5MEI3bTN2aDhuVVJxSWNlVmI3UFdMOTkyMkdK?=
 =?utf-8?B?Wk5zdk1hQ2h4M2JYY2JtYjZiL1BPcW5TRW1oUDhkUkkySFZkZXd6bnpKSUk5?=
 =?utf-8?B?TVBndmhwQ2l2Q1BNUkl5YWt0MktUc2ZtWlZjTE1CTUdyTWlFRWkrYjByUjJ4?=
 =?utf-8?B?cml3VGFkQVRReUFMVjBqclM5eUxrbndJSEpTZDg3bk1FQkY2MzlHQzg4OVRk?=
 =?utf-8?B?SnhQaVdzOUdjMGwzMUs1alpsZWN1RmpLZWRlV2ptZGpMd0JhZXByNjZMRkxw?=
 =?utf-8?B?U0FXSW11Z2MwSmFJWlh5SkkzVDlXeTJ2bUxNRVN1VlVqVzZRUXF0K1A1Uzlx?=
 =?utf-8?B?dmNHZUV2OWxjcE4xdXcyc3hwamFCdFMvc0pvckdXNE5SRmpnNUZ2K21mTkFr?=
 =?utf-8?B?Vnd0aGM3K3I5czZkNUFtL1JWd0VDUjlnRHBTU1RmSExNcDIxaGZDb1dpWTdJ?=
 =?utf-8?B?eFdyNXlCUm9FZmFuU04ycERTMTlCWGJlSmdKUFhmWUNYNTNFY25lelBCU0cv?=
 =?utf-8?B?ZWU0VDYrVmpnQWM1bGgydXpTVEJYRjZsK2ZzZHp3UGdzTmRZS1ZuOXUzM3g2?=
 =?utf-8?B?TzFKWjYyNWl4VWs5SEtsUzNOVUN5b1Y0ZlBHem5mbklsNFVFSjVxMEJZQmVp?=
 =?utf-8?B?RWM3RUoyM3FTMGpBSWV2UkIzbklqT0N4VVJxbDRVMTVvTzZkNTNYbTcwRkdB?=
 =?utf-8?B?WDI5UUxCcldoYzE3b3ZuVGx5VlZCSVVjT0g5MFY2a1Z1c0ZnMlZjaUZ5ZlQx?=
 =?utf-8?B?VWtXVWxLOXZuSGpZOXZGRjFRU1JPVTBaUDBYR0pJd2xha3NnN3pXSEFlcE95?=
 =?utf-8?B?RFdkamRaV1daaDdMK2puVGs5R0NCczRJYmVoN2c1czE1T1JpMjZ0dTZIVnpq?=
 =?utf-8?B?MEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f823b14b-8004-4c64-0bdf-08dbce52e371
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 14:19:20.2313
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +/RdUhL1IwH6ANKrs5mfIrrIMreNl8rc6f+kB3cmxy3ML06St56oWZl+BEyndr2OHHITa+77ccnpxw13HGZTWeFakNV/GHILe/UoVcCsjLA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7072
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 16 Oct 2023 07:19:37 -0700 (PDT)

On 10/14/23 09:50, Gilbert Adikankwu wrote:
> On Sat, Oct 14, 2023 at 09:14:23AM +0200, Nam Cao wrote:
>> On Sat, Oct 14, 2023 at 08:58:13AM +0200, Nam Cao wrote:
>>> On Sat, Oct 14, 2023 at 07:11:59AM +0100, Gilbert Adikankwu wrote:
>>>> Reported by checkpatch:
>>>>
>>>> WARNING: else is not generally useful after a break or return
>>>>
>>>
>>> What checkpatch is telling you here is that the "else" is redundant and
>>> can be removed. Although your patch suppresses the warning, it makes the
>>> code messier :(
>>
>> Ah wait, after reading Julia's comment, I realize that the "else" is not
>> redundant at all. Seems like checkpatch.pl is lying. So ignore what I
>> said.
> 
> Thanks
> 
> 

Could you consider fixing checkpatch instead?