Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <dc57436b-8483-4c50-a7a9-0f895a494ada@amd.com>
Date:   Mon, 16 Oct 2023 10:47:11 -0400
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, "tony.luck@intel.com" <tony.luck@intel.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH] x86/mce: Increase the size of the MCE pool from 2 to 8
 pages
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>,
        "Sironi, Filippo" <sironi@amazon.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20231011163320.79732-1-sironi@amazon.de>
 <afaef377-25e0-49f6-a99f-3e5bd4b44f87@intel.com>
 <EDD08AA3-C404-4DB6-96BA-2B25519B2496@amazon.de>
 <6591377b-7911-444b-abf9-cfc978472d76@intel.com>
 <1c598798-5b28-4a17-bf86-042781808021@amd.com>
 <dd72296c-def6-4fb3-9984-348641cdb6a4@intel.com>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <dd72296c-def6-4fb3-9984-348641cdb6a4@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGJNYkZOQ280UjZHdHdqbUY5cElRbE1yeFE3akRybVB2b1lYVU1iZzIrU0tO?=
 =?utf-8?B?ZEVjRWNkb05xUjJlRTlycjBvVE1sODZ6Ky9DazFNNTZYNEFXK2tDbFZycFpi?=
 =?utf-8?B?WFNqbExjUmhuYlczOEVhOFlxa003YXp2cVFNV3ZWMFdoSHA2QllmY1ZIUFht?=
 =?utf-8?B?ZUVXMURrUzlCQXJaR1d3YTRndnVVVGF2NktJY2FoZnZOaFRhSlVWSVdROSt0?=
 =?utf-8?B?M3FxOWhXNk5UcmE2QUVhTk94NWdTRVBEOTNIU01CTC9qRHk4R2NmdUF3UW5O?=
 =?utf-8?B?MTViTTNOYkVEbVR0UGJzZTJGRzFuM0hQRFZOZTlYSGMvU0I1UHVmSmJZc3Ew?=
 =?utf-8?B?L09rL2FxeWF2SHBndDZxYVFFOEtuOEpVYm8rem4rWXpKdXdrcjJXbGxCdmFk?=
 =?utf-8?B?bi9Lb0xWODhaR1RxMmNFNlhoNWdzbloybHdiRmtneUZ5N0Q3eHd5ZFdTbnh5?=
 =?utf-8?B?dWNsS082Qm9qYTZWNHJyQVR5c3FGNGxTSFVmcGxLU3ZJa0ZHbnJ4VVVBeElB?=
 =?utf-8?B?K2hZQkxHdUNLMElNcTdKcm90VjloUmFVcXFLWm5ibHJ0cTNudVJ3WUVUQjFx?=
 =?utf-8?B?TjVyN1k0S283OS9OTm9LUGxGOVN1SDcxVUpWRlBlOG9zbUhrdlhJVjY1aHV0?=
 =?utf-8?B?NXVyT001c2VlMy9pK3lEd2d4dWg5N1FYUmVVM2czd2hpZy9hVkhQMm01UEpN?=
 =?utf-8?B?cTl3b3JrTXl4Y2lTZ09xSGhEdnBOeHBpUWZMZldQYm5UT0ZXQlNPeDBYZ3F2?=
 =?utf-8?B?eU5VeUFGTmJMako3bTd4STBxWHlYdTJFdlh6Z0s2WkxncFZPQVFNdXo4LytL?=
 =?utf-8?B?RW0xd1lCbVBveFZGLzdkSHhwdDVNRmRnMUwvNGtKR05LaUpTRm9vRWhTM3RU?=
 =?utf-8?B?WWpxYUF1cHBqclQ5Rm83SU9lSDJ5RGFDWXJGTnR3eXBZdTZpYURrQllkY1Jo?=
 =?utf-8?B?TWJkUlJNTUg2eDNPa0psVlZwQXRjY2hkNitKNElDallQcWdaMUV2R3hweVRo?=
 =?utf-8?B?QjZObjQrT0Y2dlJNU0RDeThLZVZ1K3BiWVUrY2xaaGd3cnZxSWxsdUNVYTRy?=
 =?utf-8?B?a21yRE1pU1hUekhYRFAyYW01blg0R3FvNHB3VDRCczJIUSswNFpCK2d5UXpy?=
 =?utf-8?B?SjNnUnVOU0dsS2FuUUVZVGNxOWhNalRCSDIveGpxZUZVRGZSSVMyZ1Zya0Qv?=
 =?utf-8?B?dUU4TCsvb2xEaFVoVzF6N0N4aEYwYnNZR29CM0dEMjRFSm4yaDc1NzJZWnNq?=
 =?utf-8?B?OVE0UnpGUldPR3lRNy9nMWx3amFXWDM3blJmWlA5TVFxcEd2RFJiRWlSR2Jm?=
 =?utf-8?B?aUgybFRTd0RqRm5EZTNTOHdxL3JNNENSdlZ6Y1BRdWQ1dDFNQklyK1hRVWdY?=
 =?utf-8?B?eDhBd093Y1Z2bnJ2aGZqSW1pMG9EdXgrekZkNFI3dDc2ZzROcVpadG5WakRO?=
 =?utf-8?B?dTVPMXZkeUpnd0ZFcGQyKzVaY295b2xsVnJBYy9Gb2pURVY4eTRja0V3YkZI?=
 =?utf-8?B?ZVE5b2V6SU1LOVV4UFlBZzNLT1l6WHBUZllITThZdXRsNCtnVmJNYVpEZEM3?=
 =?utf-8?B?TDAwS1F1MG55OGlSU0d3cGVXenlyNVUzUHl1NExiblV5R2NkS1Z2Z2gzcTIz?=
 =?utf-8?B?K2Y4UG95bVVVVmR0V3haZlk4S2NiVGVUOXo2NzRyTU9MMDVZc214Nk1LZ29r?=
 =?utf-8?B?ZFUxTVV2Qm1kMDR1TGE3RE1SS0RLM0JKbnlWZ0ZqbUphUVdOWjJ6T25tZmJN?=
 =?utf-8?B?ZEU4c08vRXRsVytVYkJOVUNEbXZLenZzRk9GTDB5Qkc1YnY0RCtncmdtYUZm?=
 =?utf-8?B?NlZxK0tBaHZMcDZINERRL3FVMlZzeXFFWW4wNFZ1Q09QZUpTU0JaazEvRE5D?=
 =?utf-8?B?NXBkMFFBVHB4d0FQY1B6cEFFeFM4K3NuSjFrQ3NJUDJQalcwUy81dlE5OU1O?=
 =?utf-8?B?Y0ZIb0d1QzQvVUxyRHh4ekJ4RGJ1cGxXZHI4WUFaa0d3cW8wdERFdU1uVGZT?=
 =?utf-8?B?QzB5VEttMGplQzhpN3pjY09HemZ0bW5kb0pMbXlWVlM4V1YwTjUvb0E5R04z?=
 =?utf-8?B?dXJldlE5QWJEQm5DZGhYN3pmcmphaWhrODdBbDgvemFhT1V4bVNGam85bGkv?=
 =?utf-8?Q?GhV4A0Pkw74Kznn+ljvonPIi1?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b90e4125-992d-4b26-a2b6-08dbce56c9c9
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 14:47:15.2450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rUfYBYwEKkTgDs80uWoyx+gKoU5mcFI+nrWsAJk8zdUkvIjrF/EEdodirjnU1NMHcTlwTlltq8lvjVu0VsUvkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8784
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 16 Oct 2023 07:47:37 -0700 (PDT)

On 10/16/23 10:24 AM, Dave Hansen wrote:
> On 10/16/23 07:14, Yazen Ghannam wrote:
>> 1) Keep the current config size for boot time. 
>> 2) Add a kernel parameter
>> and/or sysfs file to allow users to request additional genpool capacity.
>> 3) Use gen_pool_add(), or whichever, to add the capacity based on user
>> input. Maybe this can be expanded later to be automatic. But I think it
>> simpler to start with explicit user input.
> 
> I guarantee virtually nobody will ever use an explicit kernel interface
> to bump the size up.  It'll be the same exact folks that recompile their
> kernels.

Right, I agree. My intent was to help avoid a recompile if, for example,
the config size was not enough. Meaning even if a fleet has a custom
kernel with 8 pages of size, it may happen that more is needed. But "may
happen" isn't a strong reason to make a change here. :)

> 
> An automatic resizing one doesn't have to be fancy and only has to
> expand once:
>

Why once?

> static bool expanded = false;
> 
> ...
> 
> 	if (full && !expanded) {
> 		expand();
> 		expanded = true;
> 	}
> 
> It might be a _wee_ bit worse than that because you might have to queue
> some work outside of #MC context but seriously we're talking 10-ish
> lines of code.  It'd probably be even smaller than doing it when poked
> by userspace and wouldn't involve new ABI.

Okay, I'm with you here.

Thanks,
Yazen