Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <2cd89c2c-96fc-8395-2c44-5804fe5c6594@amd.com>
Date:   Mon, 16 Oct 2023 07:49:53 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2 vfio 0/3] pds/vfio: Fixes for locking bugs
To:     Alex Williamson <alex.williamson@redhat.com>,
        Brett Creeley <brett.creeley@amd.com>
Cc:     jgg@ziepe.ca, yishaih@nvidia.com,
        shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com,
        dan.carpenter@linaro.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, shannon.nelson@amd.com
References: <20231011230115.35719-1-brett.creeley@amd.com>
 <20231013150940.50804350.alex.williamson@redhat.com>
Content-Language: en-US
From:   Brett Creeley <bcreeley@amd.com>
In-Reply-To: <20231013150940.50804350.alex.williamson@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTJQYWRQUk05OUczZzdvTTRPcm9wdUROaTFtdXN3TUozaXc3NHFJTitPKzZz?=
 =?utf-8?B?ckFOeUNRMmlsbk5JTWt6ZjBNSUVhcEtZRi9COUtCU3d0TXF4ZEdKZmlHMnRP?=
 =?utf-8?B?SGdZVHgwbk05dHdTMlI5T3NTVXNTeWE4dFhhOStYQVEwN2p0VHFoeS8vd2Zk?=
 =?utf-8?B?QjBuem5udVlGaEhHYXpUN0lvQ0kzWjZKUmpHbWdIb2RDNDU1L0NqYzg3ZnRw?=
 =?utf-8?B?c3VrclFXZkw3Tm9Pa1ozY0x1U0lQRk10K1ZxbEdpVEJJMHp6UXZjYlZJd1p5?=
 =?utf-8?B?WEpiUlllTURzR09pZTFZZXplMmVISndsMUYvRXFPQmNvSkJMTzZFcHVrWjVO?=
 =?utf-8?B?WGl4RnNOME5xS0ZaSmlXUUNjeUl5TmExN0c3YVZOYVFvNmh5TnBsTjl0cEZQ?=
 =?utf-8?B?RHgxcXl3VXVtTmxQcnFtTG1KYUdaMUVyY3g0Y0tqYU1lSnJ0SzUxNGJFeFV1?=
 =?utf-8?B?TkM4Z0t2VjZmV1h0YlBGMXJmaEF2Y0J3NFpiSlplMXdsdllPNWN5bmZGdWZu?=
 =?utf-8?B?TlRKUkwvVEQ0QW9JeXE0NzdmS3hXTEM2azdYUDMrenVxbHR3U1Y0dnVzR3hq?=
 =?utf-8?B?SGtNQm1WOUUrbC9YaDF0YjNGQmJPZXRUb2tqMDZVc1lNYTRYWEQ3dmdORm41?=
 =?utf-8?B?SUVlTlNaMUo3MGsvNHZKbmkxaDRzbWRnbTluVGdieEpzSWcrL3U4Z3cyempl?=
 =?utf-8?B?djdBc3VSemo0ck1tTERmSUxNZmVsNEZ3R0ZFT0tvVXZ4enB4RGdDWE4xQjEz?=
 =?utf-8?B?OGNZVVcyeWJKVmo3SjVkTGVGRVgrMkFyd1dWTmlVeDZFS1VPb0VTdFpIM2RK?=
 =?utf-8?B?T0hVSkFsWEMzUDE2YzMwa2ZMaVUyZHBIbmdPclcyL0YwSEZUbDhsT09FUEds?=
 =?utf-8?B?ZzFxQXZVa2xnYVorSFEyWTNrUk92RlZHWVpDUW9qMk5wSnpmNktpT0c1bmJR?=
 =?utf-8?B?WUdmRG1ObzJ3TS93Y3RNekR4bEtkTGdtMUNWS05uenAxYkh1ZHRnL1BvMXoy?=
 =?utf-8?B?aEg3bUtlOVZONkdOaXJGOG80dkIyNHNsSUdKVGJvUGMwVVNCeTh6UElPdzVX?=
 =?utf-8?B?cXpFYlNFTGRpelFlOEhMeFlRV0FlSVRla2U4Nm9TenJjK2todWhkQUErRTJC?=
 =?utf-8?B?Ym1yYUJ0QzZyYzdFQ3lidVlrSUpaNkRNL0lJQktXS25hSlN2VWVMQm9RN1RF?=
 =?utf-8?B?TDNjenUyUndkaEo0Zlk3NjZLTlhQUGZGNXhUQU9wRjN3OEo2MUdicTNMZ3lS?=
 =?utf-8?B?YnpESXErSUwwWCtYaE8ycCtxSGlXeklxbWVZdldJTllyYjRyODBUaUFwTmE3?=
 =?utf-8?B?Sm9ha0RvS20yOUxBRi83OTBVbEgrK1dLVUFLeDMyOEVVcEV2eFA5OTN3R3Jn?=
 =?utf-8?B?c3NKYzdLa1piaWFGd2xrUXUrSCtwNm9OQ1dKV3d0SkhFelIxem01MjBFNVhX?=
 =?utf-8?B?WUQ4b05aVFAzd1RPZ1JrWk9nTEhwRHdKRkVTMjAyRkN4VVE2cXRCaVY2eTVG?=
 =?utf-8?B?aXU0RFJPbGRtSFV1dTRYaXRxZGZVT1dtTTJEc3U2Sm83Z2o5RXJ6WDFTYTVL?=
 =?utf-8?B?TXVjaDBuMXllcFdxMG9UOG1UMzBFNGJjb0R4eSs3Ni9OMml0d2ttSTFoeXJq?=
 =?utf-8?B?YmlpY2ZkS1Q4VFQ0Q2xhYXBsK0tUYUVIYzZyQWZzQzdzVCtlK0t5cTZMM3ht?=
 =?utf-8?B?b0hOZWlUbXRwNTJiVXJ1WmhiYVZWM3VkWlQzVHN2MFhLbHNUVDNyVFRkT3hD?=
 =?utf-8?B?SkFQeEhiMlpFZllLNW8yb1ZoUTRGek9UampQK085V0IxN1lvdm5rV0R4eWU0?=
 =?utf-8?B?Rk5zWjlYSnhXZTRZZVZnV2NkY0JRRUg2L0haOGxSNy9Henc1eDM5NlFWVlQ5?=
 =?utf-8?B?QkJsMFJ6Z2N6K0N1WTJwVHRDanRlcTlPSHo0UmMvekZnZjBNekVHOWVMakdJ?=
 =?utf-8?B?NGpDZG42cWRJNDkzN2psV2dZYms5MDhvQ3ZuTUJvOEw3S3ZTaWpTejYvL2Jq?=
 =?utf-8?B?UitNbldWeEU0SS9TNjJpSFk2L21QYnE3Nmt2cHRIQlJmVDBNb2RvZ2dsNktq?=
 =?utf-8?B?VEROVHRlRGpieFhMQ01oMWh3M2F2bFgzWEF0QmRvWHVsc3pISHZXdnJPc0xh?=
 =?utf-8?Q?u3RhnPYKQi43KZ1vSD6+HME31?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4086bb57-19b1-4587-6891-08dbce572a85
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB7982.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 14:49:57.5161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IJwdOj1UPOh3a34yS5MyEkhxFaesHJWcAXoYp7SD6QPduWaTqYEbkMypx0F6SMhZnE4TGUXRrUwWyRnHI7mLrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5242
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 16 Oct 2023 07:50:22 -0700 (PDT)

On 10/13/2023 2:09 PM, Alex Williamson wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Wed, 11 Oct 2023 16:01:12 -0700
> Brett Creeley <brett.creeley@amd.com> wrote:
> 
>> This series contains fixes for locking bugs in the recently introduced
>> pds-vfio-pci driver. There was an initial bug reported by Dan Carpenter
>> at:
>>
>> https://lore.kernel.org/kvm/1f9bc27b-3de9-4891-9687-ba2820c1b390@moroto.mountain/
>>
>> However, more locking bugs were found when looking into the previously
>> mentioned issue. So, all fixes are included in this series.
>>
>> v2:
>> https://lore.kernel.org/kvm/20230914191540.54946-1-brett.creeley@amd.com/
>> - Trim the OOPs in the patch commit messages
>> - Rework patch 3/3 to only unlock the spinlock once
> 
> I thought we determined the spinlock, and thus the atomic context, was
> an arbitrary choice.  I would have figured we simply convert it to a
> mutex.  Why didn't we take that route?  Thanks,
> 
> Alex

Hmm. I guess it wasn't completely clear that was the expected solution 
even after Jason's response. However, I can resubmit a v3 with that change.

Thanks,

Brett
> 
>> - Destroy the state_mutex in the driver specific vfio_device_ops.release
>>    callback
>>
>> Brett Creeley (3):
>>    pds/vfio: Fix spinlock bad magic BUG
>>    pds/vfio: Fix mutex lock->magic != lock warning
>>    pds/vfio: Fix possible sleep while in atomic context
>>
>>   drivers/vfio/pci/pds/vfio_dev.c | 27 ++++++++++++++++++++-------
>>   1 file changed, 20 insertions(+), 7 deletions(-)
>>
>