Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Mon, 16 Oct 2023 10:50:58 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     aisheng.dong@nxp.com, bhelgaas@google.com,
        devicetree@vger.kernel.org, festevam@gmail.com,
        imx@lists.linux.dev, jdmason@kudzu.us, kernel@pengutronix.de,
        kishon@kernel.org, kw@linux.com,
        linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
        lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, maz@kernel.org,
        s.hauer@pengutronix.de, shawnguo@kernel.org, tglx@linutronix.de
Subject: Re: [PATCH v2 0/5] Add RC-to-EP doorbell with platform MSI controller
Message-ID: <ZS1N0jgGYfmMsgrJ@lizhi-Precision-Tower-5810>
References: <20230911220920.1817033-1-Frank.Li@nxp.com>
 <ZQtmpL2vCMgR+Upu@lizhi-Precision-Tower-5810>
 <20230930090249.GB3564@thinkpad>
 <ZSVd5GN7lJUfdF8L@lizhi-Precision-Tower-5810>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZSVd5GN7lJUfdF8L@lizhi-Precision-Tower-5810>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amdiQlVZcCsrT3puak9lbnJBUTJ5cjN1TXNNdjZhck5qMzkvVjRtZlVVdGZN?=
 =?utf-8?B?RXhkemg3ejA1bnVGU2NyT2Y1ZUY5SU5QYmdUWkpIS3ZIdy9iOW12bmNIK000?=
 =?utf-8?B?bzFIM29mcm5oOG41cnlWeVpjUVZBbUJJRmZRazkzZWlVcklwNkhOVUJMN2JX?=
 =?utf-8?B?SHFJWDI0d2x1U2FaZlkvWXdmdEE5RnkvMmEzSUdIYlA2cGJUYnNpTU5LZUd2?=
 =?utf-8?B?eVZHUzd6dG5HblZzdmMyRjBNQS9paU5KTXFsQkNIY1hwZmJFcWdaK3hMeHZW?=
 =?utf-8?B?Q1paZE1lbHdaVkdGV2pwcGVHZ0tTOXhUOTQyMXdhZEFvVGFIUEUxUW1DdVcz?=
 =?utf-8?B?d3pQeWthVjQ2WWRyVkRuajNUS2FkOWRYcnNicTh5MDlSYU5TWVBValBIUnZn?=
 =?utf-8?B?S3M0czY1QnRxTnljTzI3eDF4Snhna3dOYUtEejVhSjJzbWlBYUdNUFlwWnpE?=
 =?utf-8?B?UCtvcnlNYno2TWJya3ZtY1ZBSVV2Y3R6bWpDYUFuTlFLT1MxT0NjSWV5ZG8v?=
 =?utf-8?B?b1h1SHBvSkdBSUx0K3cvRHJrOWdGQVBvNFNqTTBEb3FJcmRnN21ET1FKQWFH?=
 =?utf-8?B?dWFsdExJOEVsWG0vN1ZiU1BzVTBYUm5RdldEYmVRSjJGdG10RnhZaTZzRE82?=
 =?utf-8?B?MTlhcGU4MjloUDRGSTJlZndGYkI0UjBVZDB3MzhMUmNGbWFSRm1xUFB1L0JT?=
 =?utf-8?B?VkQxZ3dqa0laTU1zdGlPeVZoNk5zMlQvTERhcWlEUGlaNVUvQ0g3ajZUc1Fs?=
 =?utf-8?B?OVVaV2xCTDdrbU5wd2JINHdybXgxbDI3VzhYVFc5NUlCV3ErV2U4dm05cFdo?=
 =?utf-8?B?cmFhQ21aMVBheE96SHlWQ2x2bUNyK0prOUZTYXliQ3FIOXpjL1dxSnVaclpT?=
 =?utf-8?B?dkpLWTRuRFhDOGZEazJHaWhHY0RJem9VRzVMczY0ajR2aHE2VXFsVmR3emxM?=
 =?utf-8?B?cnFCS2lIbGdGVXhYb0piY29JU2xodytqZFFhK3BiK1ZxYkt1VW0xMTBDQXc0?=
 =?utf-8?B?bVlNQ2J5ZUN5Znc0YkhiRFhLTGI4YmJYSVhyVDlza1I4UFVWNHl5UFVJcXZ0?=
 =?utf-8?B?Z282RXZPamtYRmNXZTl2akhsUnZyck5SOGYvaVpEWitaYTVpbmh3UzBsZ2V2?=
 =?utf-8?B?YThFUGs1UERoZ0JDTndIWDZXcFZrRGVMYjF3RkJHT1dTQ3p0dEN2SWs5cXVE?=
 =?utf-8?B?cExpMEVVNFZxNTJzN1dFTG1kbFhnRWd1aklnOWk3ZFBEWnN6Z0ZPQ1g2ZTFB?=
 =?utf-8?B?U2FUc1hQRko3OE1mamNLU2JNYUdmWkVrb3NqRGNndldtd3pneWpvZU5wNG14?=
 =?utf-8?B?QnE2OG9vS2J1VkY3Ry9kSkpLM2FUTDNLM3ltOGFrWDExVU5UanFDaGhiZmZ1?=
 =?utf-8?B?QjFUTUdIOWFIdDZVWnV1bmxvbzA1c3Q0WEdndFJCSk1SUFU0MWQ1cVhLR1ZH?=
 =?utf-8?B?UUlkYzZxR2VZRURpejVXbHlXd3VxNW5GSUVyckFwZzZhNDRiVTRPbGV5UUZ1?=
 =?utf-8?B?VUJzdVhraFJMNW5uc0dGRFFzeklPbVBDZFUyNld6NXhBdURnRXl5WFBpOGhM?=
 =?utf-8?B?cDE5S3ZwNHFrbUFhWDgxRlNaSXQ5WDFkK3FFUEYwUk1jZHRtbGptcWtPdWQv?=
 =?utf-8?B?UW1SQzJpeVFteGMrUmp0Unk3MnBhSDcyaUplZUxjdFo1cW1SRWNqUnVPWS84?=
 =?utf-8?B?RHdSM05kL2wrU014UUpIc2hTUXhGamtibk5YdVprdGcxUDJBSTdJNkVNSXBu?=
 =?utf-8?B?NUhUbUJmVUYxTnVLUlRTUGV3V1dCMGVSRnZ0VGxpWE12MEpnWVBOUXYzTTJJ?=
 =?utf-8?B?eWJ0OXI1NHoyZlhkS01LOEg0TFFOS2EvNTRQVkIzL3hWU3N3M2UzTS9IUllq?=
 =?utf-8?B?eHcyWkV2NSszNExZZUxNN0RxYldqajVJQ2lTRzBENXkraC9OQ091aEsyTnFo?=
 =?utf-8?B?VXFGaWFEYWZPNlNqckJkNWpBZTN6YjB0ZHlHV0lqcFhrVUI3ZlR0YnVpS0pH?=
 =?utf-8?B?MVFtRnUrTThua3Q1anNMejZZZmRXdE1BMjJtLzEwalk3aThaelozaTJjbGh5?=
 =?utf-8?B?TndhQ3lCaHQrdWIxa3VPNzJULy9GdWRNa0c2NUJ0SlhkTVMvZDNVK015UGVu?=
 =?utf-8?Q?arh4=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e0c0bcc-03ad-4018-7f22-08dbce575530
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 14:51:09.1036
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gFPgsZHfnfR8uNiCRXhnDp7woaAad6cmi41cLvGCdqFIjYbtd2rXv0R/w42obJOi2+dJjeQj69Zo0rDPtbF7og==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9570
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 16 Oct 2023 07:51:40 -0700 (PDT)

On Tue, Oct 10, 2023 at 10:21:24AM -0400, Frank Li wrote:
> On Sat, Sep 30, 2023 at 11:02:49AM +0200, Manivannan Sadhasivam wrote:
> > On Wed, Sep 20, 2023 at 05:39:48PM -0400, Frank Li wrote:
> > > On Mon, Sep 11, 2023 at 06:09:15PM -0400, Frank Li wrote:
> > > > ┌────────────┐   ┌───────────────────────────────────┐   ┌────────────────┐
> > > > │            │   │                                   │   │                │
> > > > │            │   │ PCI Endpoint                      │   │ PCI Host       │
> > > > │            │   │                                   │   │                │
> > > > │            │◄──┤ 1.platform_msi_domain_alloc_irqs()│   │                │
> > > > │            │   │                                   │   │                │
> > > > │ MSI        ├──►│ 2.write_msi_msg()                 ├──►├─BAR<n>         │
> > > > │ Controller │   │   update doorbell register address│   │                │
> > > > │            │   │   for BAR                         │   │                │
> > > > │            │   │                                   │   │ 3. Write BAR<n>│
> > > > │            │◄──┼───────────────────────────────────┼───┤                │
> > > > │            │   │                                   │   │                │
> > > > │            ├──►│ 4.Irq Handle                      │   │                │
> > > > │            │   │                                   │   │                │
> > > > │            │   │                                   │   │                │
> > > > └────────────┘   └───────────────────────────────────┘   └────────────────┘
> > > 
> > > @mani:
> > > 	Do you have chance to review this patch again?
> > 
> > I was on vacation for past few weeks. Will take a look in the coming week.
> 
> Ping?
> 
> Frank

@mani: did you have chance to look at this?

> 
> > 
> > - Mani
> > 
> > > 
> > > Frank
> > > 
> > > > 
> > > > This patches based on old https://lore.kernel.org/imx/20221124055036.1630573-1-Frank.Li@nxp.com/
> > > > 
> > > > Original patch only target to vntb driver. But actually it is common
> > > > method.
> > > > 
> > > > This patches add new API to pci-epf-core, so any EP driver can use it.
> > > > 
> > > > The key point is comments from Thomas Gleixner, who suggest use new
> > > > PCI/IMS. But arm platform change still not be merged yet.
> > > > 
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git devmsi-v2-arm
> > > > 
> > > > So I still use existed method implement RC to EP doorbell.
> > > > 
> > > > If Thomas Gleixner want to continue work on devmsi-v2-arm, I can help test
> > > > and update this patch.
> > > > 
> > > > Change from v1 to v2
> > > > - Add missed patch for endpont/pci-epf-test.c
> > > > - Move alloc and free to epc driver from epf.
> > > > - Provide general help function for EPC driver to alloc platform msi irq.
> > > > - Fixed manivannan's comments.
> > > > 
> > > > Frank Li (5):
> > > >   PCI: endpoint: Add RC-to-EP doorbell support using platform MSI
> > > >     controller
> > > >   PCI: dwc: add doorbell support by use MSI controller
> > > >   PCI: endpoint: pci-epf-test: add doorbell test
> > > >   misc: pci_endpoint_test: Add doorbell test case
> > > >   tools: PCI: Add 'B' option for test doorbell
> > > > 
> > > >  drivers/misc/pci_endpoint_test.c              |  48 +++++
> > > >  .../pci/controller/dwc/pcie-designware-ep.c   |   2 +
> > > >  drivers/pci/endpoint/functions/pci-epf-test.c |  59 +++++-
> > > >  drivers/pci/endpoint/pci-epc-core.c           | 192 ++++++++++++++++++
> > > >  drivers/pci/endpoint/pci-epf-core.c           |  44 ++++
> > > >  include/linux/pci-epc.h                       |   6 +
> > > >  include/linux/pci-epf.h                       |   7 +
> > > >  include/uapi/linux/pcitest.h                  |   1 +
> > > >  tools/pci/pcitest.c                           |  16 +-
> > > >  9 files changed, 373 insertions(+), 2 deletions(-)
> > > > 
> > > > -- 
> > > > 2.34.1
> > > > 
> > 
> > -- 
> > மணிவண்ணன் சதாசிவம்