Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2556753rdg; Mon, 16 Oct 2023 07:59:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF2bOVVjO4JiyzawE8MpKoyjZy4fgnjuI4PfL3Z8KJ3hTSyg64S7lpLeUoS0Sc3n27FV9fz X-Received: by 2002:a05:6359:720d:b0:166:d4cc:ab02 with SMTP id uu13-20020a056359720d00b00166d4ccab02mr226892rwb.30.1697468381764; Mon, 16 Oct 2023 07:59:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697468381; cv=none; d=google.com; s=arc-20160816; b=zzQPXRPS8qa2tZz/B7Mta+GnLp4eamUphzth+1Jk1Dklo7tLKZs7blKifMW8H2rQmq V99NveEbPdVYK0D185zJlpkNnQg6jiI0EWwyds/jY/JuWoX0X01sA+PiFsFiAMaoklm/ x5lK2AX9nLG0jlC9Av+nMjR3KAlqYf4QeORal2gB6YFxXpHCzfODRlJNl+qazcOBhjzR AN4eBvxTTtyjd1Fj/z0tC9jhf87xJ1uAhccgfJaMU7eEAkvokvE92DmNK1iEslxdlFmP 5jI39spxAjxbt4G3TRxhyWMD9sOyPFXNWkcvPk6xe9qGC5QJP4zetJb8/zV1va48Ke3z eaYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gFkyCE/j/0e60Ku5yaM3jpzV/F/AliraLulOb+V5xGM=; fh=pbdktCCt2wJuv718rIqzCC/OpSnBg3qQmTtg1LbUuLo=; b=ALNlIcNv9XONlcbpZoAB7dMLljyy/y33IfgYsdh6g3brwQxy1ry+s5vELJoGrHFk1r PLmzfqtz98PuBzstIzYcATtgfwV/0PX1mwJQr2/vIBY1YAr2gyyY6F/9xEVKq5lCggIH 59Y5Tf0n3W0cXDAjE9/cGUqFGp03IlRDn/b1X95Le88wS+4SyMG5VT0Zo+mvvtd+bgkt z+nsxg+g9VU3Tu2rR3aaEZOKylZ0P3kbueqXCoSa1Chlt+dXS/W8P/qcpuqG07VqbYtf i4t9etJVnqB/RAUs86KyUGIWGeHoWOiukDCcoQ6tojmTmqCa0a5ORoLx7hY+JVjb0hXC m/lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=0IU62ziG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b6-20020a056a00114600b00690cd91cee7si23619200pfm.287.2023.10.16.07.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 07:59:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=0IU62ziG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id CE7738030B6B; Mon, 16 Oct 2023 07:59:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233842AbjJPO7i (ORCPT + 99 others); Mon, 16 Oct 2023 10:59:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232675AbjJPO7h (ORCPT ); Mon, 16 Oct 2023 10:59:37 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2714FD9; Mon, 16 Oct 2023 07:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=gFkyCE/j/0e60Ku5yaM3jpzV/F/AliraLulOb+V5xGM=; b=0IU62ziG5rmbcHYvQNBXR4+5w3 eO35Slox2MlPmqT4idJQZEKEIcbLe5yENIBmvkueQAijLh/NvKWhyynjLi8yh+bwqi1bJ+r1R5teh InQcEAqCY2vKKkV+KtnEMrQLxlyJB6Fwn0l2XT0PsDNrmRdQzPGJJUseK8M5MIXJyXzU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qsP40-002Lxl-PK; Mon, 16 Oct 2023 16:59:24 +0200 Date: Mon, 16 Oct 2023 16:59:24 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , Conor Dooley , Krzysztof Kozlowski , Rob Herring , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, "Russell King (Oracle)" , devicetree@vger.kernel.org Subject: Re: [PATCH net-next v4 4/9] net: dsa: microchip: ksz9477: add Wake on LAN support Message-ID: <18c20ed3-c117-4124-af3c-33df562b7f02@lunn.ch> References: <20231016141256.2011861-1-o.rempel@pengutronix.de> <20231016141256.2011861-5-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231016141256.2011861-5-o.rempel@pengutronix.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 16 Oct 2023 07:59:40 -0700 (PDT) > +int ksz9477_set_wol(struct ksz_device *dev, int port, > + struct ethtool_wolinfo *wol) > +{ > + u8 pme_conf, pme_ctrl = 0; > + int ret; > + > + if (wol->wolopts & ~WAKE_PHY) > + return -EINVAL; EOPNOTSUPP might be better here. I'm assuming there is no other way WoL can be supported, since this is a combined MAC/PHY device. Reviewed-by: Andrew Lunn Andrew