Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2558509rdg; Mon, 16 Oct 2023 08:01:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlKgtAZZwHvtJTNn9RaGqjFypXCipmNSNSlhHpBA5/mADP0/s2T+KNtq1SAwRMnwYB9wTr X-Received: by 2002:a05:6a20:9189:b0:153:b16e:8db1 with SMTP id v9-20020a056a20918900b00153b16e8db1mr35213253pzd.10.1697468495499; Mon, 16 Oct 2023 08:01:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697468495; cv=none; d=google.com; s=arc-20160816; b=jVKrlJHgOxPrpGVkAOtAEjEwQFh9nI4z7ivV+UmEmIsEKk/ClA60DGVS5+LGglQlWT gjxmUlQPvc+SY8uhK4ndfjI7A0KkVafkFrqjRPeOd43l98vZ263Qb885I5ky2w5oOdFO nTjuLfWrst2plkFBrWK8q1RcByUGGUodxbeLU6Cac6PW9dZ9KlKXQH/zAkM7Zly6UFFm V9bFR53ziRNzmKonD1smg7NLkfq6Iw5TX2e6ULJIUXRA5JaFo5tu9NlOtQK29xyfrCD1 4lwmjWQ9J06I9o9U4SO9W6LBXI+rGCLo48rdD/QZbFN/Q+2ruqjZ9yZYZUkFOzaXPxmW wX6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0GLvmKMndiyVt2ULVPwCbqdYlF8TzgXDxAHUw0Tml34=; fh=96xpKCwFENOsvMo2kPOr6D74rQA3lodqCzR9LZFzJ2I=; b=IdZ5epRsZqAjDXfaxP1ASCSm2HzeReduyXLuLhvjjTE8Zrmj/mkVOW7yud5JRofYOy qsys/XcXLmmtpkDFDaBjwElyQjdYcIPss4mahQSBZSdB9caYmhxG565FUF24dKBdukRi 4qD6MryXXq+kOFNo6o+VhlDpfkSJ0lCmmthcQtUb7b8FekLYC/lApCCccjUeb4wWAlHL 6niUmdVa6W/Fyq20Mrvm7nMYqgEv333JFH52tJBIP6izkOsQgPLVjC1FW/S6Fzq86oKt d9DhUeHEOr+PT0I9ETmN8BbcZZyTURJ9lsVlTnZ1KTjw9wzE7lySSjvA4kHhOOHO6QPf wMDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rS2G571H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id e12-20020a63db0c000000b00578c64433c9si11397679pgg.894.2023.10.16.08.01.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 08:01:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rS2G571H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8655D80309DA; Mon, 16 Oct 2023 08:01:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233913AbjJPPBK (ORCPT + 99 others); Mon, 16 Oct 2023 11:01:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233772AbjJPPA7 (ORCPT ); Mon, 16 Oct 2023 11:00:59 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3639012B for ; Mon, 16 Oct 2023 08:00:54 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55C2CC433C7; Mon, 16 Oct 2023 15:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697468453; bh=0GLvmKMndiyVt2ULVPwCbqdYlF8TzgXDxAHUw0Tml34=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rS2G571HfKSELOJ65cQHDl05C83C7XrPtjD2iGcnZJQiCCAXXmXVv4RLjJ3Dj2XV/ FHHkasnnjelj+h0Muc4UED112XsdR8cbC7dOdmur6L4smOq8s3WK1+g5o3qn8o5aX0 XfP59iKl99MUMv/3XQmvYIBLxwSu80CphnkBzbUY= Date: Mon, 16 Oct 2023 16:57:16 +0200 From: Greg KH To: Gilbert Adikankwu Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: emxx_udc: Remove unnecessary parentheses around condition tests Message-ID: <2023101658-unmoral-survival-25cf@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 16 Oct 2023 08:01:16 -0700 (PDT) On Mon, Oct 16, 2023 at 12:35:23PM +0100, Gilbert Adikankwu wrote: > Fix 47 warnings detected by checkpatch.pl about unnecessary parenthesis > around condition tests. And as I have stated numerous times in the past, they are not "unnecessary" at all, and provide a valuable hint to the developer as to what is the ordering involved. So you can ignore this checkpatch warning please, it's not valid as far as I'm concerned for the subsystems that I maintain in the kernel. sorry, greg k-h