Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <1676c7c1-902b-4604-b411-b313c529c3de@oracle.com>
Date:   Mon, 16 Oct 2023 10:25:14 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: linux-next: build warnings after merge of the scsi-mkp tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20231016160616.0286cf0c@canb.auug.org.au>
Content-Language: en-US
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20231016160616.0286cf0c@canb.auug.org.au>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzNMdHJkdElvdENYWnRFcEZWbVp3a0tlT3V4eW1iYkJsQkFJT2R5WTlOdlZt?=
 =?utf-8?B?Q0I4NXBiRHFNOTZyQ3NCQTBVVHRyUDhpek9janFSZG9xSTFKV0h5QjdpZFdG?=
 =?utf-8?B?bXFoM05BcFU0L1MwMERlU1hPMURUQXRHYk5zZ09BOUZNWGlSUm5yaXRUNVRC?=
 =?utf-8?B?VVNNSUt4QmMyeXpsYVJpUnNReWk3SFhobGNuZkNzZWM5aGZ3cjNBc3BkZmhP?=
 =?utf-8?B?WGJEK0VDWEgxcTVyVmNjbEFLSnRQSVVhVWowc3dBbEQ0MnZYcVRvUVR3MTcz?=
 =?utf-8?B?ejA2ZSt4TTNwT3RZMmVOM2NnbFM0SUZZNWxJamlGZEFlN0hIUW5DenpYZ1RX?=
 =?utf-8?B?R1JNOHdDaG03cnZ4eUxSbGlLeERUVVpFazlCSVJGMzF5WEhlZi9VWjhuUUJ1?=
 =?utf-8?B?VXcrWk9NTkRoREVBcXN4NkFrNUt6Qk55SE4rWENjcFlLbVNQazBGMDl6L0Qy?=
 =?utf-8?B?K2pUZDlDTVl0Nnh2VktjNzNDSnhNRERBdmdYL2tZNmlVaE9vMjk4UUFDVGIz?=
 =?utf-8?B?QWpybWkzZUdvTDhJSHR5dHBucFpiQmZjZHZDU3dXQ2dsaDBydjFQakZLamto?=
 =?utf-8?B?b1h3Y1Z1WCsxZjBQMW45MTdhN1pSaWdRVkE1SUZxNG1pcStMdGRXYnlYUko4?=
 =?utf-8?B?TjlqNlRBWkt1S3YxcXRUMWFGY3BySEt0ZlRoVThrUnRTT3ZUNXJ5bVhjOWdt?=
 =?utf-8?B?VWhnYnhuSkU0T2NTeVYwL0dIZUNWS3pxV2h3RzhHUEpzekNCbTlDWjRGYVBs?=
 =?utf-8?B?Rm5NY3hUNzN0TnZ2MjkrWWZXbjQ1UStNRUZiWmh6aGRabnMyS2JrSmVDUWpl?=
 =?utf-8?B?V1dsRHNZWUVPZ0xIUjZpRlZFd1IrVGVLb2tqeUV2d0l1R3NkKzZIK3lNL0xj?=
 =?utf-8?B?RFpMVnVWaDFjWTFjTi84OUdHRllkZjNGQ0RSUjh2VlJDUk1zZlRJbmVxSVV3?=
 =?utf-8?B?RG9xQTAxTUZyOVcvL3hRdng2bU9zeWZHWmwvcGNhVytwVmxyOC80MCtTVVN4?=
 =?utf-8?B?eEdNUnMzVzJ4WExqRHVEL1RuQ0YyK1djQkk5eDl5Ny80bkg4dkpzbHpYRWlH?=
 =?utf-8?B?Y2FHL3FCYzgwR0RSdUt3YXZFeE1jM2dDWVpaMEU5ZXJRaUVHbTlNNktNK3hK?=
 =?utf-8?B?RkV6NlJNdWI3bDZXbVpwRWplVkRjc3k2Y3FLVWNMbGgxbm1IWStGR241RDZz?=
 =?utf-8?B?NVVkaWFMVXFKT0t3U0xUTVVHbTNURmZKWWFSME1DaE80YnFWaE5nUEIwdDRB?=
 =?utf-8?B?OHBLR3JveXBEVlc5OEFjYXhKM0NBZE5EciswOUdCU01scmN0U0h2S3pxaXRH?=
 =?utf-8?B?K2JvbzZPejB0WDhnc1cyUnkwQ0wxVWxxWUpDVG1UVWJYZ2k3YkFlUFpWcTFO?=
 =?utf-8?B?MkdOamVwRFpLb3M4d0FFWjNhU3RoUjlCTHZuV3lmOTBVOFhCdm53TnQ0VEk3?=
 =?utf-8?B?Y05hWlRtWXJRTFUxVG5YcHA0TWlYWTNKakI5aDhTeVBjQ0Uwa2FNNzdYcW5F?=
 =?utf-8?B?eHc2VFE3ZlpUMFNwZms1L01mcVVwSE1JVHZhbzE2VjBXMU53VXNWWURaeGxz?=
 =?utf-8?B?eEZDS2xoT1lYMlQ3K253Mms2bGJHbWcvNmVocm5ObllRbXZFTU91TzB1NkJM?=
 =?utf-8?B?U0t4elU2RTNabTJFY0F6RC9ZUzU0L1lmMVVibHAycVRBL21GdkFTTkU5TGN0?=
 =?utf-8?B?cHBDWDd4eGY4czBQZ0FLN1o1ME9PZkdtNHVRdGo0azRQU2lZRUdqNWltMndR?=
 =?utf-8?B?ZlRUMzM2OWZMM1JlcXU0c0k2L2s1RTBlMXRkeTdHRXlhTVpQSmdXTEJ5Rnh2?=
 =?utf-8?B?azBZU1RlaVBRN3pTeWN4VCtqQmhKNjBvTDkvN04xVmFabHgxby9NOHQyMkxW?=
 =?utf-8?B?RzgyUE1MUmphaUV6Y1JiNXRsdGdUR0JySUUvNERrd3Z0UHhLdXo4OUNUUlll?=
 =?utf-8?B?bWJuWHd2YUY3TTI2aXdRVGhDSTh3RmdQdzNhVjBUY3AyWmZQQ01pQ3hOM0Y1?=
 =?utf-8?B?cUFtWWVyODdrbkJZYnlzOWZjUTMzTVdzOXkyaUVJcHZYbnF0aWZyWnVzV1lB?=
 =?utf-8?B?Nm1XeUs3ZDdoWmR1ZjVsTDRySFdDYWZRd0VkaWxiSzk1dUd4VXUwMnozR3Uy?=
 =?utf-8?B?UWF4cWN0N0dNc0ZkWGQ4Ym9wTnY3NTBDdHZvL3hjdFd3dW4xaDdoUTBwQUFN?=
 =?utf-8?B?NHc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: rAwA+t1DpXAzUYUJaH9bq3SPyWmZSyV+RjcrDyr1q1tRjBOSieTiGoI/1emJUqNZxw3DahMOp2fR0K995WrhrqNQ0lp2rC5YEVTNY9+6mRg5CE7yJMwYaQ6NQ7bkyBgnu2kf+UV9GRExqcWVZSwF2lLptxbRUH9qfuTI1nNQeSkaV9NCGhOC+3NGI8e91Ms4PiGruIMAeVG0WBKnMkPi3Zpcnd7wKAESMCEBdedhzDO10qrlgsbct8QndZC1vCNUtXuup77rkeR2tdYE+qTO6CchMZ1sIHUyOnsrnKP6FCj+owuv46O42b+fZgvH3lLXBhDyl1Fqu5tD30ZmmvyXzUis2XBjA2MCfkyaQjGdSxy28DPvGwINUT3+2bYqItGb6moe4ZAFDviuzwyKoazhpBl2T4XjYXFAYmm83kveVVe2HOrbfEjGCmuzGD4DOwwzY1lwHL2NI1iRj6P2GAi/VLeMHTCjkZFY6+6sIs+U69tFmMhQpnqLfCGnvbpk7jJZhwfCUbXAbmCvPGsoUFNc16J96FNxcO+y3LsQ7ZQvBXhI/wDDU9Z+t26HJzh8LLecniXaqzvqtkYdgVtR/8RE0XPonbhB/cYQukqUKYCV31Mxbq9i76QArlWBl5s/cQSLdwVcz4VmxBSSxNtG79cZX87g7JhoVHio4QD6g9Fuj03Dj8lJS58MTQXrB+jo0373dRmLZZHorec2drkZPiZYAMucPngWeeGcY2JE6W5gVv2CsQgQth110KUgcwxQWRcsrCFiR6J37b/v9QZg/wKG/8CSdOyCAWnWajQ+AO7CiZtyISOuJdG8Z1uWyGrSUuHK
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce53d65c-3361-468f-6991-08dbce5c1966
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:25:16.3120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sg2E5EbHDIBUvYL8gLDBYwRPeaym7lS7vs/XkWGvdh0rHwAQbRssogCEpJnhnP/MaKyeJmMqkP/SEY3RtdIlgfecvipB9HGgNMJaBCH3tdE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6239
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-16_09,2023-10-12_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2309180000 definitions=main-2310160133
X-Proofpoint-GUID: GAS7vpltnlICjg-yE9pk8AmVqucMzM6M
X-Proofpoint-ORIG-GUID: GAS7vpltnlICjg-yE9pk8AmVqucMzM6M
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 16 Oct 2023 08:25:44 -0700 (PDT)

On 10/16/23 12:06 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced thess warnings:
> 
> drivers/target/target_core_transport.c:1930: warning: Function parameter or member 'se_cmd' not described in 'target_submit'
> drivers/target/target_core_transport.c:1930: warning: Excess function parameter 'cmd' description in 'target_submit'
> 

I missed fixing up the param name when I merged some functions. I need
the patch below.


Martin, because this is only in your 6.7 scsi-staging branch, should I
re-send the entire patcheset with this patch merged into
("scsi: target: Allow userspace to request direct submissions")?

Or do you want me to just send the patch below against 6.7 scsi-staging?


diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index c81def3c96df..670cfb7bd426 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1921,7 +1921,7 @@ static void target_queue_submission(struct se_cmd *se_cmd)
 
 /**
  * target_submit - perform final initialization and submit cmd to LIO core
- * @cmd: command descriptor to submit
+ * @se_cmd: command descriptor to submit
  *
  * target_submit_prep or something similar must have been called on the cmd,
  * and this must be called from process context.