Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231013222453.240961-1-daeho43@gmail.com> <b16ea8fb-b3f2-4ae9-c543-cd84e0f3fa48@kernel.org>
In-Reply-To: <b16ea8fb-b3f2-4ae9-c543-cd84e0f3fa48@kernel.org>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Mon, 16 Oct 2023 08:25:21 -0700
Message-ID: <CACOAw_y4L_8YcJu3rK4cFFjwMg+z=XKppTGd2A6F+W9=mMV2Lg@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs-tools: initialize allocated node area
To:     Chao Yu <chao@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
        Daeho Jeong <daehojeong@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Oct 15, 2023 at 11:33=E2=80=AFPM Chao Yu <chao@kernel.org> wrote:
>
> On 2023/10/14 6:24, Daeho Jeong wrote:
> > From: Daeho Jeong <daehojeong@google.com>
> >
> > Need to initialize allocated node areas after memory allocation.
> >
> > Signed-off-by: Daeho Jeong <daehojeong@google.com>
> > ---
> >   fsck/node.c       | 1 +
> >   include/f2fs_fs.h | 2 ++
> >   2 files changed, 3 insertions(+)
> >
> > diff --git a/fsck/node.c b/fsck/node.c
> > index 3761470..6508340 100644
> > --- a/fsck/node.c
> > +++ b/fsck/node.c
> > @@ -127,6 +127,7 @@ block_t new_node_block(struct f2fs_sb_info *sbi,
> >
> >       node_blk =3D calloc(BLOCK_SZ, 1);
>
> calloc() has already initialized memory w/ zero, it doesn't need to reini=
tialize
> it again?

Sorry, I was confused. :(


>
> >       ASSERT(node_blk);
> > +     memset(node_blk, 0, BLOCK_SZ);
> >
> >       F2FS_NODE_FOOTER(node_blk)->nid =3D cpu_to_le32(dn->nid);
> >       F2FS_NODE_FOOTER(node_blk)->ino =3D F2FS_NODE_FOOTER(f2fs_inode)-=
>ino;
> > diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h
> > index 3c7451c..7e22278 100644
> > --- a/include/f2fs_fs.h
> > +++ b/include/f2fs_fs.h
> > @@ -1826,6 +1826,8 @@ static inline void show_version(const char *prog)
> >   static inline void f2fs_init_inode(struct f2fs_super_block *sb,
> >               struct f2fs_node *raw_node, nid_t ino, time_t mtime, mode=
_t mode)
> >   {
> > +     memset(raw_node, 0, F2FS_BLKSIZE);
>
> Ditto,
>
> Thanks,
>
> > +
> >       F2FS_NODE_FOOTER(raw_node)->nid =3D cpu_to_le32(ino);
> >       F2FS_NODE_FOOTER(raw_node)->ino =3D cpu_to_le32(ino);
> >       F2FS_NODE_FOOTER(raw_node)->cp_ver =3D cpu_to_le64(1);