Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Frank Li <Frank.Li@nxp.com>
To:     miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
        alexandre.belloni@bootlin.com, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
        imx@lists.linux.dev
Subject: [PATCH 3/6] i3c: master: svc: fix ibi may not return mandatory data byte
Date:   Mon, 16 Oct 2023 11:32:29 -0400
Message-Id: <20231016153232.2851095-4-Frank.Li@nxp.com>
In-Reply-To: <20231016153232.2851095-1-Frank.Li@nxp.com>
References: <20231016153232.2851095-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IoBqb4FNPokrL02kKzDsKh0FN2+tQuLyUOPGzgEtYslwTLUdJ2I2mvRkzfct?=
 =?us-ascii?Q?UnsVX2jeEiViDKjY7ttXGPaLlr9A8LgSYIdnEJKtTgMuzXsuRr4PZX4v9Kcg?=
 =?us-ascii?Q?BAp/foqajeWElzOBPq34eNaRsRuUFZTYlNSR73QoRnOgkGIw0ruSZjc0uFt9?=
 =?us-ascii?Q?6Rc3/VztkYZdKF/7ie2ySBM7xTbOmyllIhclZF6uUkpf9zw6tNo3X2SiUsY8?=
 =?us-ascii?Q?TPHKpX2nAEG3wS4YeYMSj9yDsgJLMV3Xphs9Gc4Zh4B/L7Wo2ZuQ58swDCSO?=
 =?us-ascii?Q?w60nF1iw0I+2ycqw1d7uZW+NnLF83oUpdEEww88uh/FpWiaMiIFscjiQ5O43?=
 =?us-ascii?Q?x+U0mcplVplUxWW2qOgbFhvNlZKWG9T78QaGvVUkvR9tBMsq1wzIroQLVjAw?=
 =?us-ascii?Q?1v5rXExt5Q68gTNxekBdrYIhw/0LnEAtnthlY39JX4L0UE0ldfG8CKTLGEId?=
 =?us-ascii?Q?xMG6T7Fqe9s2lN7nCcbyHIgqjqmUEotv8QQZSvaroUNUKfXrEBbdQEt9DLWH?=
 =?us-ascii?Q?44boC3YFakrXyb+MGvohu6HBEjumpa+2VsnVPZCkzoRyiakd8Nu2TOc72/lT?=
 =?us-ascii?Q?pZrbIwHUli2P2DLmfKy2OOd39rqGZmTT5l7VNoLkD656wohOFmJUCU5L2Nr2?=
 =?us-ascii?Q?FOi42weOMyVlAGSSzbl4ok20AH5WIX6F40wNm24RaK480J0DcjPSS5oMdUDn?=
 =?us-ascii?Q?Wra8XhAr9XrIBj074AmqmamD1TlGVx0gHoD5iBOJl90FM03ByOFaYxGDuH1L?=
 =?us-ascii?Q?YXXYUsE1kyAYRBcYVDKnDwBhc6f8Lc5M5ujBqAfhfG9JixbrNuZufUtFWSTr?=
 =?us-ascii?Q?ix2fkJwOLQgBgMt9nzqU8nEkopjaYTrIYRqjsSWUPLNi0oaPSol/EIfNPD0m?=
 =?us-ascii?Q?q82+1gJFiWFJriYR2+g55fkGj6q++DTgc3X1VdqugGYXN+UDEFsWBwkMNcfP?=
 =?us-ascii?Q?6XckpfnGXtWnkN0faxRvDKLAFBElF3qAPXAExQgSdr2OLDCc//F1/cy8Xnfv?=
 =?us-ascii?Q?ulkZg3NXsu0lmtii+lUYXKeRnvPOY8ibyBGfPtK8oGBUK3/DoNQVse4VhSH1?=
 =?us-ascii?Q?pwLfIwaPT7g3bHJsSUaLGmH7q9E4RnI4lqkvv/Cavq9QTlPKne5Qsi+thE4E?=
 =?us-ascii?Q?y9UMpxXW7eD/OId+iqJ5a3CEIrvXEsOwTc2Dl5GlQdyiGYWnUaYFr9eAbDZT?=
 =?us-ascii?Q?pIe6nfD0ur+H+rRsQXL6fBWpOwa+v8QKMfhU31nBn8OjabMkw7bmLHlXVRcT?=
 =?us-ascii?Q?PkOXUbFEAhTUyeZc5jnTUZB7dnOTrs8f1CoX55P7dlX4qjp6gHOs0VQYn5J9?=
 =?us-ascii?Q?1nJkrUvTa/vpoPmaGM2WsYaeNMUh8Ries0lVyYiqntvyvBhg0KrE+wHQu/uX?=
 =?us-ascii?Q?XwMga5SSBpoxgmvIVS9oRIiD5S/CWSqoIxNeWkVABWRbLul8iPYp4vLxppnR?=
 =?us-ascii?Q?GXqsSRwmuTLUw6+kQpzuVUr/LhBPReSfZriA3bcce8pJS0MwuIuLpAQPTNO3?=
 =?us-ascii?Q?Qxp36vIuh4Zf0kyM/FsykEE1aggt1HBiQVRskrCfqHVC+3u67HsoUtIey9Wm?=
 =?us-ascii?Q?te5NrHaxIa6Mxd5/0y8=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 228fb6ec-eb36-4ae8-85e1-08dbce5d295b
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:32:52.5814
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s8TH6LOoBvCXB3j3NM3BetkRqfwiIOaRbtjPpHw3s4Jy+SI1PqPDcN0o33A8+Jk6JvnF9NFGvckCHXGJfkIEEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7592
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 08:33:25 -0700 (PDT)

MSTATUS[RXPEND] is only updated after the data transfer cycle started. This
creates an issue when the I3C clock is slow, and the CPU is running fast
enough that MSTATUS[RXPEND] may not be updated when the code reach checking
point. As a result, mandatory data are being missed.

Add a wait for MSTATUS[COMPLETE] to ensure that all mandatory data already
in FIFO.

Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: stable@vger.kernel.org
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/i3c/master/svc-i3c-master.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 0f57a5f75e39..c252446b2bc5 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -331,6 +331,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_master *master,
 	struct i3c_ibi_slot *slot;
 	unsigned int count;
 	u32 mdatactrl;
+	int ret, val;
 	u8 *buf;
 
 	slot = i3c_generic_ibi_get_free_slot(data->ibi_pool);
@@ -340,6 +341,13 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_master *master,
 	slot->len = 0;
 	buf = slot->data;
 
+	ret = readl_relaxed_poll_timeout(master->regs + SVC_I3C_MSTATUS, val,
+						SVC_I3C_MSTATUS_COMPLETE(val), 0, 1000);
+	if (ret) {
+		dev_err(master->dev, "Timeout when polling for COMPLETE\n");
+		return ret;
+	}
+
 	while (SVC_I3C_MSTATUS_RXPEND(readl(master->regs + SVC_I3C_MSTATUS))  &&
 	       slot->len < SVC_I3C_FIFO_SIZE) {
 		mdatactrl = readl(master->regs + SVC_I3C_MDATACTRL);
-- 
2.34.1