Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <19399d81-d61c-9287-3081-e1da5a833984@redhat.com>
Date:   Mon, 16 Oct 2023 17:35:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 1/1] leds: core: Refactor led_update_brightness() to
 use standard pattern
Content-Language: en-US, nl
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Denis Osterland-Heim <denis.osterland@diehl.com>
References: <20231016153051.1409074-1-andriy.shevchenko@linux.intel.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20231016153051.1409074-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 10/16/23 17:30, Andy Shevchenko wrote:
> The standard conditional pattern is to check for errors first and
> bail out if any. Refactor led_update_brightness() accordingly.
> 
> While at it, drop unneeded assignment and return 0 unconditionally
> on success.
> 
> Acked-by: Denis Osterland-Heim <denis.osterland@diehl.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
> v2: added tag (Denis), Cc'ed to the updated list of LED maintainers
>  drivers/leds/led-core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
> index 2230239283d0..89c9806cc97f 100644
> --- a/drivers/leds/led-core.c
> +++ b/drivers/leds/led-core.c
> @@ -364,17 +364,17 @@ EXPORT_SYMBOL_GPL(led_set_brightness_sync);
>  
>  int led_update_brightness(struct led_classdev *led_cdev)
>  {
> -	int ret = 0;
> +	int ret;
>  
>  	if (led_cdev->brightness_get) {
>  		ret = led_cdev->brightness_get(led_cdev);
> -		if (ret >= 0) {
> -			led_cdev->brightness = ret;
> -			return 0;
> -		}
> +		if (ret < 0)
> +			return ret;
> +
> +		led_cdev->brightness = ret;
>  	}
>  
> -	return ret;
> +	return 0;
>  }
>  EXPORT_SYMBOL_GPL(led_update_brightness);
>