Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   "Wu, Wentong" <wentong.wu@intel.com>
To:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
CC:     Hans de Goede <hdegoede@redhat.com>,
        "oneukum@suse.com" <oneukum@suse.com>,
        "wsa@kernel.org" <wsa@kernel.org>,
        "andi.shyti@linux.intel.com" <andi.shyti@linux.intel.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "bartosz.golaszewski@linaro.org" <bartosz.golaszewski@linaro.org>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
        "Wang, Zhifeng" <zhifeng.wang@intel.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v20 1/4] usb: Add support for Intel LJCA device
Thread-Topic: [PATCH v20 1/4] usb: Add support for Intel LJCA device
Thread-Index: AQHZ+nqZYOWB2QQzm0agSGlxpBPNmbBEZGUAgAAEnYCAAByScIABf/iAgAImwQCAAPlcAIACx//wgAAk8gCAAHc9cIAACXCAgAAFf1A=
Date:   Mon, 16 Oct 2023 15:44:21 +0000
Message-ID: <DM6PR11MB4316711C71937AE3C0516C7B8DD7A@DM6PR11MB4316.namprd11.prod.outlook.com>
References: <1696833205-16716-2-git-send-email-wentong.wu@intel.com>
 <ZSZ3IPgLk7uC5UGI@smile.fi.intel.com>
 <6a87b43a-0648-28d4-6c69-e0f684e44eb6@redhat.com>
 <DM6PR11MB4316BE44F53E276384FF06C88DCCA@DM6PR11MB4316.namprd11.prod.outlook.com>
 <5d2e9eba-a941-ea9a-161a-5b97d09d5d35@redhat.com>
 <ZSmjEKfYzFuAHXW+@smile.fi.intel.com>
 <9a080d06-586d-686f-997e-674cb8d16099@redhat.com>
 <DM6PR11MB43169A9ADDA7681DB7D9347C8DD7A@DM6PR11MB4316.namprd11.prod.outlook.com>
 <ZSzogNhlX9njvOIU@smile.fi.intel.com>
 <DM6PR11MB4316382324D15985A70E531C8DD7A@DM6PR11MB4316.namprd11.prod.outlook.com>
 <2023101653-shiftless-scorebook-19e3@gregkh>
In-Reply-To: <2023101653-shiftless-scorebook-19e3@gregkh>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?O3p1aqNxffITVOeIqyiCW7Xs6XuSnKV4RwNMDwsRnxApM3sEInPXirHfP63Q?=
 =?us-ascii?Q?17kzzOdRlTvkLGPkbpX44mctSWEMETpfC/rQDkzzWhKoUsSwuPilofHWIzpg?=
 =?us-ascii?Q?FA74xtq+Dot3gMqm5eX9mBhZGbD7bYg/7Y/dmY3BSPZ0v43Fv3BYQL7Tvs+m?=
 =?us-ascii?Q?MbjoflzdhGdh3nGQQ+td42zCI8GiSNIAycSZlSaVS6/IUw0Q5vEnR3TyDzJR?=
 =?us-ascii?Q?t8XoBU8jmu/g0JhyhKGKLXGxpeGqNTfCI526hmD8ouy6fGV4TrbWwj16ol4t?=
 =?us-ascii?Q?pQkDI0fVo5mHZ3hHQXWSHRvsl1c1UW5+BLqEPomPEpuUVgRxYYfuBzlxvw/3?=
 =?us-ascii?Q?bV4IrswYrKR8ogyasC1SuJ+rxVShn/LUud2Q+zZIyWZttg0Bku1EGaZT59Hp?=
 =?us-ascii?Q?+tfBdKghjdB/s9f68bF0R2D2vLdscLmXy8kijb1/g4QYIFJvoXilRzzprW0X?=
 =?us-ascii?Q?4N5bN2u609aw/Ft41JjWud6TKXiRnKZzVRaVqHQ9xl/cl6azon8MzhzOkHNJ?=
 =?us-ascii?Q?bCPQkrcWLi+ieab/QFtsGWWYWsIJHE+Iriu4i5vlhxNyG2pmu2dxfFo3P9g0?=
 =?us-ascii?Q?jRHPzYNOP+xaVSBtXZ/tJVBLXDSKs+1A35Tf4BZm1vkUuB5tpO6RH2sjP+aJ?=
 =?us-ascii?Q?4zpUg5HrviCmhd/Sib+zAkRHLKJlW2/aUtKJUgwdcRBJXntJvYInjsN54j+W?=
 =?us-ascii?Q?euNsWRviLAYKSOzpotD2+eb+xGXyYnvWIFydTDDg8d00IulXgbIjzXBiY43H?=
 =?us-ascii?Q?B9i0xWW92EqbWtidbOwzCMTUGAXr0zQO6mEQxC4H1rUETjYih8w/iPy7RzDm?=
 =?us-ascii?Q?gjd5lyFih5AXgETAx2d4NlaaTJFcLvhl+vF7bf6bfsXPii0k9r+zRTgvLjBI?=
 =?us-ascii?Q?CgqRH9Y/UDCTKS70mf8jigX90MHOfr3/yX98Nd0goe++DLFmXyjFwe9I8GuP?=
 =?us-ascii?Q?zlZCyE0RgadnM35jeggqqrfArlm8b5uJuxjG6bKIahHQkRWWoAjhgVW1zzUk?=
 =?us-ascii?Q?RFwRnMxV3J2UfdKFJZ+WdsJzVmTbyEkRIqvpmpqk2WYIG4vNenYU9kBYCo8/?=
 =?us-ascii?Q?lAncn0y2ybJjR258bQ2zLXv+PuwqIn115aG/0IdLXNF/gbgsCFaGXBlpqgu5?=
 =?us-ascii?Q?BwXPSZwFCq1JfmVEii1pbrqXKknDGsgzMmKiUXR2oJDTJdTkEwQk5agPEtzn?=
 =?us-ascii?Q?ZNuE61r/+4kmfFSS0rM39NBZD9755h8MByhMMEPB1MF/0Zw4umSjpKPeG7iK?=
 =?us-ascii?Q?8i98tNhWagBqJrQzkn0cLWCiAtSh4D0pJE+/jgePChoo8HuReQ5zwMxWWRi8?=
 =?us-ascii?Q?Fm0nBsphS3j8OD/MwxxORQndGqgDUGNlJK1g+TjS4RQ1Kbe7DWbNNAgoLajs?=
 =?us-ascii?Q?VfR6YUgZm1Mm4XufG1IjQDSfja8Yr/uE0u0jyu2wKBXE+iaiMufnHUxlo7Za?=
 =?us-ascii?Q?AXYArgVoVXfRMMyTqhPIsDY+aR/IuebbfrqRAbuIyv9uOpd5dQlLvIJE1T9V?=
 =?us-ascii?Q?TS5H/OJ37+uSmDQxGDvFz8fvNcg7QzisldS8A4l4HwLFX7vQMuPVamWW9Pjy?=
 =?us-ascii?Q?pqQtb27DoCowMyRjmqwVqabeyN8l35CZZrflAbki?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4316.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fc70d23-2551-4e28-9eb1-08dbce5ec40e
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2023 15:44:21.4191
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g+Cbg9JNniDZTVxvrYJQKiU18U5WQ7R/1G8Yyb0VsInm9/SHSy3CJ4kQxwfcOJwtNZJtMfi1/nCqO4SLlDak1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7621
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 16 Oct 2023 08:44:37 -0700 (PDT)

> From: gregkh@linuxfoundation.org
> On Mon, Oct 16, 2023 at 03:05:09PM +0000, Wu, Wentong wrote:
> > > From: Shevchenko, Andriy
> > > On Mon, Oct 16, 2023 at 08:52:28AM +0300, Wu, Wentong wrote:
> > > > > On 10/13/23 22:05, Shevchenko, Andriy wrote:
> > > > > > On Thu, Oct 12, 2023 at 01:14:23PM +0200, Hans de Goede wrote:
> > >
> > > <snip>
> > >
> > > > > >> Ah ok, I see. So the code:
> > > > > >>
> > > > > >> 1. First tries to find the matching child acpi_device for the
> > > > > >> auxdev by ADR
> > > > > >>
> > > > > >> 2. If 1. fails then falls back to HID + UID matching
> > > > > >>
> > > > > >> And there are DSDTs which use either:
> > > > > >>
> > > > > >> 1. Only use _ADR to identify which child device is which, like=
 the
> example
> > > > > >>    DSDT snippet from the commit msg.
> > > > > >>
> > > > > >> 2. Only use _HID + _UID like the 2 example DSDT snippets from
> > > > > >> me email
> > > > > >>
> > > > > >> But there never is a case where both _ADR and _HID are used
> > > > > >> at the same time (which would be an ACPI spec violation as And=
y said).
> > > > > >>
> > > > > >> So AFAICT there is no issue here since  _ADR and _HID are
> > > > > >> never user at the same time and the commit message correctly
> > > > > >> describes scenario 1. from above, so the commit message is fin=
e too.
> > > > > >>
> > > > > >> So I believe that we can continue with this patch series in
> > > > > >> its current v20 form, which has already been staged for going
> > > > > >> into -next by Greg.
> > > > > >>
> > > > > >> Andy can you confirm that moving ahead with the current
> > > > > >> version is ok ?
> > > > > >
> > > > > > Yes as we have a few weeks to fix corner cases.
> > > > > >
> > > > > > What I'm worrying is that opening door for _ADR that seems
> > > > > > never used is kinda an overkill here (resolving non-existing pr=
oblem).
> > > > >
> > > > > I assume that there actually some DSDTs using the _ADR approach
> > > > > and that this support is not there just for fun.
> > > >
> > > > right, it's not for fun, we use _ADR here is to reduce the
> > > > maintain effort because currently it defines _HID for every new
> > > > platform and the drivers have to be updated accordingly, while
> > > > _ADR doesn't have that
> > > problem.
> > >
> > > But this does not confirm if you have such devices. Moreover, My
> > > question about _CID per function stays the same. Why firmware is not =
using
> it?
> >
> > Yes, both _ADR and _CID can stop growing list in the driver. And for
> > _ADR, it also only require one ID per function. I don't know why BIOS
> > team doesn't select _CID, but I have suggested use _ADR internally,
> > and , to make things moving forward, the driver adds support for _ADR h=
ere
> first.
> >
> > But you're right, _CID is another solution as well, we will discuss it
> > with firmware team more.
>=20
> Should I revert this series now until this gets sorted out?

Current _ADR support is a solution, I don't think _CID is better than _ADR =
to both
stop growing list in driver and support the shipped hardware at the same ti=
me.

Andy, what's your idea?=20

BR,
Wentong
>=20
> thanks,
>=20
> greg k-h