Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Zi Yan <ziy@nvidia.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Zi Yan <ziy@nvidia.com>, linux-mm@kvack.org,
        "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Huang Ying <ying.huang@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/migrate: correct nr_failed in migrate_pages_sync()
Date:   Mon, 16 Oct 2023 11:44:43 -0400
Message-ID: <1B46DDFA-4AAB-4C49-8AF0-65DDDE0EE854@nvidia.com>
In-Reply-To: <20231016154156.1948815-1-zi.yan@sent.com>
References: <20231016154156.1948815-1-zi.yan@sent.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_12D76446-B7F7-4CB6-80A2-1AC99446F504_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QKxtkL65gTZrlVG/fP17jjNTd2vOwdzIlgMcjAHs9lp7bCxCs/bBOVAeurHv?=
 =?us-ascii?Q?vpA9GtlN8a4LL6YcaytLBJnqNTG8WHu9D3amH2nLyOHQzTQ2zVn3fAM9JgkZ?=
 =?us-ascii?Q?7V36E9FLcURrxFf3Q9VtE2R8CqOJ3dy5iGofG/i4q8I03F1wjUyaJSxJgErW?=
 =?us-ascii?Q?go4GIPkwvRAIn2cdrjaUZxDaQrrnOSD6euL1yKfYLRCbzVoD5Z16pK2oXB0w?=
 =?us-ascii?Q?2egkomUjplfLr+UVZ4s9N8jLt8Q8EEOCWP+aFHNYonnPe+8zbsp8Ql4VQ6dK?=
 =?us-ascii?Q?xjn9L4j6Tmd2uDxpCGVDHvyQG0vE+lCTS7j3OU1FPBapMqUudZUgVRXD55sT?=
 =?us-ascii?Q?lddFXKULV0H9DwmliaEDQpzP9zcRZEUJSoyyDu4jGUMtB+abNWd+lBsxcw2l?=
 =?us-ascii?Q?eSFrhApnqwWrgclL6FT6wu6bck4QCcMAZio2ZanSc9Dl1geG/RojOCj1TEgl?=
 =?us-ascii?Q?FVZfoKqOtcAj4I/KJspVKzMd1+bMkLFwMTofWf8fNzq9Rpp2D8FoE2lWKYrZ?=
 =?us-ascii?Q?i6tOUPg3xjmihcJ107v3GzdJ6SOK27TSLTXEZoYpKHvQJWzQzVt9VfIqAv+D?=
 =?us-ascii?Q?dOUapJoshdrBVEY35LhqoOJKYFEBzwbphKb8s7tlrnDu4er83sWanAWOSQwx?=
 =?us-ascii?Q?SZ+ZtNjWcI+RG3fqBqQLTC97VyV96jQvCpfLB6MG+yL6HvRsYf6pKfd8xQs/?=
 =?us-ascii?Q?jOv5SG/HDfyN0PHEvuoWJg4ikfB6eyGkU+Xmzu1pjxVx/H8qv6VgaCtI6HNx?=
 =?us-ascii?Q?IxWBM9BLHo3zd0Qf9nE1KRsGPXUsPSXOyj3xbKdjnCRm6VHc4hHWiNYw/xaM?=
 =?us-ascii?Q?6fjV3p8Rmds9E8OkjSdC6ALxzt4aMm3qlGOKGlldm4LVhjDFmfnDVU+fLixP?=
 =?us-ascii?Q?tx7wHnFh9SH9o6vLzfYr9dHoa6ZbctdFSd7nY1N5g75dF4aat1nNc3lUCZX9?=
 =?us-ascii?Q?nqZCoeHoR2mcgaHeje78TJVbT5g2YwQSfyO7eRVkfevzgGe0hTue8UCpo7vh?=
 =?us-ascii?Q?At9IbuE3Y2WKPypvXiXqWveB8lOL0FwvcgsKLXgx1KXae9bq0AnGJr+T84Qf?=
 =?us-ascii?Q?xgkeXOP6LygYcyZAlTqxQzfoZ26M1CPLdHARuk+aPj6FiV6SkYbxcL6S7U1P?=
 =?us-ascii?Q?/b6U20KsMEelT7S/+G1vQ7gDg+AFzNZDs7mQFnVcdENy6aTLADCgYidVoXWT?=
 =?us-ascii?Q?oXwSw92gF/eGP2btpNeniwUXflJV6C2BbVFo4TIw2xu/BRgpqKyU86yxvnrK?=
 =?us-ascii?Q?GMYamQt5W+PwpRDy0sOnNYnMlQpO/wBFrotd6NjXxtr/8amzGm6JZkwTM1vm?=
 =?us-ascii?Q?rmCx9jU/OJP86ypbtP7oCmQQrkAz2rRaVhexmxdKyDYK9oEU2vCG3rjLmy2d?=
 =?us-ascii?Q?f2GrIXLWBYsXcTaPWDCCkvzGlFxh5jAertzxvvsDlCYmpdijpt3B6LSPAEr4?=
 =?us-ascii?Q?MUhUnhuBPtjtEqgc/4r0JIajOut9YyyIef5SM+JAd1+nZXxjvamfng1yoHGu?=
 =?us-ascii?Q?g0XeU6fVRFq+14KtI++nURDdupEfGF9gkkIuxgj0LnBkOveXly0LjAxl9Ce3?=
 =?us-ascii?Q?832Zi/t/fE8fNpuHd9g=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92eda7d0-c6ea-4f3c-47dc-08dbce5ed2a2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:44:46.0862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n6DBzYMyLo1r6sEKxnSSWS9sClQpbY2EWvaneRwi09AYH8F1AYIzXjXyMf9efqs5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7603
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 16 Oct 2023 08:45:01 -0700 (PDT)

--=_MailMate_12D76446-B7F7-4CB6-80A2-1AC99446F504_=
Content-Type: text/plain

On 16 Oct 2023, at 11:41, Zi Yan wrote:

> From: Zi Yan <ziy@nvidia.com>
>
> nr_failed was missing the large folio splits from migrate_pages_batch()
> and can cause a mismatch between migrate_pages() return value and the
> number of not migrated pages, i.e., when the return value of
> migrate_pages() is 0, there are still pages left in the from page list.
> It will happen when a non-PMD THP large folio fails to migrate due to
> -ENOMEM and is split successfully but not all the split pages are not
> migrated, migrate_pages_batch() would return non-zero, but
> astats.nr_thp_split = 0. nr_failed would be 0 and returned to the caller
> of migrate_pages(), but the not migrated pages are left in the from page
> list without being added back to LRU lists.
>
> Fix it by adding a new nr_split counter for large folio splits and adding
> it to nr_failed in migrate_page_sync() after migrate_pages_batch() is
> done.
>
> Fixes: 2ef7dbb26990 ("migrate_pages: try migrate in batch asynchronously firstly")
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> ---
>  include/trace/events/migrate.h | 24 ++++++++++++++----------
>  mm/migrate.c                   | 15 +++++++++++----
>  2 files changed, 25 insertions(+), 14 deletions(-)

Hi Andrew,

If Ying is OK with this patch, it should place my previous fix:
https://lore.kernel.org/linux-mm/20231009203231.1715845-2-zi.yan@sent.com/

--
Best Regards,
Yan, Zi

--=_MailMate_12D76446-B7F7-4CB6-80A2-1AC99446F504_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmUtWmwPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUTHkQAIuuCAZV6MlknRreqmrfC+oGfuRrwKSQKgk3
AOidkvaI/GJcRablFOtm2M7QlDRDLAfKIbMGLH44YfgrUaEJ+RHfZkJDgrgwcywA
7muLf+OMNd4wMn30Om9DwkKUW1Ip1Leu6sraqSkIOpUcXNgi5Skbl5eEp90kG0YZ
XOOVSabK3mf5Wtr4R+31n3uP7I/T2sj1UAXy8Z+Lb04x/SaeM/0LPqXok/QkhelF
Z+0b2rbQjjDe5uDiCA6hrMhiSPLUj+Q1uyjCdiACkQL7wNvqddK/aqzJZ/OJbyOy
5sjRc2CHgJF2qSn6SYPdtN4Mn9YO3yftk55tztIkqHgYSirwSHFKqInLkLqoPSsx
zT0TB3xTktlkH2inuu+uCDg9/Qxyelt26vtKtsdUjiByf759G6GvZaFEc8+DnBFt
70OmZFsS/P1mjVQN/l4H+rv53l1V6ewjvLPsMl8bVCS09G74GRmngWh1SzQh1dIY
FDpiwoUBN4iM7BqgdkiYFBi6tivLQ1OTLFAphEmRxafwSLS8wkutmYUiTUA3yUGJ
JAyyidQD7aJBbEN1Z/Fmhq1DdXAE5n2Ew5TnzQ2GiwaALvwgkfWBYiYv6+vIQ6ym
FRnFdWIoAPew/DUPuJNSWUDANOgg9FVh5d0yI1DxAs+XOtNtrcIumwlsfWXtIyLS
31Eah86F
=4gEN
-----END PGP SIGNATURE-----

--=_MailMate_12D76446-B7F7-4CB6-80A2-1AC99446F504_=--