Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2599955rdg; Mon, 16 Oct 2023 09:04:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+1HFLdVyyebh0vN7MYROMkKVkaC6cyFkTYPiqoAjDt7w+4EdLd18mVRAqC5X/+GKzvT+X X-Received: by 2002:a05:6a20:2451:b0:14d:5580:8ff0 with SMTP id t17-20020a056a20245100b0014d55808ff0mr32689173pzc.25.1697472255906; Mon, 16 Oct 2023 09:04:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697472255; cv=none; d=google.com; s=arc-20160816; b=MErOqDNnsdBEacb1+KDET7zc+bv1s93ShgBK6gwkkIQPvNGfKNKGEeWBz1CWlh6Bc4 AhAb5bqrNud02hxfdJfN5hxRYJd09rq7ItHfdfHFGh8i5D4ZPeIxvksKmCHERuJEHeDW 0BVA9J8k/vKlQrNSigGcSDG2yTPsKcWorDTQbavX4CIFja7L+seiDffW0WLcRkA1vX3E g67sDPSYM9Zy4TZzoj8zb7AhMfxYX7RlDiE5dIQ18Dxj1E9zhHB4cnPXH65ZJdQmdbVc htdq9cDUbKC/G3pNPfDymvw0wHpRa4RUuYW7NAFQVfjleKuIKv/0nslg+ScDmNJw1o/p y0qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=5vkVd8Qg6hywVMj9DHndckPczrv4NeC8D2izA9F0HYo=; fh=pgCZS28TDf1ZJ6y6McYHN/DxB0SqC2i1f/r1RcaD/jo=; b=bWytP20mpPp/l+PQo1nz4tHNAy32NPLuwTSc/gL2KfPRZ+JO2NhPipCCmwAc386nJs BEyojDE3XATGGxDMeaW3SvuAu11pLOdCGHlREuh8GXarCWS8Q6v886MIr0h28+amr5lv KD0HkJzJvf29DNg2s3u/ZvJh2O315WU84HJ3wdJRsm8eay6CXFK9Ns2r1eKqNb3PNbPO kqROj417CJ6vHNn3Wcv/wn5TsCbd2aV9imrUEbfJJ56flggWw3YvWEnhkeDezJ/eoitY Vqbk/QM+voQQOzuA65x+fC+gvxcLk/x08rFsULEmcMEBqYiwv5FxOZa6qoA5/Z+86NMB ZDcg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id a191-20020a6390c8000000b005ac8d44bad3si7405294pge.445.2023.10.16.09.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:04:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 3E07C80ACFED; Mon, 16 Oct 2023 09:04:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233266AbjJPQDx convert rfc822-to-8bit (ORCPT + 99 others); Mon, 16 Oct 2023 12:03:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbjJPQDv (ORCPT ); Mon, 16 Oct 2023 12:03:51 -0400 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A3BE83; Mon, 16 Oct 2023 09:03:49 -0700 (PDT) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-9ada2e6e75fso829258566b.2; Mon, 16 Oct 2023 09:03:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697472227; x=1698077027; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1o1Sjx05gX0rIxT2he/9e9a3FERmo9S5QHOTVv8X/pQ=; b=OOUsrcj+0/6QsZ4/LeBI8DOmYhG+4LTi+FHHPNMH9lprWi2UArQnUnANL+EmV3GpWW Dh/yEiopewOB0b4z6MFMKehXIQ0wmWdnYfj6CoOBxJjG/sgXrDUOo72AIzF82VCJSuT9 ALKCZj6Ath50RlW+FIrcgem7MwmaSLmVUQqlnjzRFih+yXeSicVyA5wD/OotT6La7uDq DHglFdkmO4VxUdJj26qTRMJcHcIMi/hGF02btBemFKZ258qOVcNlUBLCFh+1hzcyIgUD HJbWglPCQoj9tPqK/A6Ev8RYCwhYxdN8gR9IZzvRs3fR5D47+9s6qs4xNJZVxSyjbOdG kvBA== X-Gm-Message-State: AOJu0YwTge8a39q1b638+stl22PDwfBxnAuVCZWCpi/0032HNZ1ak6R2 cMV12FPDcbwCaMO+IM/Fqty3hSGkC8c7nBiB X-Received: by 2002:a17:907:96a9:b0:9bf:a01c:8213 with SMTP id hd41-20020a17090796a900b009bfa01c8213mr5493708ejc.11.1697472227043; Mon, 16 Oct 2023 09:03:47 -0700 (PDT) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com. [209.85.218.53]) by smtp.gmail.com with ESMTPSA id gu9-20020a170906f28900b00982a92a849asm4283868ejb.91.2023.10.16.09.03.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 09:03:46 -0700 (PDT) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-9b2cee55056so829314766b.3; Mon, 16 Oct 2023 09:03:46 -0700 (PDT) X-Received: by 2002:a17:907:74b:b0:9bd:a669:d682 with SMTP id xc11-20020a170907074b00b009bda669d682mr8603309ejb.20.1697472226085; Mon, 16 Oct 2023 09:03:46 -0700 (PDT) MIME-Version: 1.0 References: <20231016-bt-bcm4377-quirk-broken-le-coded-v1-1-52ea69d3c979@jannau.net> In-Reply-To: <20231016-bt-bcm4377-quirk-broken-le-coded-v1-1-52ea69d3c979@jannau.net> From: Neal Gompa Date: Mon, 16 Oct 2023 12:03:09 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Bluetooth: hci_bcm4377: Mark bcm4378/bcm4387 as BROKEN_LE_CODED To: j@jannau.net Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Luiz Augusto von Dentz , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 16 Oct 2023 09:04:13 -0700 (PDT) On Mon, Oct 16, 2023 at 3:13 AM Janne Grunau via B4 Relay wrote: > > From: Janne Grunau > > bcm4378 and bcm4387 claim to support LE Coded PHY but fail to pair > (reliably) with BLE devices if it is enabled. > On bcm4378 pairing usually succeeds after 2-3 tries. On bcm4387 > pairing appears to be completely broken. > > Cc: stable@vger.kernel.org # 6.4.y+ > Link: https://discussion.fedoraproject.org/t/mx-master-3-bluetooth-mouse-doesnt-connect/87072/33 > Link: https://github.com/AsahiLinux/linux/issues/177 > Fixes: 288c90224eec ("Bluetooth: Enable all supported LE PHY by default") > Signed-off-by: Janne Grunau > --- > drivers/bluetooth/hci_bcm4377.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c > index 19ad0e788646..a61757835695 100644 > --- a/drivers/bluetooth/hci_bcm4377.c > +++ b/drivers/bluetooth/hci_bcm4377.c > @@ -512,6 +512,7 @@ struct bcm4377_hw { > unsigned long disable_aspm : 1; > unsigned long broken_ext_scan : 1; > unsigned long broken_mws_transport_config : 1; > + unsigned long broken_le_coded : 1; > > int (*send_calibration)(struct bcm4377_data *bcm4377); > int (*send_ptb)(struct bcm4377_data *bcm4377, > @@ -2372,6 +2373,8 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id) > set_bit(HCI_QUIRK_BROKEN_MWS_TRANSPORT_CONFIG, &hdev->quirks); > if (bcm4377->hw->broken_ext_scan) > set_bit(HCI_QUIRK_BROKEN_EXT_SCAN, &hdev->quirks); > + if (bcm4377->hw->broken_le_coded) > + set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks); > > pci_set_drvdata(pdev, bcm4377); > hci_set_drvdata(hdev, bcm4377); > @@ -2461,6 +2464,7 @@ static const struct bcm4377_hw bcm4377_hw_variants[] = { > .bar0_core2_window2 = 0x18107000, > .has_bar0_core2_window2 = true, > .broken_mws_transport_config = true, > + .broken_le_coded = true, > .send_calibration = bcm4378_send_calibration, > .send_ptb = bcm4378_send_ptb, > }, > @@ -2474,6 +2478,7 @@ static const struct bcm4377_hw bcm4377_hw_variants[] = { > .has_bar0_core2_window2 = true, > .clear_pciecfg_subsystem_ctrl_bit19 = true, > .broken_mws_transport_config = true, > + .broken_le_coded = true, > .send_calibration = bcm4387_send_calibration, > .send_ptb = bcm4378_send_ptb, > }, > > --- > base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d > change-id: 20231016-bt-bcm4377-quirk-broken-le-coded-599688e3c4a0 > LGTM. Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!