Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2604601rdg; Mon, 16 Oct 2023 09:10:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGQdngt4tTHuLuXC8GpFvf9F42zM33livBUV07NwAtiChNavYn3fbp4MyAzGYdMsA1kF7A X-Received: by 2002:a05:6a20:1590:b0:13a:e955:d958 with SMTP id h16-20020a056a20159000b0013ae955d958mr32809618pzj.7.1697472622795; Mon, 16 Oct 2023 09:10:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697472622; cv=none; d=google.com; s=arc-20160816; b=TccxurtyNJIbPpBjSUIdQNgL/5nM5IK9UX0igBvX5k5zGel23NLTnpApnNJ1gTDIeG CMgL4I1/TU86VjzsuXuK2sy5RmR4Q/j6Z3EVMjrZH/RgDU+jSNN8dm17NdR3EXy/UmsK AweK62C1GW+ctzT58Ya0PzT7QQJhJUYwfu7yjr7LElsVB2Uzha70/YOObTSJhlQR1T6t ufI6HPOPZA2LYKGLgEcTYV8NylVxeUP9pgDZ1jXujXLSrUFKNxLbe/mGdz1V6b7Nu6RE zZUNyWvg3LKp3YWD9p2dUQvX4QWQpP0qQUiHxSkXG1YtFYLuhiBf0dUvHNNWyblSZky3 rTFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=B/oz0uODugJGDz2wuzGYNvP+VRKjoNuxnRKjcNeKNdc=; fh=tUAC4oQq3UuKajr6ZMoB53sspoioCuMU4y0NrDbDhac=; b=QAm9JqkfpYNH2kmLfFTG+zgs7t1QH6O+xCM+yfknMgOwCjTSS0KxobZWQrgf1APcl5 SsfGLSRZjxBFnthfR6M12Mf8a71gU0gb1RtBMNOuZfdt3IKMdwK+UOtEamd2t5B6lp22 9wSPveOlDZ1ylqP4zx5+BFYBG8qM5ZmCzXxa9ksgpm9HVBWrSHo9jRTHWSvxlmCswPy6 ucPJdd1AAx1Q1ggeUw6ote9YSLZE0SVvnBXsYth1K0vGwfzlXGM/b7onDAPHqKqpt78N 844M9DZS3rJ0QdIUyiEi0ML4WA17VaYDy4sYiNTBmkE/V3lsVdTaGn6Z+wJKPx+8iMSv RZrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cUW8pk80; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id w10-20020a17090a8a0a00b0025bb4a1c12esi6739668pjn.148.2023.10.16.09.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:10:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cUW8pk80; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 5A4DA8041C0B; Mon, 16 Oct 2023 09:10:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232516AbjJPQKP (ORCPT + 99 others); Mon, 16 Oct 2023 12:10:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjJPQKO (ORCPT ); Mon, 16 Oct 2023 12:10:14 -0400 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89C2BAB; Mon, 16 Oct 2023 09:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697472612; x=1729008612; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=yOQZfIm040lvmUe2O+DKvT56T78+nm6brIphWp/oItE=; b=cUW8pk80y+3RVyF2reTjUK0cZQ/eEVQZx9bpLrGm4HCPjQq4ACx9QHyx 1u1GXvX7FqRpRnO1cVkZ9ieaUW5KnOdK+ymVRROhfFPBgVIfvRXRpcKEl lhzo5K2D6fHgh8U/JafKsydheZr86jKw0/eAEAIn83bbTBarrc7T+qRro JsB1vS1VvbhojUHkLs9p5FmSwMxBaYDXhrUs1lSFMDCOTtQooWNgSAHV6 ZUg24PvcsgJrdWO0JY5IwWOJRf3cpsp0HnFEPxrkP+T9ZSJD7160sTLwB KWrWECe2OERkRYSBh31xGEoFClDeo8yjt7GmM1kDg3wTuI0hDMeQTsSMG w==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="4175721" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="4175721" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 09:10:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="1087124866" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="1087124866" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 16 Oct 2023 09:10:09 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id EA49781C; Mon, 16 Oct 2023 19:10:08 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 1/6] leds: gpio: Keep driver firmware interface agnostic Date: Mon, 16 Oct 2023 19:10:00 +0300 Message-Id: <20231016161005.1471768-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 16 Oct 2023 09:10:20 -0700 (PDT) The of.h is used as a proxy to mod_devicetable, replace former by latter. The commit 2d6180147e92 ("leds: gpio: Configure per-LED pin control") added yet another unneeded OF APIs. Replace with direct use of fwnode. Altogether this makes driver agnostic to the firmware interface in use. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index a6597f0f3eb4..debadb48ceda 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -11,8 +11,8 @@ #include #include #include +#include #include -#include #include #include #include @@ -129,8 +129,8 @@ static int create_gpio_led(const struct gpio_led *template, ret = PTR_ERR(pinctrl); if (ret != -ENODEV) { dev_warn(led_dat->cdev.dev, - "Failed to select %pOF pinctrl: %d\n", - to_of_node(fwnode), ret); + "Failed to select %pfw pinctrl: %d\n", + fwnode, ret); } else { /* pinctrl-%d not present, not an error */ ret = 0; -- 2.40.0.1.gaa8946217a0b