Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Kuniyuki Iwashima <kuniyu@amazon.com>
To:     <haiyangz@microsoft.com>
CC:     <corbet@lwn.net>, <davem@davemloft.net>, <dsahern@kernel.org>,
        <edumazet@google.com>, <kuba@kernel.org>, <kuniyu@amazon.com>,
        <kys@microsoft.com>, <linux-doc@vger.kernel.org>,
        <linux-hyperv@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <mfreemon@cloudflare.com>, <morleyd@google.com>,
        <mubashirq@google.com>, <ncardwell@google.com>,
        <netdev@vger.kernel.org>, <pabeni@redhat.com>, <weiwan@google.com>,
        <ycheng@google.com>
Subject: Re: [PATCH net-next,v3] tcp: Set pingpong threshold via sysctl
Date:   Mon, 16 Oct 2023 09:49:27 -0700
Message-ID: <20231016164927.30126-1-kuniyu@amazon.com>
In-Reply-To: <1697056244-21888-1-git-send-email-haiyangz@microsoft.com>
References: <1697056244-21888-1-git-send-email-haiyangz@microsoft.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Wed, 11 Oct 2023 13:30:44 -0700
> TCP pingpong threshold is 1 by default. But some applications, like SQL DB
> may prefer a higher pingpong threshold to activate delayed acks in quick
> ack mode for better performance.
> 
> The pingpong threshold and related code were changed to 3 in the year
> 2019 in:
>   commit 4a41f453bedf ("tcp: change pingpong threshold to 3")
> And reverted to 1 in the year 2022 in:
>   commit 4d8f24eeedc5 ("Revert "tcp: change pingpong threshold to 3"")
> 
> There is no single value that fits all applications.
> Add net.ipv4.tcp_pingpong_thresh sysctl tunable, so it can be tuned for
> optimal performance based on the application needs.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>

Thanks!