Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2639998rdg; Mon, 16 Oct 2023 10:08:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGD1WhVCGg/6vCm9/WDnegB2GtnB/BvvjZ6BGnHoKueWbvNBieWzP0OwL+RVWqZ9PzugZ2t X-Received: by 2002:a05:6a20:a110:b0:161:3013:b499 with SMTP id q16-20020a056a20a11000b001613013b499mr40648826pzk.60.1697476115018; Mon, 16 Oct 2023 10:08:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697476115; cv=none; d=google.com; s=arc-20160816; b=ZFkyQY5fB4K3I7hQJvL96XFJ1AZTRLFEIQje9Jt4Bj0bUz/KTpUTRWU8TYssXw/6qO 5Vtyy64Sq+FbTICvk+a9dkLgWU1Z4AAdbf+5HixO53hYXqXFXsKykCeGSz+/mqHulkFa 0xqN/Vbv55DbDvFq4g0Ouru3JKiKC+YKglVT8dm658n/FTcIu0SyG64CgHuFpCV1TdL+ YmHwiP6m+0NSXulnPLuilAe4qoMcgfyL3VXDYgR8JW/JS7jgo4WPpBv9HRyHaIHRMTUg jXPPuyrj05nTaaJDVAhqJ3pbPD+pph2MwrK5hunlTwTtQQ47RspJC5/BzXorgDWtBzgn 3VMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=PDMSeVGI1lziENvZtg9gJFiDQXMa4W5b0OFqgA4HwwQ=; fh=YYrWResMAxfU+C17BdM7l/WUXXvK87rdz5rOaZ9UMD0=; b=dsz/i+WWLMogggIR7SlIMhdIERe/inOtnNsX9X5mVpNc3Wm3Asc/4p9OtcezLDI/ZI Oc3wxujocQZtzS7g38m90RXnBgm1mtU9c7FK0AiZQFHtfFNP3Oh57EyrWxgJdgMzN0J9 0kC1fpVa5JC/Yzdmd83TX8RPylMRZsPVvWBHzC4S7b4CZbchIxKA52hTvNb6MDLUHoSH 5CXof+ATlY75FSAHdBMHSkM25f0gjxyEre+/vsnLc9E2bDAsTVwgcsAZDY0VHpm2skrz Ug3ONOrhLwjA1UHRiIm3aWa2HwVWetvB6GAJJLHToI/utXhGns7Mm0KUBdd/4X4ppJa5 ykHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=HDRnNerp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id x5-20020a654145000000b005780c629ec8si10440153pgp.617.2023.10.16.10.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 10:08:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=HDRnNerp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 459B6804A649; Mon, 16 Oct 2023 10:08:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234021AbjJPRID (ORCPT + 99 others); Mon, 16 Oct 2023 13:08:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343506AbjJPRHn (ORCPT ); Mon, 16 Oct 2023 13:07:43 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1E0D1995; Mon, 16 Oct 2023 09:55:19 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2b9c907bc68so57886781fa.2; Mon, 16 Oct 2023 09:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697475318; x=1698080118; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=PDMSeVGI1lziENvZtg9gJFiDQXMa4W5b0OFqgA4HwwQ=; b=HDRnNerpwc5nZqcWmt63YuY6eWeqvPAzcej/w7FsyGWcUJVgOVWZ15QMaVJx07IbIQ aYzUjF1xGaribZ9vhJl9uS8P0cemg97PFqlXspHqGNu+JWJPdRm9FkbqCPynbU+RoMXM Gm4bY0QRk8tfwTl5WzK57ukVRbkfsCuaG5tcQalneqUMkoYwtRFqnRAJXokFmpg8QMgH QmKfha+l83b9mB2naE05OpCVZKlalQntOMoeOXy3OTeFKhXbP/rSdL+FMZY5aAlkboWz x/SyPVnhfJsQuhKzV5Hs+K29gQC/ISxRrPWw5qsHYnOjXzcTHWhGFhQYLbHplgXpaLOy sRgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697475318; x=1698080118; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PDMSeVGI1lziENvZtg9gJFiDQXMa4W5b0OFqgA4HwwQ=; b=sEQ6odYbvbULzMhmTjBd6yLwfvtVKynDndt8tCqGmIKgu+/oWPzi0dy/8LujUQTjoB JRYinkKxL8T0hY1P2+8ZdNgoBv/5WExOanrC4zvyizj/yLhK0PJ79IqVZ3uIWeix3umy SQUvs0nQWUXejL3hta7vVZnCgtJ9ug4bN5aZp1yGxcjchhVhj5VWxMbwF7HuUlLy/TG+ Od+oSXe3/J2vInfX2wLaiKftYG+xPazB5JPN1eOpXhaAPzo1VvSXJ+QKcgmM0SHs4C1A YdI+Dj4wlDE2rY2e7k5Ya5HEk/tXIc5ZfkS0wRHKZ3hHpXBG/QUllJ6NA2x+O2IM5vqe kU3w== X-Gm-Message-State: AOJu0YwSxZgV9HhHrgLl/QRMcCW5tQLZKUtJKaOmWEegHfVimx5UA7g8 V3nH9VUT/byGXRmoaOnpUbw= X-Received: by 2002:a05:651c:211c:b0:2c4:fe0a:dc3e with SMTP id a28-20020a05651c211c00b002c4fe0adc3emr10626532ljq.36.1697475317654; Mon, 16 Oct 2023 09:55:17 -0700 (PDT) Received: from [192.168.1.103] ([31.173.83.53]) by smtp.gmail.com with ESMTPSA id u6-20020a2e8546000000b002c27cd20711sm31675ljj.3.2023.10.16.09.55.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 09:55:17 -0700 (PDT) Subject: Re: [PATCH v2 05/10] xhci: dbc: Check for errors first in xhci_dbc_stop() To: Andy Shevchenko , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mathias Nyman , Greg Kroah-Hartman References: <20231016130934.1158504-1-andriy.shevchenko@linux.intel.com> <20231016130934.1158504-6-andriy.shevchenko@linux.intel.com> From: Sergei Shtylyov Message-ID: <8b3537e4-db84-7ba7-7c63-0a605631507e@gmail.com> Date: Mon, 16 Oct 2023 19:55:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20231016130934.1158504-6-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 16 Oct 2023 10:08:32 -0700 (PDT) On 10/16/23 4:09 PM, Andy Shevchenko wrote: > The usual patter is to check for errors and then continue if none. Pattern. :-) > Apply that pattern to xhci_dbc_stop() code. > > Signed-off-by: Andy Shevchenko [...] MBR, Sergey