Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <e82fc689-5cc3-d799-6e5f-a9e4ac98e26f@intel.com>
Date:   Mon, 16 Oct 2023 19:27:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [RESEND PATCH V9 3/7] cpufreq: amd-pstate: Enable amd-pstate
 preferred core supporting.
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
CC:     "Huang, Ray" <Ray.Huang@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Viresh Kumar" <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>,
        "Oleksandr Natalenko" <oleksandr@natalenko.name>,
        "Karny, Wyes" <Wyes.Karny@amd.com>
References: <20231013033118.3759311-1-li.meng@amd.com>
 <20231013033118.3759311-4-li.meng@amd.com>
 <20231013160128.GB36211@noisy.programming.kicks-ass.net>
 <DM4PR12MB6351E2E9504B57BD40DAE985F7D7A@DM4PR12MB6351.namprd12.prod.outlook.com>
 <20231016105845.GA33217@noisy.programming.kicks-ass.net>
From:   "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
In-Reply-To: <20231016105845.GA33217@noisy.programming.kicks-ass.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qzl1VE00UzFKeXRtdU00L3J3MjduK0gvTTlpSm5aL1plL2VmTjY1U1lISHQ5?=
 =?utf-8?B?NjFadDN4aWRYQUNQQ3VwRzkycEVaS3lZWjExUHhrWmtIaTlLSjEyRzJRcjRi?=
 =?utf-8?B?akF2dkhNajc5aDVOM2pPdU5aN25kaGJPMGwvc0FqWTJZUjRIbG15Y3I0aTlE?=
 =?utf-8?B?bFd1Z0orcFB0d0UwTEVKdExJc1lBRVo2ZGJ6VFQySi9GRlJvZEN1ZUZYdS9P?=
 =?utf-8?B?cjlSUkg2WEsyWTBRNlZzUEZhWWxEa0dxRkZNSXhmcjd2TEQzdkJIWVJRVzA3?=
 =?utf-8?B?R3NSNno1NFJPVlgwNTcwaEF0ZVREeldVcktSL2xOSDNpMEdPQm9Cc2t5U0pZ?=
 =?utf-8?B?Rk5nczE4STJERm12N2YydDMrTWxKNzVzUlF6Wnh3Mk5iclEwc25La01oQ0Rj?=
 =?utf-8?B?cUJ1QktEb0NxM0E4ekh6dlhMMGczUkxvUkRBRTF6Z3VrYThMdkE0YW9WWWJm?=
 =?utf-8?B?dEV0K0ZaV3F4dHo1ZzFvU3VVblpUQmRBNEtzT2tweVRaQytWU09qZ1poak5t?=
 =?utf-8?B?aGNSczErOVI3elk2dmdiZzluQWtHb1hlelVhYTI5WXVTT25weEdrNThHTnhV?=
 =?utf-8?B?RjBoRE1oTCswZENiaW92aFkxRm1SdmtzejRXNjdRZCsyeXRFd1E5WktsS2dG?=
 =?utf-8?B?OFhoamFpenpwaTVKKzBmMi9iRUZRTzBvNlkxclkzejNLRm4wYi9QN2labldr?=
 =?utf-8?B?dE1WTEgyMWNlWUw0Z2prTzhZdnVXR0lFMnhGRXp4TFdadVltaitrZHJCVlBo?=
 =?utf-8?B?K1hoRzBwT0h4bGp5MUR5TVhNb205TVhxc0tTRWZUSHZYUUNtdVdwSzR4SUEx?=
 =?utf-8?B?blBCQk1tL3dtTDVaMk9CclhhRUdaN0x4OCt4em84d3ZnczREd2ZMYjE3SW9h?=
 =?utf-8?B?ZGdwMlZjdWF3TE5hQXlPYVVlR294b3Q2M0Q2Vm43WFF4bHl6YUVLWmY4K292?=
 =?utf-8?B?NllFWXRUR2F5OFJ1ZTg3OWo1RTF1YTkxQWFnbnNDOE1odEpuWHc2WHlpLzVr?=
 =?utf-8?B?bDdPQlNTS2hZVGdKdjNrZ3RVTVQ5bWxZUElCampydnAyWlVqRXlqUFpBM3hh?=
 =?utf-8?B?ODRPckN2NVdyazZDMlJ6T0QwUFhWRGpzelA0Q2h0WDRodndLemZXNHJQM2lK?=
 =?utf-8?B?Y1ptNW9BLytGZEplTHFqRmp4YTIwZXZoM1VzemNWa2NMdDdTenE2OWdDNFM1?=
 =?utf-8?B?eW5KWU9BbzRlYU1WL29JbUZPL1R4enVzN0dpSG4zYUF5VEpBM3JmeHBrc093?=
 =?utf-8?B?RTV6OFowTDRHZDE5NDNpOHpLZHUreHZIZkprU3Fsem9sWHM4QVJyZkVlUHZ4?=
 =?utf-8?B?SXFwMEVESWQrVmJ0ajg2VUt1ZDhWMjE5TDFzSDMyNm5sM0E1dVhaaDJvK3lG?=
 =?utf-8?B?a1d2dGx4NFdIUEdWc1Bwa3RHNFZrMmlWbEpVNWxIWHIvaG96Vm9BQ3hqenBP?=
 =?utf-8?B?QzNGYkRuc2w1QktNajN5M1B1Qjh1bjY4R0EraWwyY0liNklyQnpyWndHVG5k?=
 =?utf-8?B?MXdEeW5VUFo3Nm5hNndvMFZHT0ZWeUZPQm5kUzZSMTNUK2JBZlBCRjh1dnFC?=
 =?utf-8?B?ZFd4WC9hNTU2M09SMTVhdjVVM29WZDlMQlpkRGYxd3N2SlJSc1RYbnhWR1F4?=
 =?utf-8?B?Q0s1a3ZOL3IzVEZicUlMRjFQK05oMDBUQ3BZWlNNbE9CSFVUcHpXWHJPVGdW?=
 =?utf-8?B?QzZUc1RzMWY3K1RXS0Zmam1ySU4yQWpoU1NGTDFIcmwrRmxwZ3dOQzFzenIz?=
 =?utf-8?B?eVBFRy9FbUlVTUhKZnRxdWFuWlZhNHJtRW85RWFpVWpMUUgrL1h6eWtRVWZK?=
 =?utf-8?B?QWNtY3AxSkFvVGJyWlFLRXpndnlLZ1o5cnZhZzlNU1RrbE5ZUWJ5cjV0bUtD?=
 =?utf-8?B?SXlEVzhGYzFVLzJzcm04blFmMENHUk5FSUY1RWRGYkQ0K0p4NnpyQU5hRmZ6?=
 =?utf-8?B?cDhSaG90YitoY2xwdzFBTFJoTzFYMHFRaU1nVlo0VzFtZTZzd2ZhUzBpYUN3?=
 =?utf-8?B?d0dzdHZKOEhhN3VDOWVrOTg1UXYxQTVRUnhnQ052VnNZNlZOdmNITXJ4bDRl?=
 =?utf-8?B?TlVJWUNLdTVwd05uTmQzb0VUYmFJYlIvSnlZWXV5ckRMaWhJcDg0TWQxOFJs?=
 =?utf-8?B?NTYvc2plT3hHbnBDZWs1VkdZV0hlMUNCY3RhQmZDTkx6Y3dZMlNndEpDTHpU?=
 =?utf-8?B?aXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 86243206-5069-4e18-7e11-08dbce6d2179
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 17:27:11.4062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3eTYn9fFAa7Ho1BShqUDYB/7sZLJANQzse8ADU1C/bDdw4+QUTTl3He4U17EyWxd+V+iGdqwUlsbyvoZplgtwG5wBkrkA33ocJn5UtcJaSo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6027
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 10:27:32 -0700 (PDT)

On 10/16/2023 12:58 PM, Peter Zijlstra wrote:
> On Mon, Oct 16, 2023 at 06:20:53AM +0000, Meng, Li (Jassmine) wrote:
>>>> +static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata) {
>>>> +     int ret, prio;
>>>> +     u32 highest_perf;
>>>> +     static u32 max_highest_perf = 0, min_highest_perf = U32_MAX;
>>> What serializes these things?
>>>
>>> Also, *why* are you using u32 here, what's wrong with something like:
>>>
>>>          int max_hp = INT_MIN, min_hp = INT_MAX;
>>>
>> [Meng, Li (Jassmine)]
>> We use ITMT architecture to utilize preferred core features.
>> Therefore, we need to try to be consistent with Intel's implementation
>> as much as possible.  For details, please refer to the
>> intel_pstate_set_itmt_prio function in file intel_pstate.c. (Line 355)
>>
>> I think using the data type of u32 is consistent with the data
>> structures of cppc_perf_ctrls and amd_cpudata etc.
> Rafael, should we fix intel_pstate too?

Srinivas should be more familiar with this code than I am, so adding him.


> The point is, that sched_asym_prefer(), the final consumer of these
> values uses int and thus an explicitly signed compare.
>
> Using u32 and U32_MAX anywhere near the setting the priority makes
> absolutely no sense.
>
> If you were to have the high bit set, things do not behave as expected.

Right, but in practice these values are always between 0 and 255 
inclusive AFAICS.

It would have been better to use u8 I suppose.


> Also, same question as to the amd folks; what serializes those static
> variables?

That's a good one.