Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <1c5b051e-8ee2-6f61-dc18-3c6f75b428d5@redhat.com>
Date:   Mon, 16 Oct 2023 20:38:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2] ACPI: resource: Do IRQ override on TongFang GMxXGxx
Content-Language: en-US, nl
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Werner Sembach <wse@tuxedocomputers.com>
Cc:     Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231016160828.373599-1-wse@tuxedocomputers.com>
 <CAJZ5v0itvrL7ijh07kB6i6o0ShCboWhv+09Gzo299DLK+GkH1w@mail.gmail.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <CAJZ5v0itvrL7ijh07kB6i6o0ShCboWhv+09Gzo299DLK+GkH1w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 10/16/23 19:33, Rafael J. Wysocki wrote:
> On Mon, Oct 16, 2023 at 6:08 PM Werner Sembach <wse@tuxedocomputers.com> wrote:
>>
>> The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding
>> for the keyboard to work. Adding an entry for this laptop to the
>> override_table makes the internal keyboard functional.
>>
>> v2: Rebase onto linux-next
> 
> Hans, any comments?

No comments, the patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> 
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> Cc: <stable@vger.kernel.org>
>> ---
>>  drivers/acpi/resource.c | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
>> index 18f6353c142e..15a3bdbd0755 100644
>> --- a/drivers/acpi/resource.c
>> +++ b/drivers/acpi/resource.c
>> @@ -497,6 +497,18 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
>>                         DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
>>                 },
>>         },
>> +       {
>> +               /* TongFang GMxXGxx/TUXEDO Polaris 15 Gen5 AMD */
>> +               .matches = {
>> +                       DMI_MATCH(DMI_BOARD_NAME, "GMxXGxx"),
>> +               },
>> +       },
>> +       {
>> +               /* TongFang GM6XGxX/TUXEDO Stellaris 16 Gen5 AMD */
>> +               .matches = {
>> +                       DMI_MATCH(DMI_BOARD_NAME, "GM6XGxX"),
>> +               },
>> +       },
>>         {
>>                 /* MAINGEAR Vector Pro 2 15 */
>>                 .matches = {
>> --
>> 2.34.1
>>
>