Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2695068rdg; Mon, 16 Oct 2023 11:51:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHn+V+DDoUp1Qh0NZHIqJ61aj4EnbgcB1v8odldFzrJwqEoDp9McE2yusd51j+cxlat/OTN X-Received: by 2002:a05:6870:1244:b0:1e9:e76c:2706 with SMTP id 4-20020a056870124400b001e9e76c2706mr9563518oao.52.1697482314659; Mon, 16 Oct 2023 11:51:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697482314; cv=none; d=google.com; s=arc-20160816; b=qW5E6uPCIWZrWP2S1OuIf7+CYhoG++8VlLmQE8nmhR0V1jaZCADAge4fpGXyjKKxUE oO+ibZfu4pLbnwIlHsT9gNeFe3NKN9NEMH+n85QsdQ7FWylQDOVtimJi41y0h+mlu0iI f9ry0tOUgKGaROcDVeCBlsUsbnUtLjE384p1aRHVT1+YJ0G1aq416musDN3Cjn3VkaOr MUj26A1cKwsfaRxJirE3f2IwNN5PKt8Bz6wkZgL4zcm4rraWboRNsi2BXQhgTJBTA+oH YW6ytTDShkVq6jxcsXJGdmVuwQ4b2ivXCe0kHLR+67FHhsGrPYWDHxFqBOdumXkAPm8z /45g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Wwyvx5/r8DlWIuvuE4BUh+Q9q3Bnv0KVmOjBo7ltZXc=; fh=D6WY9dczyT84PsCTKrLiCKxb0xzBJnzEJe/kdWMWRHI=; b=DokbxLL3oHJNh9yRNj730Qlokz5dzY3yd8pWXetOmyZ5DigJkkDI3wCi7jQV9MlroW /dLEMTSwhx2Jjg4pDO5LHnHs9HcOoKF9x2crgTj+MpUVZHvdUzpXIRI6utwrG1KqFgd0 YMdjITSxCijh5MMdI+AkYgLM6z534w/Yv7GfN9nUKjMKQvensKglyLOVk8CUvRSVxqwU Vn/zbq/a5NceKacjee5vGOO34/k508av1n7AadxbMMyDe0wiIz9Gg/weUDLypGKv6hdL ZlDDRNF5uS/7mMkmsP/5s9BawsqvkEVge3VMM7pRNUYhPqLa9f+1THyvTjqLPUBDdaKx hicA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="k/5f58ra"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id bw42-20020a056a0204aa00b005b3097b75c0si6401240pgb.56.2023.10.16.11.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 11:51:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="k/5f58ra"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 935ED80490A0; Mon, 16 Oct 2023 11:51:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234098AbjJPSvc (ORCPT + 99 others); Mon, 16 Oct 2023 14:51:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233621AbjJPSva (ORCPT ); Mon, 16 Oct 2023 14:51:30 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64FD4B4; Mon, 16 Oct 2023 11:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Wwyvx5/r8DlWIuvuE4BUh+Q9q3Bnv0KVmOjBo7ltZXc=; b=k/5f58raupQlNvFhnq37aIF13s qHQDwHS6afqKSVr1Rd9g4bmtP+l0nwuqh2BJTRap9cuKw9DPYVDFkPcHgr20mwrQoG6jLr+cMhBo3 hFmo907zgy7HtutXDHVT+cWGmq3/YPJFvHF/Fcn/bBzY6afqxjpXZjj4+4S7k/2oiLZ4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qsSgS-002Nqg-3b; Mon, 16 Oct 2023 20:51:20 +0200 Date: Mon, 16 Oct 2023 20:51:20 +0200 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernek.org, Justin Chen , Broadcom internal kernel review list , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "open list:BROADCOM ETHERNET PHY DRIVERS" , open list Subject: Re: [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Message-ID: <00893dd5-8717-47cf-a0f5-b79f51a2ba99@lunn.ch> References: <20231016184428.311983-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231016184428.311983-1-florian.fainelli@broadcom.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 16 Oct 2023 11:51:52 -0700 (PDT) On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote: > The .probe() function would allocate the necessary space and ensure that > the library call sizes the nunber of statistics but the callbacks > necessary to fetch the name and values were not wired up. > > Reported-by: Justin Chen > Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165") > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew