Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Mon, 16 Oct 2023 22:05:55 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     Florian Fainelli <florian.fainelli@broadcom.com>,
        netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        "open list:ARM/Mediatek SoC support" <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next v3 1/2] net: dsa: Use conduit and user terms
Message-ID: <20231016190555.svp5rjtheogxlkzv@skbuf>
References: <20231013215251.152912-1-florian.fainelli@broadcom.com>
 <20231013215251.152912-1-florian.fainelli@broadcom.com>
 <20231013215251.152912-2-florian.fainelli@broadcom.com>
 <20231013215251.152912-2-florian.fainelli@broadcom.com>
 <20231016132334.b5pz7kw5oitk32z2@skbuf>
 <ea6918d3-7e8c-4e31-9efb-cb9f3360962a@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ea6918d3-7e8c-4e31-9efb-cb9f3360962a@gmail.com>
Precedence: bulk

On Mon, Oct 16, 2023 at 09:41:35AM -0700, Florian Fainelli wrote:
> > > @@ -29,7 +29,7 @@ static inline int dsa_tag_protocol_overhead(const struct dsa_device_ops *ops)
> > >   	return ops->needed_headroom + ops->needed_tailroom;
> > >   }
> > > -static inline struct net_device *dsa_master_find_slave(struct net_device *dev,
> > > +static inline struct net_device *dsa_conduit_find_user(struct net_device *dev,
> > >   						       int device, int port)
> > 
> > Please adjust alignment.
> 
> checkpatch did not complain and my editor shows me the alignment appears to
> be proper, what am I missing?

I didn't realize that the length of "master-slave" is the same as that of "conduit-user",
sorry.

> > > diff --git a/net/dsa/tag_8021q.c b/net/dsa/tag_8021q.c
> > > index cbdfc392f7e0..71b26ae6db39 100644
> > > --- a/net/dsa/tag_8021q.c
> > > +++ b/net/dsa/tag_8021q.c
> > > @@ -468,10 +468,10 @@ struct sk_buff *dsa_8021q_xmit(struct sk_buff *skb, struct net_device *netdev,
> > >   }
> > >   EXPORT_SYMBOL_GPL(dsa_8021q_xmit);
> > > -struct net_device *dsa_tag_8021q_find_port_by_vbid(struct net_device *master,
> > > +struct net_device *dsa_tag_8021q_find_port_by_vbid(struct net_device *conduit,
> > >   						   int vbid)
> > 
> > Alignment.
> 
> Likewise.

My mistake, sorry.