Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Mon, 16 Oct 2023 15:32:31 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Conor Dooley <conor@kernel.org>
Cc:     miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
        alexandre.belloni@bootlin.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, joe@perches.com,
        peng.fan@nxp.com, alexander.stein@ew.tq-group.com,
        haibo.chen@nxp.com, ping.bai@nxp.com, xiaoning.wang@nxp.com,
        sherry.sun@nxp.com, linux-i3c@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible
 string
Message-ID: <ZS2Pz1HxUgrx4+0R@lizhi-Precision-Tower-5810>
References: <20231016152450.2850498-1-Frank.Li@nxp.com>
 <20231016-chatroom-regulator-a75f1d8be809@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231016-chatroom-regulator-a75f1d8be809@spud>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QufDXmQ4u6vnhyLodTmma4hIK5gTZYUK47dB93mu8boFh8T0It1eMOjaQrli?=
 =?us-ascii?Q?W2MLp5XSzQEoB3zczQ37OysfwZd6soeAJJlJxlVbwb9F/yUvrZQsSYIv52Jt?=
 =?us-ascii?Q?vJXWihM81rcJX++AFDrsvcFpqvHfLKpYlHCVWNE51mzXDvliRRsaFGkX7EB+?=
 =?us-ascii?Q?Ta1/k7q7feODJ794GIghPEp7xDUXfzuFaYHBYX5bFuQv8WVGlOjTFMuxC0On?=
 =?us-ascii?Q?TeDWkL6jlHtfwLgVBktP7FhNM50VvMy9e/fGJjbafYL3oiQMX5juwjSvLTAi?=
 =?us-ascii?Q?v3WJt1xkRDaJve0FAc+qkJfN79hnaDROJg9omJefwshtfiO70QzsX4XMcZ7z?=
 =?us-ascii?Q?8G5VkY774H+eyVZsS6EEldQ6QJ5OCGEz6cUjuhmVgO9C2RIaT4d7eZ4W01D7?=
 =?us-ascii?Q?weGOaNQWUIQE5l+FZGUj7C1i67oN5EZab6Pi50dFMu0kJTuJBnDXP1+Fvwak?=
 =?us-ascii?Q?GK0FS+Z1RG92YEwdQunpkHZv2HCewfFinrohEsX3PGdUoW8T+radyOUTaFcR?=
 =?us-ascii?Q?ggt2X245hvmJpqav/gyaDRc6biPt2WYr4OdGPTjR0aaqie/L/UFUN6Hi+OXu?=
 =?us-ascii?Q?40mzrZkMrkY1EbnB5JLEULXEXbc0ufCFfKET7ic/XPMNi7KcHv4WKROaCclW?=
 =?us-ascii?Q?kn74M4oFdqowgzPEpnC8iU3mbfJW1xYcJvaFwOc9Qr8KZ6lIysVWerY7ePUv?=
 =?us-ascii?Q?qHFbS5aZteX0kcoSknmFq/ts46SYB0/Jaq4F9XTt6cr3Pz28ZSMBZkoR5zeS?=
 =?us-ascii?Q?H1bb+Ck3FinDItBEMxswuGD6sl4c3/7Jbm8mzunasX8yE+Wx+OjDQ8p6RLdi?=
 =?us-ascii?Q?bh47C8T/YPSOZHEnzLABEGdS/nXUUJTYOimbMxrbYUcLpPD6sEv2JPXdU3pY?=
 =?us-ascii?Q?YvnvTQrOZs1R2NUjRUmscjdU60BdwT9T8Cck0kIn+/SxoN6mr0NlH1KmJmpL?=
 =?us-ascii?Q?dQW5NVkILUpBAQV/FXCoRCyPV0kQQQ4C/UV/U5YU0nm9u2sJaxy531Jmss5q?=
 =?us-ascii?Q?JgICANZyYrLuCGX+Vvv7DQhHLewouucN6hkHr0eksQ1P+r/5CYJyDVTh/x/8?=
 =?us-ascii?Q?5tjdXP/U0Wu2DxytzeRDvM9xRPGYkaq06jFkswAu5LAi6legYHjwjX11ESEz?=
 =?us-ascii?Q?VNbn5h90ucLVToayrBhKymL6UWqbny8dd/OoB7Xrd5BQm6DoGDwGWWBQK+yW?=
 =?us-ascii?Q?35CgcVa0UuzrPQRnMeJJH2rLGpQgho50DFrTJT6NCrCdOvZepQhX6vgqyCAT?=
 =?us-ascii?Q?w8hX0Xl6Y0hFW2+aEXNe4ScBgTebmBKmZ0s6t5M8uhCAi4pvwl37UlWTg5VP?=
 =?us-ascii?Q?GudSolQZaUqD5zBgXbPHFrIylx5H158tG7nRQQoHRDrDUo5ZIiHY+kuxjS8R?=
 =?us-ascii?Q?RJRbp3b38SCyjvoOofEQPIPhCpRcQow5YsTFet4IYxykMApz4EQgaXKciJfd?=
 =?us-ascii?Q?BWEW2cwQUNPovAj/HGw3LHxQB8SywzGz1jzrvo0p48t5ovuGY07WH4p68Kl8?=
 =?us-ascii?Q?bPJZODu4qzR5ZbJIbN7Ou+s461qJFG5ppcW/Nln5pNTOs9K1X/qsXuFQdyxr?=
 =?us-ascii?Q?g/qbdCqRFl3ghBZ9NwndYZQCw4FwvR0PiJv+Mi7z?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6a00b65-07fc-403b-5b84-08dbce7ea9cf
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 19:32:41.4686
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nYDtZh2iG98KiZ3Upc+M1JkVdjB1lK0cg1P+4QZ+2/pixqzMnBVwFtwMQwAuwHZmkZ/rXJL4TCNAT+3uVKTcIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8739
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 12:32:55 -0700 (PDT)

On Mon, Oct 16, 2023 at 06:30:11PM +0100, Conor Dooley wrote:
> On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote:
> > In driver, compatible string is silvaco,i3c-master instead of
> > silvaco,i3c-master-v1.
> 
> And what makes the driver right & the binding wrong? AFAICT, this is an
> IP sold by silvaco & the -v1 suffix was explicitly requested during
> review of the binding.

The driver existed for the long time. DTS files already use
silvaco,i3c-master.

There are two options, one change doc, the other change dts and drivers.
I think change doc is easiest ways.

If there are v2 in future, we can added silvaco,i3c-master-v2 in future.

If everyone prefer change drivers and dts, I can work on new patch. Just
break back compatiblity.

Frank

> 
> Thanks,
> Conor.
> 
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> > index 133855f11b4f..19e3f75eb45c 100644
> > --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> > +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> > @@ -14,7 +14,7 @@ allOf:
> >  
> >  properties:
> >    compatible:
> > -    const: silvaco,i3c-master-v1
> > +    const: silvaco,i3c-master
> >  
> >    reg:
> >      maxItems: 1
> > @@ -49,7 +49,7 @@ unevaluatedProperties: false
> >  examples:
> >    - |
> >      i3c-master@a0000000 {
> > -        compatible = "silvaco,i3c-master-v1";
> > +        compatible = "silvaco,i3c-master";
> >          clocks = <&zynqmp_clk 71>, <&fclk>, <&sclk>;
> >          clock-names = "pclk", "fast_clk", "slow_clk";
> >          interrupt-parent = <&gic>;
> > -- 
> > 2.34.1
> >