Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Mon, 16 Oct 2023 16:10:57 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Conor Dooley <conor@kernel.org>, miquel.raynal@bootlin.com,
        conor.culhane@silvaco.com, alexandre.belloni@bootlin.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        joe@perches.com, peng.fan@nxp.com, alexander.stein@ew.tq-group.com,
        haibo.chen@nxp.com, ping.bai@nxp.com, xiaoning.wang@nxp.com,
        sherry.sun@nxp.com, linux-i3c@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible
 string
Message-ID: <ZS2Y0YRPItYhUBXE@lizhi-Precision-Tower-5810>
References: <20231016152450.2850498-1-Frank.Li@nxp.com>
 <20231016-chatroom-regulator-a75f1d8be809@spud>
 <ZS2Pz1HxUgrx4+0R@lizhi-Precision-Tower-5810>
 <6110c58a-8003-4889-9a4b-6a7d1821c00e@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6110c58a-8003-4889-9a4b-6a7d1821c00e@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oqE0vA8ycYn9eVXs6qXnn6G5C1s3MQpTvGZZp6zYIHvh4aAaYW9RWcba2VBk?=
 =?us-ascii?Q?pe/0k96DvCc+aHtfzu5T1t5zdupeLGCnk1ZiQXstAGgwdK+Qzg/e+IJOQqCq?=
 =?us-ascii?Q?nQ0lXoCOiJKLIOgBAjjwB2a/Z03DKqxhfBqjMtUfvGhI1dAN+XIOLo4mLDzO?=
 =?us-ascii?Q?c7Qh22oyEpnm96NseOVoliSouhe/yivUNQyPcWNOoKbz49r7ZTIfmmuRrdDo?=
 =?us-ascii?Q?BzsJF9KMCwZ2Fw3+9sUuyngm9bG9ZgDnTvNCa31VJfLKMEcrGTWd0dhsGuNQ?=
 =?us-ascii?Q?xBjiDWsb3w+ve4VrjUMsEn3htG6f+MFfmsjLB1ln9hEqLqtBHkl5peY6cFAr?=
 =?us-ascii?Q?PMquRzrK1k/1A8kUs6qBiCJVDKFbycoRFwmVcyCk4zcH3y3xJGzTXItB6Q7i?=
 =?us-ascii?Q?xEYpYxvU8sCJbyxlP6p34WkgZnsc+49Zczy4oyUV2L1jvYsymuMI0oO8mTqs?=
 =?us-ascii?Q?Jap8wSW9QTenbLAEF9y6SjpuIVBWsDuFJSRLRnngUKRkKRnwc3HN9/YrUNeL?=
 =?us-ascii?Q?TFyDx/XJSKRoigO6O5eZ9QV+BYY7sJCf5TJj8pKq1qU7hoOblv99ujEEgExK?=
 =?us-ascii?Q?y+rgM0m/ADw4Cuc8zE8FgVx6v4DgnYZ17YgR/SaIUCJVWYGG9Gna5OZKpCXs?=
 =?us-ascii?Q?wdGjr+gy+8S0EOZDx4z7t25GkKiqVeyMwqtwsyAT0C8DCHd1ePVB/gINV1SS?=
 =?us-ascii?Q?Sm28EloLz7fe+jWvM0w0CQX529yaPOH8gTypZEzw3hU6tb9r5rbCjDoJW8Nq?=
 =?us-ascii?Q?nZDzpViwGPtc8i9cYXbg05e0009FXKNP4JiqhYVIBauDjY4x0ZGaTVN6pOB4?=
 =?us-ascii?Q?EHbk3sw01FqRLbWD2YPQWP6hQR+nbUQ1/L0DYZXZyX0YRRJ4dO7TJZL1BiXx?=
 =?us-ascii?Q?IzugtE9ahjTAI955Kb0u+6BMJRoZX/bHQDa17DeOTH2QMtGrDgX20+//63DT?=
 =?us-ascii?Q?3E4nRnN998RNw08Ht/DQiFUzWoN/kw+NUUJ/0+T0/wNRsDzpItR0W0jjwR4y?=
 =?us-ascii?Q?HzvLzeMV/5BHrAcdpU8g3liScu/AGyjrnrdEQmpkhuYhUrQb0aD6PUjf0NhQ?=
 =?us-ascii?Q?90wpYOvjFActwvxbTEvffkiwkr5eUBJSyLrycVimuYEU3fiUTDmkwdvzk+Ij?=
 =?us-ascii?Q?bBl/8TudBbPxokFYdzRTC5TqD6mGxQl/yiy18boXa2U3v4NF4qtoOzgeYSK2?=
 =?us-ascii?Q?ZzaDLD7NxR4Zyz2/uxC4T9RYnxh+qA+ivZ9/0Pp1GTrh2T5TopuQZrzMzxNb?=
 =?us-ascii?Q?/D9wFEPrWKn7WnFv0/3jQxUKjsoTJ1ofbaRRZdQ78C4t4VLPy/Nq3ko1QM6a?=
 =?us-ascii?Q?VlhogYNYOsd3RwDB3g09Pac9WzdEFZqInAaFvAEwoMm4l8xspMm6iXJBHTYr?=
 =?us-ascii?Q?lrVr5hKQ5PpKIf/EzFcinUKxPKHxswcSHUheQra+eFTucLzXSPdg2xUQYQvH?=
 =?us-ascii?Q?/ehq7rT2UAMwJnwnILzAFOEacHILcVb3Pt/yP4DAn9uh2Shx/OKp6daYgPp1?=
 =?us-ascii?Q?hewuIbUTeVtQIIunX7pcnt1449Zf8ufVOzjPDxazux+isS+oM/y4xOf9AWpH?=
 =?us-ascii?Q?TXd8yr8c6QCq7kVqUBVU1qU3RLnExaI1a8Fx9niq?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 102c6121-8704-4e51-353b-08dbce8408e7
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 20:11:08.6299
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vJMqZulxdHkH7UxeckmG/xQpOhNaubWXE1I3jfV8bC9prCw7q4Mvye0syxpnzxs2LN0+22990xZ9G7Zv2Ib7tw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9389
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 13:11:39 -0700 (PDT)

On Mon, Oct 16, 2023 at 09:57:18PM +0200, Krzysztof Kozlowski wrote:
> On 16/10/2023 21:32, Frank Li wrote:
> > On Mon, Oct 16, 2023 at 06:30:11PM +0100, Conor Dooley wrote:
> >> On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote:
> >>> In driver, compatible string is silvaco,i3c-master instead of
> >>> silvaco,i3c-master-v1.
> >>
> >> And what makes the driver right & the binding wrong? AFAICT, this is an
> >> IP sold by silvaco & the -v1 suffix was explicitly requested during
> >> review of the binding.
> > 
> > The driver existed for the long time. DTS files already use
> > silvaco,i3c-master.
> > 
> > There are two options, one change doc, the other change dts and drivers.
> > I think change doc is easiest ways.
> > 
> > If there are v2 in future, we can added silvaco,i3c-master-v2 in future.
> > 
> > If everyone prefer change drivers and dts, I can work on new patch. Just
> > break back compatiblity.
> 
> No, because Rob explicitly pointed out too generic name.
> https://lore.kernel.org/all/20210111200821.GA2978830@robh.at.kernel.org/
> 
> Is it some way to avoid implementing feedback or how does it work?

Downstream use silvaco,i3c-master to match driver. Anyways, miss match
happened.

option 1: fix doc
option 2: fix driver and dts

what do you perfer? 

> 
> Best regards,
> Krzysztof
>