Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2751341rdg; Mon, 16 Oct 2023 13:49:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGi7JCiBXXica0y6w39LnpN3M2Jzyx3Rxu77j7nUnJBVsW32/AUapu375kXQyB5cOP4AXOO X-Received: by 2002:a05:6870:44d0:b0:1dd:7f3a:b703 with SMTP id t16-20020a05687044d000b001dd7f3ab703mr292309oai.0.1697489349012; Mon, 16 Oct 2023 13:49:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697489348; cv=none; d=google.com; s=arc-20160816; b=yp1ORMRk9ZOgBBPvGLeQg1lecHUHjeR2m9KvyIgjcN+o+jEzI5R/zzUJyMcFHmg52o GbnIqJ0Br+qjq1jXdi2jJQ6yxVGiu6eNOc4B/LObc+BtOyQ/F9bSMgq0qYAPXTk9yhWm WYyzJ2lpjYJhrlF8FanQSBE+eQ0WAHViX4jBb2QXhExxcKlfq2zdSuJa7/gYJO2EuVKi M8VBXtqpRDt0STJbRYNcb2IBB8XNI1yMT2UBiWPltmXIPszcoNszvv8aiF+ifWVZg4qr MJpmLkrF/u9+Ar/ridwKTZKE2eB2HZx5+qPgEmmlxDGsbt6pXvXJfrHteT+FpCS8H1uy tOyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id; bh=KV9prvHA0M7QZinlPb4BQohxb6H26VD1PfEbZdebscE=; fh=SAU7AvhYe4l5lw5+kT4PJCHQ6LHm4MmC8Kt5xM7iARs=; b=E0mbPdcjim8KsJW8IRAhR4hurxxjUFNEtBDDAcyn74PQ8yjfIGuh98VVl8+FZDSFnm DsSqKxpY9YGL++o8rixJYemQ6+7olKphYzVuHPJtGnGsPR61LG8JJcX0zVlERp97352h qsstvX2xL7V4R270b4suET7DVUqAwvOu2NsKzxSBttgs/Bskh3hziX3TZ8t0cyk3BElG hfnvrEfnbNq9XmXQM9FTBX1yMjfVBs2OesPZOV7uQaU85FQ0XaX/s4L6LicGs9fkYcY0 k8vs7tilm600lGvQrusBSLZea9J/Q6b+Wol92Ks6GYj36+haY1901df5nAxgT8BEONfl YTyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id i69-20020a636d48000000b00578c9144910si123609pgc.410.2023.10.16.13.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 13:49:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 431AD803957D; Mon, 16 Oct 2023 13:49:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234169AbjJPUsw (ORCPT + 99 others); Mon, 16 Oct 2023 16:48:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233992AbjJPUsv (ORCPT ); Mon, 16 Oct 2023 16:48:51 -0400 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 433D5E1; Mon, 16 Oct 2023 13:48:49 -0700 (PDT) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1c434c33ec0so31592735ad.3; Mon, 16 Oct 2023 13:48:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697489329; x=1698094129; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KV9prvHA0M7QZinlPb4BQohxb6H26VD1PfEbZdebscE=; b=v4DyTWJr3pNB3KbHIypP7K96FMywZAOb8y+GXRGvvZE6Hr2zX8uqPpU9P4Q0j8zZ6Y /itKtgScVFwa97JLiWm+XtlTNBpTXi8bzKHSDdSZla35PQY60HO4/VU7Q9tp8t3XHdQK B9I4D3SQFL5s6uJnUHreylLu2qLyH0zMmnf7cEvIBDCJtZXEJSJtC+TdsuIxE/OmhR1L HKdDN4A6qBPxMrxu0rHOsfaIVQhn2rCX1b6Q2U3w+ClALO9Y5B1pIb807QAWXFNkTbmU 7S7ubXya5O0ZDRLi4dIZr7Pf3ptgBJr+ILqlWs5LApnEq0//La1p59imV4oJQOlsfueC G/Kw== X-Gm-Message-State: AOJu0YwjaLHA86TiDfzO3hW6BNgTT30bzOeQTKzQriEpJuOuWsXC/s3Z 6A+DYdOgxXaNhcwhVfg+vVV43t2YTyD/Eg== X-Received: by 2002:a17:903:1206:b0:1bb:6875:5a73 with SMTP id l6-20020a170903120600b001bb68755a73mr499453plh.2.1697489328546; Mon, 16 Oct 2023 13:48:48 -0700 (PDT) Received: from ?IPV6:2601:647:4d7e:54f3:667:4981:ffa1:7be1? ([2601:647:4d7e:54f3:667:4981:ffa1:7be1]) by smtp.gmail.com with ESMTPSA id e13-20020a17090301cd00b001c88f77a156sm51257plh.153.2023.10.16.13.48.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 13:48:48 -0700 (PDT) Message-ID: Date: Mon, 16 Oct 2023 13:48:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] scsi_status_is_good() uses __KERNEL__ constants. Content-Language: en-US To: enh , Linux Kernel Mailing List , linux-scsi@vger.kernel.org References: From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 16 Oct 2023 13:49:06 -0700 (PDT) On 10/16/23 13:42, enh wrote: > Without this missing #ifdef, userspace code trying to use this header > directly won't compile. glibc manually removes it, bionic removes it > using a script. If we add this, the preprocessor can remove it instead. Is that the right solution? Shouldn't these software projects be modified such that is *not* included? Thanks, Bart.