Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231016093309.726436-1-yangjihong1@huawei.com>
In-Reply-To: <20231016093309.726436-1-yangjihong1@huawei.com>
From:   Ian Rogers <irogers@google.com>
Date:   Mon, 16 Oct 2023 14:04:30 -0700
Message-ID: <CAP-5=fXwAbaqqYVE_9y6JbkQ8rkU-f38ZB0gbpZdg10HLtyYzQ@mail.gmail.com>
Subject: Re: [PATCH] perf pmu: Filter out search events table of software pmu
 in perf_pmu__lookup()
To:     Yang Jihong <yangjihong1@huawei.com>
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 16, 2023 at 2:35=E2=80=AFAM Yang Jihong <yangjihong1@huawei.com=
> wrote:
>
> For software pmu, the events_table is empty, reducing unnecessary search.
>
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>

I'd rather that all PMUs behaved in the same manner without ifs that
will catch people/me out later on. perf_pmu__is_software tells whether
the kernel context is software and therefore whether events can be
grouped with a hardware event. As a test for whether json exists or
not I'd rather stick to values derived from the json.

Thanks,
Ian

> ---
>  tools/perf/util/pmu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 6428e2648289..59c8394a4efa 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -1033,7 +1033,8 @@ struct perf_pmu *perf_pmu__lookup(struct list_head =
*pmus, int dirfd, const char
>                 pmu->id =3D pmu_id(name);
>         pmu->max_precise =3D pmu_max_precise(dirfd, pmu);
>         pmu->alias_name =3D pmu_find_alias_name(pmu, dirfd);
> -       pmu->events_table =3D perf_pmu__find_events_table(pmu);
> +       if (!perf_pmu__is_software(pmu))
> +               pmu->events_table =3D perf_pmu__find_events_table(pmu);
>         pmu_add_sys_aliases(pmu);
>         list_add_tail(&pmu->list, pmus);
>
> --
> 2.34.1
>