Date: Sat, 17 Nov 2007 10:46:52 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@tglx.de
Subject: Re: [patch] Printk kernel version in WARN_ON
Message-Id: <20071117104652.8240af62.akpm@linux-foundation.org>
In-Reply-To: <20071117103947.5b2052f8@laptopd505.fenrus.org>
References: <20071117101552.2a7f34cb@laptopd505.fenrus.org>
	<20071117102720.251107d7.akpm@linux-foundation.org>
	<20071117103947.5b2052f8@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1232
Lines: 37

On Sat, 17 Nov 2007 10:39:47 -0800 Arjan van de Ven <arjan@infradead.org> wrote:

> On Sat, 17 Nov 2007 10:27:20 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > On Sat, 17 Nov 2007 10:15:52 -0800 Arjan van de Ven
> > <arjan@infradead.org> wrote:
> > 
> > > @@ -35,8 +36,8 @@ struct bug_entry {
> > >  #define WARN_ON(condition)
> > > ({						\ int
> > > __ret_warn_on = !!(condition);				\ if
> > > (unlikely(__ret_warn_on)) {					\
> > > -		printk("WARNING: at %s:%d %s()\n",
> > > __FILE__,		\
> > > -			__LINE__,
> > > __FUNCTION__);			\
> > > +		printk("WARNING: at %s:%d %s()  (%s)\n",
> > > __FILE__,	\
> > > +			__LINE__, __FUNCTION__,
> > > UTS_RELEASE);		\
> > > dump_stack();
> > > \ }
> > > \ unlikely(__ret_warn_on);					\
> > 
> > that made our 1100-odd WARN_ON sites fatter.
> 
> by ... not too much at least, gcc ought to be quite good at merging
> same-strings into one, so it's just one extra pointer argument
> 

I think I knew that.  At 1000 callsites.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/