Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2777658rdg; Mon, 16 Oct 2023 14:54:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwO496ljcE9N1JhUNP+jsXjtnWCk3GfnGv8yUj0GaVpzw3Y8vGQmMXkmg/LDT1UjcPlY/q X-Received: by 2002:a17:90b:3c4e:b0:27d:1862:a494 with SMTP id pm14-20020a17090b3c4e00b0027d1862a494mr400203pjb.11.1697493258919; Mon, 16 Oct 2023 14:54:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697493258; cv=none; d=google.com; s=arc-20160816; b=rt67rpv8zOYvWt4avy6cNosbwE/T/MDkyGovmdhUVUUfcG8KzC+9FD1oPnzG1GT+YO SE/BUugV7bVjFV/MeSbt00BNyFHcWVpKT7Bz3wEWODCO6NkK07LpTKNUrJn5nEidF/i1 6Wpk2QVmp9Sy/FvprPBVa4eHMvddGCbiqzAOv6c89oXsq3CN+xhV6RjWX25DgSCzXAr7 gddPww/ZciZIt5twOPPcZSXOiXtkSBVoyyFuJlDhVK/iM2Zo5/MeMeKwRM2Rk8P7R1dr S3jpAcGlO63q7yG7WicpXKrH7/wk3CQXidfLDqI39wo6QeNvF6UOGKV4ZTUoJqctYZL9 B4bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ygerzOtwqrr8fAWTrYYV3xuUT6j+7VIW2dGFPkp8Svs=; fh=CWspvewZlAmXeAeLchwibq2eS4Le4I0vkHzBig4bdc0=; b=HOtmGNidKD2kmJ2AOtvj5y1ueFs/vVyXXlIyJh3kefEpBPQ0bXaZ+9wAe7T9p+nosp uO8kM+vSy2Jdxk6q5xIoqxkBU6L+NYeRxFvEsqJurvg8YizfKA4BIk4JHESeGnV67q6H 1aodifchlKT4ZKfQbBdWMOO1N7ttu6YjpEMthCHMPvyJqQoOkBdTyHuPNfTyXZTqV+WP UcnDCMmcN7P1X3wJDR60/tAYzu/Mfqmg2sEW2wFmi5bv6SNttv6lO9USjNAKaE2GyTFB 5l6XJA6O3llxh68JFgI9XS2P4bBMcNbA1JACKkdi8nStpJYLOOk0N3AO5yplMEV6aeDx Lz3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jm29Z0OD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id f8-20020a17090ab94800b0027cf6bb27dfsi7062179pjw.39.2023.10.16.14.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 14:54:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jm29Z0OD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id E3F1E8020928; Mon, 16 Oct 2023 14:54:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234137AbjJPVyM (ORCPT + 99 others); Mon, 16 Oct 2023 17:54:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232716AbjJPVyL (ORCPT ); Mon, 16 Oct 2023 17:54:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80D5FB4 for ; Mon, 16 Oct 2023 14:54:10 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 617DDC433C8; Mon, 16 Oct 2023 21:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697493250; bh=dsjl7kpO+a5ffvGfGBAiPokx4K+LHRouUIS1choW8ZI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jm29Z0ODHKXQvQMr/SDv46IbAojo8d8W/6AhBAQ8gZfdtFkFET16+krmSYQ6sI0Cz Lvv6IKu9I0+xoeokkZqjdZiSecQvl20eu9Yaa32r4zAYRPAvnjbNz7rvgyHFQQ0Ysk GdmvMal3V/53qgiwUPZ/F9sBZuT4YthtPPiOhqFUJb0Ez8rYAgKpG3p1khGwJ5HxLC 6Pw88CujJiIx/Wfb4+oJ3kJSuxu0SFwarpr55XDDYOoxrlOHqdoq/4VxXuO+B08E7o SSiXEdMZKQaAZJMPh89KWfldNi/7UWolyvReJCDNxKpf+KRCewFiFz1N+E2c/ulRox O8eTA3jYe/UwA== Date: Mon, 16 Oct 2023 14:54:08 -0700 From: Jakub Kicinski To: Shinas Rasheed Cc: , , , , , , , , , , Subject: Re: [net PATCH v2] octeon_ep: update BQL sent bytes before ringing doorbell Message-ID: <20231016145408.539968d1@kernel.org> In-Reply-To: <20231012101706.2291551-1-srasheed@marvell.com> References: <20231012101706.2291551-1-srasheed@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 14:54:17 -0700 (PDT) On Thu, 12 Oct 2023 03:17:06 -0700 Shinas Rasheed wrote: > - netdev_tx_sent_queue(iq->netdev_q, skb->len); > iq->stats.instr_posted++; > skb_tx_timestamp(skb); The skb_tx_timestamp() here will do the same exact UAF, no? I think you should move them both. -- pw-bot: cr