Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <bae82fe3-56da-49df-94b6-1e2998f86503@intel.com>
Date:   Mon, 16 Oct 2023 16:03:13 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 08/16] net: ethtool: Add a command to expose
 current time stamping layer
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>,
        =?UTF-8?Q?K=C3=B6ry_Maincent?= <kory.maincent@bootlin.com>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-doc@vger.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "Jonathan Corbet" <corbet@lwn.net>,
        Jay Vosburgh <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        "Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        <UNGLinuxDriver@microchip.com>,
        "Broadcom internal kernel review list" 
        <bcm-kernel-feedback-list@broadcom.com>,
        "Heiner Kallweit" <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Richard Cochran <richardcochran@gmail.com>,
        Radu Pirea <radu-nicolae.pirea@oss.nxp.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Michael Walle <michael@walle.cc>,
        Maxime Chevallier <maxime.chevallier@bootlin.com>
References: <20231009155138.86458-1-kory.maincent@bootlin.com>
 <20231009155138.86458-9-kory.maincent@bootlin.com>
 <2fbde275-e60b-473d-8488-8f0aa637c294@broadcom.com>
 <20231010102343.3529e4a7@kmaincent-XPS-13-7390>
 <20231013090020.34e9f125@kernel.org>
 <6ef6418d-6e63-49bd-bcc1-cdc6eb0da2d5@lunn.ch>
 <20231016124134.6b271f07@kmaincent-XPS-13-7390>
 <20231016072204.1cb41eab@kernel.org>
 <20231016170027.42806cb7@kmaincent-XPS-13-7390>
 <20231016084346.10764b4a@kernel.org>
 <20231016182307.18c5dcf1@kmaincent-XPS-13-7390>
 <20231016100313.36d4eab9@kernel.org>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231016100313.36d4eab9@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFExejNUaW1RbDZHVGpwR1pkVktYK0o2ZlVkcXhkRGk2U1ozZ25xRzhacUps?=
 =?utf-8?B?SzV3UkdOMzlERGxUZTRHbDl5WnhBelpObDdpQis2cHZGWlVqR2pOTUk5Tm9s?=
 =?utf-8?B?enhqWUFjR2ZOLzFQNWtKWElWbUV4WFd6ZlJINStZR0V6ZXArOUJmNlYxakJX?=
 =?utf-8?B?MzlxWjRpOGRrOXliNjRFTnBydHAxeHR3eWI0VWxGN2UxYkx4c1dIbzdObHVI?=
 =?utf-8?B?UTNWb0hLY054d0E5YnZ5Y2NhY1hCYXQ4bmVUWmZJdVJaakxKN2FhWWdXSTVu?=
 =?utf-8?B?dnNWZEJNVGw5a2d6R0JQeUUySUN3YjRpQ0dGcWpzR3Jab0lrWVYxbzg3R3ls?=
 =?utf-8?B?b3VLanNoLzc3NWJLK055UjZKNERxUnQ0RFd6UG52RktKdHl6R1FjWlZGUUt5?=
 =?utf-8?B?Z3dWQ2hoOFgxdEhyQUdERmM1Y3liZi90TVpEaS9Pc0QydGt0bHR4WkZ0OEg2?=
 =?utf-8?B?alhqbkVqNm5IT0JMd0xkWTZsQXVCZnRYT21NRkNVMzA1eWpMYTZrMmNFai96?=
 =?utf-8?B?bDZ3QnFZWUZyTUZQKzAwZENncDNVY3NmcWlLUm9tWjRMMmVOUG5oS0FtdFRN?=
 =?utf-8?B?aXUvMi9GTS9YS1JMaXhmcWhxR1JtaW16cDdua1VnWkhCYitkOGttK3dkdURw?=
 =?utf-8?B?UjJVOHIvdXlpY0xYeStjMVVDaXVSSE93UmJ1NDh3QzdndEdoVHUvQXRZWGxJ?=
 =?utf-8?B?MnVRUXBvYlAzenVqOHFyTm02U28yOE5jN0EwU1VGMHcvdFBGOGpicStnL0p2?=
 =?utf-8?B?NGlVcWRjbUR5am55cXB0RCtxOGhPNEpXVjRtVjlyVWRuY3RPa2RCeW1PcGpi?=
 =?utf-8?B?MStkNHdpTzU1NVUwN0JTN1RYSktyVmhHZmd3K3JuMHQzNC9jKzFMTzh6QTlL?=
 =?utf-8?B?d2pJOXBaSnh5dFhYOHJHVVFZZnpOc1p2cjNpYkJNUlVjek94Rk0vWWlqdU5p?=
 =?utf-8?B?czExcUNOY3VVcDNYSFZhckRzKzg0YUtaVi9SK01GdUYzVmo4UCs4VWNvVUZj?=
 =?utf-8?B?QW5QOEF4cHRubzlyRVlGNTFaTElidjlpZnpoUmRGM2t1bVAvWFVGcHU1NkxF?=
 =?utf-8?B?WlQ2U2Z3akpmUlp1cFJQV3JTNElzdXROVWJMeWtaQjRSVUdpYlN4aG9XYlFv?=
 =?utf-8?B?Y2EzWWxVUVpWNkhXdk9USnBDa292bC95MDArVkNBT2NNTHdrdkZQTnoyM2Ju?=
 =?utf-8?B?QWxNSUgyVEZZMDNrRUtickRIME1kZXF5a2ZSWHpGMDQxUW9ySUg0QisvWHI1?=
 =?utf-8?B?NUExZUVOdzFmSkhjeXJYSXc2YnZZeklUV01EVHgzUFJNd1pIUjBxWGZIZ3lR?=
 =?utf-8?B?Qm9qM2NFS3RCdUdMdWRzdTZVV1FaY2JjcEpaeHoxREN5ZWpsMHVvbDNpZFF0?=
 =?utf-8?B?cDZuUzMvQm9nczZieVJTQ0dJNmFEK04yUXJKRllOTWx3ekoyUjRyblRwTGQ0?=
 =?utf-8?B?MFBPdlNEZDBmSzE1Y24ycXVHV2tjVDl0aENCRGM1UWlqeDFjTlYyc1U4T0Fx?=
 =?utf-8?B?eFJYQzRHYS9OellGdnBLbC94dUYyTENaeEV4TktaSFIzWmliVDJSK3ZCUDZa?=
 =?utf-8?B?RmhMMmZKMUxGUm94M0ZhZFNPaG9UUEoxWXR1SEttZTdKYzcyOWFKem02eWRJ?=
 =?utf-8?B?c3VlaHMwbytOdEsyZWRxWWxDcThoL3hVdDlQYnFxbjdHS0NnWStPc0lpTVFp?=
 =?utf-8?B?L0xham5QWmhCZ0JuOHVVVllwcUlYZkNoQU84NkFYbGpEM3drQ2JDVGdhNzRE?=
 =?utf-8?B?bTQweVRtK0FTZ0I3S3drM3F2SFRWa1cyWUJNRnhBSDV1RUNOL2ZyamhlbXg2?=
 =?utf-8?B?dndIVkM2K2l2cVhKelJZMzcrTVYrYVRyUE1yNG9nV2Y0TXdzaU5CZ2VlYVFV?=
 =?utf-8?B?NFVPcnhkdjUzejN2OVM4RFZMMENFMW0vVWtERG93a0hsbUZ6RFJHY3VCeWc4?=
 =?utf-8?B?bTBYZEpyVmNkaklaeVR1V0p4K0V2MTY2WmhhQWlHenhqV3pOZ3JwdnM2WEIr?=
 =?utf-8?B?SzJFTTlZazVvSTNjMll0MHB6LzRiR2piRlhmRWo3VVpRbm42b1ZqdzBMZHUw?=
 =?utf-8?B?NHQ1QmlQeElGTzBIL2N3Z3JsYkYySUdEdlhvUUpEbndjbVlJZmZPbG1jTUhx?=
 =?utf-8?B?dXZ5eWVwZUEwU0NPdktObUlHanYwcVhjK1NUV2JTSkNIV1ZHbnFUL1ZOTDJI?=
 =?utf-8?B?bUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 410052f6-12dd-4826-2701-08dbce9c14f7
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 23:03:16.5881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9E7X6zR+Yh0lqx0P671PrqnqzcN89ZOovFffCnIobYTlr/yJrqoHrNn8YmDzP3mKaQwkNKJCoTMJXHJwBMvbSoWNOxBnQN9TAsZGWDHTbT0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6560
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 16 Oct 2023 16:03:29 -0700 (PDT)


On 10/16/2023 10:03 AM, Jakub Kicinski wrote:
> On Mon, 16 Oct 2023 18:23:07 +0200 Köry Maincent wrote:
>>> What's the reason for timestamp precision differences?
>>> My understanding so far was the the differences come from:
>>>  1. different stamping device (i.e. separate "piece of silicon",
>>>     accessed over a different bus, with different PHC etc.)
>>>  2. different stamping point (MAC vs DMA)
>>>
>>> I don't think any "integrated" device would support stamps which
>>> differ under category 1.  
>>
>> It was a case reported by Maxime on v3:
>> https://lore.kernel.org/netdev/20230324112541.0b3dd38a@pc-7.home/ 
> 
> IMHO this talks about how clock control/disciplining works which
> is a somewhat independent topic of timestamping.

The thread in question mentions that the device has two modes, one which
has higher precision for the timestamps, and one which has better
precision on frequency adjustments. I don't know the details for why the
hardware has this behavior, but being able to switch between the two
timestamp modes has value as described by the thread.

I'm not sure how to represent that in such an API because both modes
seem to capture the timestamp at the MAC.