Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2808424rdg; Mon, 16 Oct 2023 16:05:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkPpOxfIvLZdoKp+iQ8Bo7gIcwDki0enKk0zLz7D8a4f1/zhMNewao9RZnV0XEmh3m3vkU X-Received: by 2002:a05:6359:308b:b0:14e:28f9:53fd with SMTP id rg11-20020a056359308b00b0014e28f953fdmr869386rwb.15.1697497550530; Mon, 16 Oct 2023 16:05:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697497550; cv=none; d=google.com; s=arc-20160816; b=eS8cG53z7jFwp6MGCmYk8Aif0ObBCwfcE4kNvGf8GCvEydbWew1hQ/R+RqT4NHJ6Ue iRqtiIhOLLCk4MI8kcmNHav3fKf3U8NBLhfnaeYU+fjRD9J9b2fWi6uzSKI9/rfsLvUA 9m76BRWU+itvxDggB8Ae93NVunqU1n1/360XkoEU9mtnDXd+Cc5NJe/4ZDuFWiOVGQhL vx0/Qpt9CvyUIqzNPdZuJZy4H92G4C0DTlgOYU0WgwT5wLLoBqyHUattuPYPi+eWtwEs /O3aAELGNjgKHjwrNh9y5dkCdRj8LMzyfnhcsEPURZ9oyWck7pW7nvEaEvdrcbGmVa65 q3ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mes4uYc1F4L5u9+/zehMngwOze1Sg71ps5Qsj7ur+l8=; fh=/shXn7l57AG63XwxeiQdCIHMOlEAFXZrIkmA2patEHM=; b=t8ms4Z/eOA0/vsIZ3Gra4SIGJXOuB215cAilu0i3i+fqqrx8evX5jZFNIvlkzDv9/Z tNkrLh5GFvoiPDB7qKG9l88l+I2D2/6HLcrRILu4mcP7T1zGgc2wNiAw8bBOvXXG/hjM F0l1qFd1K/ie1Qb+uU0h4iezznKQ5m7SgQ4IxyD7jZ3CXmqFxOk9yqUdvknmQtLSU9P5 Jnlm+AvDn2rw8/zS3A98wKX1w1gFpD/vg+L28lo4bqhhRgNB1ftZ5BRFyLEf7UVv9SSV ALT8McfCJ6GysDEeInyO+V9VuOmI6SroVvdwam6CQ9PgCd00U1xk/Pdr/yEEEEJgvsMQ 6CLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id ka40-20020a056a0093a800b0068e285eaa31si241710pfb.259.2023.10.16.16.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 16:05:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C5E6A8051B42; Mon, 16 Oct 2023 16:05:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232985AbjJPXFk (ORCPT + 99 others); Mon, 16 Oct 2023 19:05:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232096AbjJPXFj (ORCPT ); Mon, 16 Oct 2023 19:05:39 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7BBFA95 for ; Mon, 16 Oct 2023 16:05:37 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CAD951FB; Mon, 16 Oct 2023 16:06:17 -0700 (PDT) Received: from ewhatever.cambridge.arm.com (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0ABE83F64C; Mon, 16 Oct 2023 16:05:35 -0700 (PDT) From: Suzuki K Poulose To: coresight@lists.linaro.org, James Clark , hejunhao3@huawei.com Cc: Suzuki K Poulose , Mike Leach , Alexander Shishkin , Leo Yan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coresight: Fix crash when Perf and sysfs modes are used concurrently Date: Tue, 17 Oct 2023 00:05:30 +0100 Message-Id: <169749720984.709368.4192452224332206520.b4-ty@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231006131452.646721-1-james.clark@arm.com> References: <20231006131452.646721-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 16 Oct 2023 16:05:48 -0700 (PDT) On Fri, 6 Oct 2023 14:14:52 +0100, James Clark wrote: > Partially revert the change in commit 6148652807ba ("coresight: Enable > and disable helper devices adjacent to the path") which changed the bare > call from source_ops(csdev)->enable() to coresight_enable_source() for > Perf sessions. It was missed that coresight_enable_source() is > specifically for the sysfs interface, rather than being a generic call. > This interferes with the sysfs reference counting to cause the following > crash: > > [...] Applied, thanks! [1/1] coresight: Fix crash when Perf and sysfs modes are used concurrently https://git.kernel.org/coresight/c/078dbba3f0c9 Best regards, -- Suzuki K Poulose