Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <759ccb97-cf5a-4787-b699-27551d5d2865@intel.com>
Date:   Tue, 17 Oct 2023 09:05:36 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] x86/mce: Set PG_hwpoison page flag to avoid the
 capture kernel panic
To:     Borislav Petkov <bp@alien8.de>
CC:     "Luck, Tony" <tony.luck@intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        "mingo@kernel.org" <mingo@kernel.org>,
        "naoya.horiguchi@nec.com" <naoya.horiguchi@nec.com>
References: <20231014051754.3759099-1-zhiquan1.li@intel.com>
 <SJ1PR11MB6083A23BB89F4EE0F44B2794FCD1A@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <233e17ac-0ae5-4392-a5e4-ab811a155805@intel.com>
 <20231016091143.GCZSz+T1xFf5tCFi2w@fat_crate.local>
Content-Language: en-US
From:   Zhiquan Li <zhiquan1.li@intel.com>
In-Reply-To: <20231016091143.GCZSz+T1xFf5tCFi2w@fat_crate.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0hHS0pSYXFsRGx6TDBza296Z1BZTU1RTUZ0ZldjaDJ6QVltenQ4M1NMdmhk?=
 =?utf-8?B?dURwdzV6TTFSMXk1UDVnaWZHUGdZZUJwWHVkMDVHUnZTeUgyV3JIVm5jSTRi?=
 =?utf-8?B?ZGdwRjZIM21tam4zaUNNUEpHWVkwQzhMVnR4YXFHZk1YQVdZR3BhK0JsQ0RE?=
 =?utf-8?B?RkdNeDI5dEVqdUV4WnhacG14aE5XRy9MQjNyYVk0R3B1YWdFcjdneGlZMFQ3?=
 =?utf-8?B?NGVsZk55RVBsTjJHVGJKUEg2aTFRRkx1V2dCVGdHbEQ5TU1uamJuVk5CKzcz?=
 =?utf-8?B?blFGRjRhS0VpYU9YWm4zczNYb1hCalVtNVRkaUV4MjZhRXVwS1ZiWkpOdHMv?=
 =?utf-8?B?L2p1MzdndWZtQkNHeXNRTzcyRlBCUVp0NkJ4VGdSajBsOEY2b3kvQ2p0Z2hy?=
 =?utf-8?B?d0lnK1BOekZERDl4amJ4S2R0azZqdXJCbGFvQVpUR3NmVFhQTEYxdy9pc2sy?=
 =?utf-8?B?Q2IyY1RoTmNaUzIwbjd1OEVadWZBQUNhVnduK1ZPWFFlWmpTVEs1QnBrb21i?=
 =?utf-8?B?d0RkQ3QzaUEzZmtEQ0FuRklzYkxEaUtmekx1NXQ2NnAzK0t0M1p4b0tmZWN1?=
 =?utf-8?B?azc4aW9MMUQrb0d6eTZsK0UzU01yS1dSaVJCa3ZZS2taK1VvSEZzNC9nK1FQ?=
 =?utf-8?B?MEhqQVoxOUF1ZUM3NGtQSE5GMFYwYWZUWFFsaGt5blhwQnpJUWxIUThmRFMx?=
 =?utf-8?B?UnEvSVpDRWMzTVJmOGc5NWdGZmJyNHQ2bkIzaERJOStvOWJoeHR5SHhEZTFi?=
 =?utf-8?B?WmhFbFd4R1ZzY2ZhYWZlNEtJcTUyQmwveHN0ajJvSHBXaFB3M3c4MlB4UVVW?=
 =?utf-8?B?T0RNV0ppQU9oWmtFREN4VlZJWmVMRU5YVFVVM2pUOGFualE0eElmWUJESjlI?=
 =?utf-8?B?bCsyR2ZDaHpPeVNQU0tld3J2TGNTWTdCWnF1V3N3UnpxalBkdUFteW9xaTF5?=
 =?utf-8?B?OW1PVXFtOVUvUDdDeFFJaWFZMEZBZ0pZWHYwVDFTWFMxSlpNM1oxREF1cGpm?=
 =?utf-8?B?K3RlWGRGd1VUTVd1L1RnVG1FdHM4UXYxVHM2bVNmM0NDdFRHM3NlcG5sV1U3?=
 =?utf-8?B?Z0lKMTB5WDR5Skl1SEVIUEhvNGVCVno3RXcraG5pZ0lzNFdwWXZad3pXSjM5?=
 =?utf-8?B?RGRaMS9vNnROcHNFN1hrK01VbUJzSGFlSytVZ0ZPQXlLZ01rVnJWazZkOUt2?=
 =?utf-8?B?ZXpkWXVaNk5Ieitkck5POGhxNHVjTXhvNGZDbFNWVkZMekVSNDE0UjJ2VTE5?=
 =?utf-8?B?bk9tdkc4WUoxWXlVcGMxQUxCRVFvU0QxenFkK1J3RFhIS2NGVzVqVzVxT2xq?=
 =?utf-8?B?VUkzelVVNkw1WEowbFlTN2pjeXZNMnQ3WVQxYWY2OThBRkVxTmdVeGllbmhQ?=
 =?utf-8?B?c3ZUTlFOTDRWME4vbWQvaS8yVmRzYUFaY3VCV1JKSWJXWkNvMmZuK2xYMHkx?=
 =?utf-8?B?aEhIdlZNUU02RWZ4dFcrU1VzejNyNVdZY09oS2hiOGtqb1A1VUlUSkRxTDE3?=
 =?utf-8?B?cWlBcXdUaFNzU1hZYkJVVFZNK3AzY2pMWEtQbjNXQVVoT1JxVUJtaGJyemlz?=
 =?utf-8?B?ZHdkbnZnd2s1VlcxRXVXcWtGV0ZKUHVsbUVNRGVnRmJiYjdONXJJMURlNUdj?=
 =?utf-8?B?dTNOSHI1bTVQcll2QWFqdzVZNzBUMFdWVzhSdE55QmwyMFhpUC9Bc21xZUM5?=
 =?utf-8?B?clAreW9HYW1mRzhEclF6UEZwd04yZGxVeXlhOFhjYnZTMjAxcUVJSkhmaE5q?=
 =?utf-8?B?dndCajJZVm10MENiKzJzNlowS2pFOWJ0aHdjMGpWUHhYWVNSMjd1QWhZS0Fq?=
 =?utf-8?B?SStvOWw5M0kyU2Q4ekI4RmlneTkvN2swdUpSTWtYQk9sQ0xjSGRiNEVkOUdr?=
 =?utf-8?B?czI0dGRxd2REamM2NnNJVGhHVmFUZzhjNVF5RkdxM3NlRzlPZ2V6RHJscVM4?=
 =?utf-8?B?bDhkMlVER2tTMmFmNWtmcEQxK0tHenRtWEFrME9GWGpNQ2U3UWpkUTM4ZWs1?=
 =?utf-8?B?ajJncnZyQWxJT0V5a1A4R21qMnJrdlJ1OWE5Z21GSzZtd1VkdEpLSlAxc1Z6?=
 =?utf-8?B?RXE5QjRWOUIvcFlmUkhRZTEwQlpHVTgvM3gwUEJRRjNqbU9MSHFmc0IyY1lF?=
 =?utf-8?Q?zXzGpzy2HFupBe8PeAmh/JZ9/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f433d0a-a45a-4a1f-5527-08dbceaa86c8
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3728.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 00:46:40.5303
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h4wAdX7QDv9S9+6bfDlshEShV82GzVzY0IaiD6iOcLa7B2FYlCfk/ufJHa9tLPRGclUgWnG7RXuziFps052pUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4947
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 16 Oct 2023 17:46:54 -0700 (PDT)

On 2023/10/16 17:11, Borislav Petkov wrote:
>> For some MCE fatal error cases, the kernel might call
>> mce_panic() to terminate the production kernel directly, thus there is
>> no opportunity to queue a task for calling memory_failure() which will
>> try to make the kernel survive via memory failure handling.
> You can't "make the kernel survive" if the error has been deemed
> critical. That's mce_severity()'s job. If it grades the error's severity
> wrongly and memory_failure() should run after all, then this is
> a different story.
> 

I understand what you mean.  Looks I didn't express myself well on this
point and caused ambiguity.  Maybe removing the attributive clause would
make it brief and clear? Such as,

	For some MCE fatal error cases, the kernel might call
	mce_panic() to terminate the production kernel directly, there
	is no opportunity to queue a task for calling memory_failure().

Or do you have other better suggestions? Thanks.


>> @@ -286,6 +287,17 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp)
>>  	if (!fake_panic) {
>>  		if (panic_timeout == 0)
>>  			panic_timeout = mca_cfg.panic_timeout;
> This whole thing...
> 
>> +		/*
>> +		 * Kdump can exclude the HWPoison page to avoid touching the error
>> +		 * page again, the prerequisite is that the PG_hwpoison page flag is
>> +		 * set.  However, for some MCE fatal error cases, there is no
>> +		 * opportunity to queue a task for calling memory_failure(), and as a
>> +		 * result, the capture kernel panics.  So mark the page as HWPoison
>> +		 * before kernel panic() for MCE.
>> +		 */
>> +		p = pfn_to_online_page(final->addr >> PAGE_SHIFT);
>> +		if (final && (final->status & MCI_STATUS_ADDRV) && p)
>> +			SetPageHWPoison(p);
> ... needs to be inside:
> 
> 	if (kexec_crash_loaded() {
> 		...
> 	}
> 
> otherwise it'll be useless work on the panic path.

Good idea! The condition makes it more robust.  I'll validate it and
send V4.

Best Regards,
Zhiquan