Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2869472rdg; Mon, 16 Oct 2023 18:43:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdxoI9bBTB6OcgDSetrx2fxoDnzOv2P3Q3ansgWeW96hRKy9LJekob8KvNL2U82MA1yKVc X-Received: by 2002:a05:6830:1e96:b0:6b7:43eb:c1a with SMTP id n22-20020a0568301e9600b006b743eb0c1amr783175otr.36.1697506991342; Mon, 16 Oct 2023 18:43:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697506991; cv=none; d=google.com; s=arc-20160816; b=zRZHWy3ocn+xxn1DSMB5wWxIYQc9YHgSAggYKxkjU5NUbbFMucp/bhZWktcltZ2C9K AWllUnKdSRtltfSurgXKQk7OhbLPqPIKzk4qJi+WBl5DkQs3CX+dXPLF9G8Gb87rV1Hw TQMS0DW22PtKWPj9jKilZ//8mdSNFe8wB6GNelPBUNi4d7nZ488VSQIkjTnkCE9pnm99 FZepVSTCeIkuqllSFAmmCWJGnY45yzhb22a4G5sKz9nS4DVrmICECoyBpdA8rjUWGjHX jeLuQfPaCgoKE/5dVLbxZNC/4Ib3mq2BJXh5AYn1gHDbpklErXdjOdPOSCSxvvFgZl5f PyXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8naKVPna3lePN+LMkirFgKXoaty1PHNEIEp1SVSQuig=; fh=pbdktCCt2wJuv718rIqzCC/OpSnBg3qQmTtg1LbUuLo=; b=nN121wDgnvH3NyKAao4ge+hwG7chwXa6Yl3mKHrErLTWwYIVz5JGRrp1Y0rWHUSdSO gAoYWhoxG+IKEzw5tJ7mTGg7Dvv85QWkuk7shZj8raMsRdjGsKE2ywNO/57WYUAtWoJ0 RkkqFVcDVjuTUncfLRHREIZpMNG/bXhAw8or6wE71T4Z3FJm89LCCksk4zFZTrBZ+M2/ fKUd1Ykk1dmdO4g4jZ7SVPbWWUx5WaXfqG0uBP86sZA8UXTvAlOOOdFQI/QvPV/1Qj6L BZDggwABE/QCq2e1MQ2P3D+o4uzSOFxBifm8veowbxQGnYbiAS1bzBMOq4sgydX1W0xS cjFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=TFm1iVUd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id e12-20020aa798cc000000b0068e3f550763si490442pfm.101.2023.10.16.18.43.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 18:43:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=TFm1iVUd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 786D180A80FA; Mon, 16 Oct 2023 18:43:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233068AbjJQBmz (ORCPT + 99 others); Mon, 16 Oct 2023 21:42:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231955AbjJQBmy (ORCPT ); Mon, 16 Oct 2023 21:42:54 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02E7D9B; Mon, 16 Oct 2023 18:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=8naKVPna3lePN+LMkirFgKXoaty1PHNEIEp1SVSQuig=; b=TFm1iVUdFPIniQNrmzNuXCwEmc jgUnTn5N4oaH2QxxuSOoB9OabvaYfs6b0v+XOQVSSjM0GdkV8y9+SMIjSbperrCCdjC+wJQ1gWKcK z/ehs2M6rM4YHeaSjcvFrqHq7HdT9RGzKU8/TAUWzJDW31WBJOhqic/d4A6AnWWKySrE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qsZ6Z-002QCm-3D; Tue, 17 Oct 2023 03:42:43 +0200 Date: Tue, 17 Oct 2023 03:42:43 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , Conor Dooley , Krzysztof Kozlowski , Rob Herring , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, "Russell King (Oracle)" , devicetree@vger.kernel.org Subject: Re: [PATCH net-next v4 5/9] net: dsa: microchip: ksz9477: Add Wake on Magic Packet support Message-ID: References: <20231016141256.2011861-1-o.rempel@pengutronix.de> <20231016141256.2011861-6-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231016141256.2011861-6-o.rempel@pengutronix.de> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 16 Oct 2023 18:43:08 -0700 (PDT) > - wol->supported = WAKE_PHY; > + wol->supported = WAKE_PHY | WAKE_MAGIC; It is clearly racy, but maybe try a ksz_switch_macaddr_get() and only if it is successful add WAKE_MAGIC. Then do a ksz_switch_macaddr_put(). Given the limitations of the hardware, it might help the user understand what the hardware can do. But this is not a must. Andrew