Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754939AbXKQWNS (ORCPT ); Sat, 17 Nov 2007 17:13:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751974AbXKQWM7 (ORCPT ); Sat, 17 Nov 2007 17:12:59 -0500 Received: from mx10.go2.pl ([193.17.41.74]:49746 "EHLO poczta.o2.pl" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751736AbXKQWM6 (ORCPT ); Sat, 17 Nov 2007 17:12:58 -0500 Message-ID: <473F67AC.5020306@o2.pl> Date: Sat, 17 Nov 2007 23:14:04 +0100 From: Jarek Poplawski User-Agent: Icedove 1.5.0.14pre (X11/20071020) MIME-Version: 1.0 To: Bill Fink CC: David Miller , the.sator@gmail.com, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, jmorris@namei.org, netdev@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 References: <20071115.152813.89410917.davem@davemloft.net> <20071116.010548.94286711.davem@davemloft.net> <20071116142619.8746376e.billfink@mindspring.com> In-Reply-To: <20071116142619.8746376e.billfink@mindspring.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 31 Bill Fink wrote, On 11/16/2007 08:26 PM: ... > Regarding the Target IP, RFC 826 says: > > "The target protocol address is necessary in the request form > of the packet so that a machine can determine whether or not > to enter the sender information in a table or to send a reply. > It is not necessarily needed in the reply form if one assumes > a reply is only provoked by a request. It is included for > completeness, network monitoring, and to simplify the suggested > processing algorithm described above (which does not look at > the opcode until AFTER putting the sender information in a > table). > > So it's ambiguous about the target IP address in an ARP reply packet, > but a value of 0.0.0.0 makes more logical sense to me than using > 192.168.0.1 in this example case, since it should reflect the requestor > IP address, which is unknown in this case. IMHO, you are mostly right, but, according to this, if it's ambiguous then only, if there is the target IP or no target IP, so here 0.0.0.0 or 0.0.0.0... Regards, Jarek P. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/