Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2954726rdg; Mon, 16 Oct 2023 23:06:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMhs37GH2ZtmXVHk1fC596iHX+NPlrvO5FfSmBNGu+S/Q7RzY9T0xNLhbn/Pky1lzlTMhw X-Received: by 2002:a05:6359:285:b0:134:c650:cc0a with SMTP id ek5-20020a056359028500b00134c650cc0amr1395112rwb.15.1697522799742; Mon, 16 Oct 2023 23:06:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697522799; cv=none; d=google.com; s=arc-20160816; b=RnU0mfdVasFp2glrKlhdp0XR49/tt8eYrYODe0JHKJLraeFnIG/EdbcxFZ6z59Vrk3 TlqmxIyQ9B9ogFRI9vGvuQwcz7oC43SD7re2mtumOTDyzikoIQ0MOqCaCVXJ7v9PRcYv ubT1lDiqQVlHPFG5k1DcPE0LD9/kSo6CW3doSgL5J555nn+sloN7E1x7IJa10mH0RPVM Wpz6RiLXY3RZnWFiaooD1oOpYWMwifESE1s+WehlBGQNNnXXbFwi8PIfPSrPE5QrHlx8 kxC3jxzGwN9LPAfHlkwsiTOImeyJRMnlvixyksddZb31d6CwtnpBnXROeWEstEWPvKL4 /d4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=PHVftjgUsbSoduhlYKO3xpylXbMeB/YigrfNtTGt5qg=; fh=vJZB2aV+cB+txuIVrz7D2XJQZdKuuVcQYg//KHgChho=; b=XyH0KLppHvySKwkQ1GlbDj7j/EpwzwuhlJJ127FpvKkSRcIv/f580odC1vLWR5atdt ax1G1pKSQUM/pDy3B+sP/t8NMeCvj4+nI5vDFPgnytN0SJzc/3rlrqKP88dpO8wK6oyH ewmYA/ZQtE5nQPo12C7QTowIunbYkqgBjkb1NX/K2PmW8fjipMaIXXjyS6n1XE6yycBD Ke/kQggn7gyrmgJme+MhkHgl/viyyZca1g/k12HE9liHQac+Zl/NDXFfl8jbpSwy+xHo TbCV37L4ly4tbuCPqI3y0XDfxH68JCygTvg2gPWTb0OJD9pASG1hmHcotPOFNsJFy+SM FmLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AyCWdeJC; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id q13-20020a056a00084d00b006bd9c159a98si960844pfk.186.2023.10.16.23.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 23:06:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AyCWdeJC; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 5E42C807C65A; Mon, 16 Oct 2023 23:06:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234426AbjJQGGM (ORCPT + 99 others); Tue, 17 Oct 2023 02:06:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230343AbjJQGGL (ORCPT ); Tue, 17 Oct 2023 02:06:11 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B70D6B0 for ; Mon, 16 Oct 2023 23:06:09 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4443B1FEFC; Tue, 17 Oct 2023 06:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1697522768; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PHVftjgUsbSoduhlYKO3xpylXbMeB/YigrfNtTGt5qg=; b=AyCWdeJCTiQBNMSg+ffSDEipfK5nXBeJc01Z6pl7PTS4Jw23isCj3DqdcO1v4CTsyTN8c0 w6k39xAltnM22NsziHoOZoLFb7gpNy1E9uaWPVNhibkjXvRbRK+71i0Y+O1yra+P70RYmn 90J1aBP1ZEdY7hy4RloMV5262uYZrKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1697522768; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PHVftjgUsbSoduhlYKO3xpylXbMeB/YigrfNtTGt5qg=; b=5PuC+BLsjSmWB2I7L/lbYvGZo91nwBqtkqwWnn09vXclS9AZWJ67SU8ZvrzqkOwYVfOQ9i IdXKVZTnAA3tUcAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E341E13597; Tue, 17 Oct 2023 06:06:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2MwLNk8kLmWIAQAAMHmgww (envelope-from ); Tue, 17 Oct 2023 06:06:07 +0000 Message-ID: <41582b35-07a0-40ef-8b52-6148b6cf015b@suse.de> Date: Tue, 17 Oct 2023 08:06:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] nvme-auth: use transformed key size to create resp Content-Language: en-US To: Mark O'Donovan , linux-kernel@vger.kernel.org Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, axboe@kernel.dk, kbusch@kernel.org, Akash Appaiah References: <20231016225857.3085234-1-shiftee@posteo.net> <20231016225857.3085234-3-shiftee@posteo.net> From: Hannes Reinecke In-Reply-To: <20231016225857.3085234-3-shiftee@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -9.31 X-Spamd-Result: default: False [-9.31 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-1.22)[89.32%]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 23:06:19 -0700 (PDT) On 10/17/23 00:58, Mark O'Donovan wrote: > This does not change current behaviour as the driver currently > verifies that the secret size is the same size as the length of > the transformation hash. > > Co-developed-by: Akash Appaiah > Signed-off-by: Akash Appaiah > Signed-off-by: Mark O'Donovan > --- > V1 -> V2: support target implementation and controller secrets also > V2 -> V3: return key from nvme_auth_transform_key > Exactly what I had in mind. Thanks for doing this. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman