Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2955886rdg; Mon, 16 Oct 2023 23:09:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGa4HS4bbYURGWkZdjZff6PYHL6WPK/FQ8b3imk72wBdu6SnwdBS93bLlbjnFrkRfIc5sA7 X-Received: by 2002:a54:458d:0:b0:3ab:85a1:fb04 with SMTP id z13-20020a54458d000000b003ab85a1fb04mr1547171oib.9.1697522961309; Mon, 16 Oct 2023 23:09:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697522961; cv=none; d=google.com; s=arc-20160816; b=v6dk6fS5Xbt9ygJiEH/w6poKeAGrVfkT/RcjZYh5Odyp8bHeFbWu4tVHscZY4zn8XL XQqLalsQGpYpCbW7GjHNvBTjPGeF269cQlFKLOxXRDtlELGRDBdnotplfkTa/P4j8tpw yIwIKl3E2ihIWuDtxw0AdwqZoK2nmKj+fH+l2NYhWmcVN4OJagSxlOdf7RAGwOh1AgAt m2fwkS9J365TeiJvLauFa94Gxo2A/iSwsKutCSnQ+OS97NLy6SrGShZv5pCm/x0h/vgS SqLK8zfIxExC7+meD3nIaVNDMj4/ryLpqwpsL9DcPvxilOaOdLmd6Sg0GstCW0qm+9QD 3Hqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=cxxqRXWI+1B6ULorxM4PywC1UFSbhMu+6yOrWSWfxj0=; fh=SVYrABBKrId2tQKsNN1NGL/1iQSOjZSC/BO8irKEOI4=; b=AEaLPm3hHPKSUMr/0stXQZ4frNvuZOUXs4PCag3jKjBeK39utscGyBRJoA9H17vw+o MLAHYoNzfKV6ui0WO0+0GzQhcOAsSdPYbgkl8oOx+0s3MZItFgoG1SA9j2tPl+/Wl6L9 Ip9KM0Xmv5sPDT+hmqlhcd0u/lJphgKP8GKA4UymT2MJt6sUUn5xigmDacQbpj9YYrWX XW2fm32hhliYjP2m82zjQflsyykRcPz0rkFkN01QELVcbnRxg/UFeEMmR44GtIz4cnsS ILiZ1PJWJyzNlWt+8dKHZwcoYhxfRuilfhlWDPL/on1q7Co7a3xNPN4vtYo31m5I67UY Vz+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id s3-20020a656903000000b00584e05f62e1si1065866pgq.297.2023.10.16.23.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 23:09:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 432F780473F8; Mon, 16 Oct 2023 23:09:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234504AbjJQGJO (ORCPT + 99 others); Tue, 17 Oct 2023 02:09:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230343AbjJQGJN (ORCPT ); Tue, 17 Oct 2023 02:09:13 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C76D3B0 for ; Mon, 16 Oct 2023 23:09:12 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 74C5868BFE; Tue, 17 Oct 2023 08:09:08 +0200 (CEST) Date: Tue, 17 Oct 2023 08:09:08 +0200 From: Christoph Hellwig To: Mark O'Donovan Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, axboe@kernel.dk, kbusch@kernel.org, hare@suse.de, Akash Appaiah Subject: Re: [PATCH v3 1/3] nvme-auth: alloc nvme_dhchap_key as single buffer Message-ID: <20231017060908.GA8454@lst.de> References: <20231016225857.3085234-1-shiftee@posteo.net> <20231016225857.3085234-2-shiftee@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231016225857.3085234-2-shiftee@posteo.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 23:09:19 -0700 (PDT) > +struct nvme_dhchap_key *nvme_auth_alloc_key(u32 len, u8 hash) > +{ > + struct nvme_dhchap_key *key = kzalloc(len + sizeof(*key), GFP_KERNEL); This should use the struct_size() helper: key = kzalloc(struct_size(key, key, len), GFP_KERNEL); Otherwise the change looks good.