Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <0f6661a4-7281-4d26-8c26-ba03a567fcaa@gmail.com>
Date:   Tue, 17 Oct 2023 08:19:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/4] Rename variable bUpdateBBVGA, byCurrentCh, byCurPwr
 and byBBPreEDRSSI
To:     Gilbert Adikankwu <gilbertadikankwu@gmail.com>,
        forest@alittletooquiet.net, gregkh@linuxfoundation.org,
        outreachy@lists.linux.dev
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <cover.1697495597.git.gilbertadikankwu@gmail.com>
Content-Language: en-US
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <cover.1697495597.git.gilbertadikankwu@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/17/23 00:58, Gilbert Adikankwu wrote:
> Make the variable names adhere to Linux kernel coding style and mute
> checkpatch.pl errors.
> 
> Gilbert Adikankwu (4):
>    staging: vt6655: Rename variable bUpdateBBVGA
>    staging: vt6655: Rename variable byCurrentCh
>    staging: vt6655: Rename variable byCurPwr
>    staging: vt6655: Rename variable byBBPreEDRSSI
> 
>   drivers/staging/vt6655/baseband.c    |  2 +-
>   drivers/staging/vt6655/channel.c     | 18 +++++++++---------
>   drivers/staging/vt6655/device.h      |  8 ++++----
>   drivers/staging/vt6655/device_main.c |  8 ++++----
>   drivers/staging/vt6655/dpc.c         |  2 +-
>   drivers/staging/vt6655/rf.c          |  4 ++--
>   6 files changed, 21 insertions(+), 21 deletions(-)
> 

Hi,

-       if (priv->byCurrentCh == ch->hw_value)
+       if (priv->current_ch == ch->hw_value)^M
                 return ret;

ERROR: DOS line endings

What does the "^M" at the end of the new line?
Did you run checkpatch on your patches?

Thanks

Bye

Philipp