Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2970972rdg; Mon, 16 Oct 2023 23:49:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBT9KDNjstxjwAW1Zv8pm4jPNIuhbNTXS8ikzTdkcDREOQFXzkiTiRcqOuHPtVWMuUaryH X-Received: by 2002:a05:6a21:190:b0:149:700e:f50a with SMTP id le16-20020a056a21019000b00149700ef50amr1814828pzb.29.1697525348272; Mon, 16 Oct 2023 23:49:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697525348; cv=none; d=google.com; s=arc-20160816; b=ZYZS1AG9XKbgnuUvLa8jFWMuhmYKpWiZdnXKFOAtwjbAJj4bsf/QUYZNokyF8U9a2k 0a0WKu+bOcjTBqdJsqjKNgY3YSzRn75uokzZiJFqpeHKfVPa8psesNqFe0/OJGX/Gq1O B1QvjFaYYwLtYIh/TWEtimGDnxrAEjfmt8MWeleQ4Rcw6zaLVSyyxu3aGKc2LqBz30SR 1KiGo1v4A2VFeK1aQjvFkzFdGQtYc8Ej8mkfAJFiBAfomLrLE+LVjinP4v24IercbFsj EzT/wtn1byIu0SaHuijKFvSdyE+VPSfutwONUZC10gZdwt/WXQsIdYvhNdZ7f2hzM5AJ InhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id; bh=jDJ7Qy1BD6+ib4X3zGBxMgC1qB7DMmjpCsb0cljGDF8=; fh=9SXBLktMHP8mUYsNx/zml2bfjUfMelzXMn1iJ1iEF0Y=; b=obeM4fuWbXFfHqyp0NeHHGnX2LkaEhf+zRxtqcAJJVtCZWwa1ZEc8MRRslFRut22yo dUvmTGhN4kqKBlnNu/C4pTab2BtFIzIj8Jp0p/dsZOiK8Cyb0Y+TdV2qtYd1jwYo9Opa 16KqzLXBk8dRrUEqR6HSKAdFUJyqo9v2YxWSt1LXaZ0w/J2BPEZQI9RrSnmA2gYaRwaJ ULyAt7BkLzHT6YisM/j7oY6qXAwv8Ec92A/Oqp4uXYGCH6EhRW9rRTqhYdghOVomplCo 1QrPrgakECgfN8OG2AJZxQm30J/S0+bfjDIOmPptJ07dXsRR1e+tj8iaOqlN0vdpGp0N Lz7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id r2-20020aa79ec2000000b00691019fd0efsi966847pfq.75.2023.10.16.23.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 23:49:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 9EFA58042D21; Mon, 16 Oct 2023 23:49:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234710AbjJQGtA convert rfc822-to-8bit (ORCPT + 99 others); Tue, 17 Oct 2023 02:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234714AbjJQGsr (ORCPT ); Tue, 17 Oct 2023 02:48:47 -0400 Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAF8310E2 for ; Mon, 16 Oct 2023 23:48:08 -0700 (PDT) Received: from omf01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 24F71C0F2B; Tue, 17 Oct 2023 06:48:07 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA id DAD026000F; Tue, 17 Oct 2023 06:48:04 +0000 (UTC) Message-ID: Subject: Re: [PATCH 1/5] i3c: master: svc: enable hotjoin default From: Joe Perches To: Frank Li , alexandre.belloni@bootlin.com, miquel.raynal@bootlin.com, conor.culhane@silvaco.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Date: Mon, 16 Oct 2023 23:48:03 -0700 In-Reply-To: <20231016154632.2851957-2-Frank.Li@nxp.com> References: <20231016154632.2851957-1-Frank.Li@nxp.com> <20231016154632.2851957-2-Frank.Li@nxp.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Stat-Signature: et6su1xwce3dtrnwgysedozf1b4j9j5n X-Rspamd-Server: rspamout07 X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Rspamd-Queue-Id: DAD026000F X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19nBGLglaohdnaFWs3DLGAZ7gvN1Q9+Zm0= X-HE-Tag: 1697525284-635529 X-HE-Meta: U2FsdGVkX18ETq3OzcCKkIPupHhpUnAvv10wje3N9/qYvE1f392xyyMaj5KGvniZGbc7fo2/0vv3QM+FZi69qvrUgs8R9MBHFEPUIjzz4gOYK4+V71tXP+Xbyodzz9Os+dW/uBD1Fe2AAhfPBt1Hi7Yumt+cN32t0xEmmbu+uFhlpzpozFJipxDHpbHb8TZNZOUnJUlgDi2LOfCO26IHPa1RMYfZP/SiEZaXKa+/Bw9+lBqwXnZIF+5ZSCvpvgecnK1YJw0/OHXHg1l7KFq6W3kPkN7ZRTPQbLf8haVMzdb/mgkOesa2KQkXdOdEq460 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 23:49:05 -0700 (PDT) On Mon, 2023-10-16 at 11:46 -0400, Frank Li wrote: > Hotjoin require clock running and enable SLVSTART irq. > Add module parameter 'hotjoin' to disable hotjoin and enable runtime_pm to > save power. [] > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c [] > @@ -128,6 +128,9 @@ > /* This parameter depends on the implementation and may be tuned */ > #define SVC_I3C_FIFO_SIZE 16 > > +static bool hotjoin = true; > +module_param(hotjoin, bool, S_IRUGO | S_IWUSR); Might be nicer using 0644 Consider using checkpatch --strict on the series.