Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Tue, 17 Oct 2023 15:12:22 +0800
From:   Oliver Sang <oliver.sang@intel.com>
To:     Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
CC:     Jakub Kicinski <kuba@kernel.org>,
        "oe-lkp@lists.linux.dev" <oe-lkp@lists.linux.dev>,
        "lkp@intel.com" <lkp@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Liam Howlett <liam.howlett@oracle.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        <oliver.sang@intel.com>
Subject: Re: [linus:master] [connector/cn_proc]  2aa1f7a1f4:
 BUG:kernel_NULL_pointer_dereference,address
Message-ID: <ZS4z1mxtTIEpFZI/@xsang-OptiPlex-9020>
References: <202309201456.84c19e27-oliver.sang@intel.com>
 <20231004084011.7aeef442@kernel.org>
 <E79EF019-0E7F-4935-87AB-6A543A134E35@oracle.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <E79EF019-0E7F-4935-87AB-6A543A134E35@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K01nRUhLQUJsQXBlaWsvWDdmbWVCODJwcUdzbXBmY3dRZHhHZVYvUFNIRHFK?=
 =?utf-8?B?blNTSWYxQTdpZHpJVWZvT1ZaalF3VEs2QWxMN3Z3a0tQVlFTSkRRa1ZEUVJp?=
 =?utf-8?B?c0VuOUdRU1FXNFA1WDFhY2VSODlBbVp2ckphODhNV3hIaUxGMGU4TnVuT3la?=
 =?utf-8?B?MVh4MHVGUGQyOXRhazA1dGRVRzAwK05iTFhHV2FlVUpnaWxNSzlGT2tlczZZ?=
 =?utf-8?B?eFlWWUppQVJxUUg3UUNLd05wcC9pNGhIVGJGSml4WmVES3hMcG5DNmVvK0oz?=
 =?utf-8?B?QldNaU9wbEZTZUVBUjNHVDB4SFNSTEcyM0xPZnR0VHFmTGJPRUhEazgzSDh6?=
 =?utf-8?B?dUlLUndyOTk2QzNhVmxRcURWUHdiZmxaYmF1ZGFWLzBRMlkyakRJdGIra1E3?=
 =?utf-8?B?WEdtS1BXRHliQlEvTVJoak9IYVFBbUdsMDFOSkRBM3ZyNjh4LzZPU3F4eS9K?=
 =?utf-8?B?RnA4bFRpOGxOc1Nodzl5eVdSTEJ4d0JnOHlDK2F1cnRSSmhhU1EyOVdVT2hm?=
 =?utf-8?B?OVBEL0JvVy95YnYwaXZmOGdYejdWTUxWNEJDK0RtMzV6UDZ2cE94WXRLQnpC?=
 =?utf-8?B?a3Y1KzF4VVFSQTZTbFhUemh5U2tYT1BTakdBNjhOeURzcmlnS1JUa0REM0Ez?=
 =?utf-8?B?QkZ1SWhUNlJoUW15aU9TSkg5NjQxQ2J0alFJUXAvVWJRZEEzRkY3d2VRbTl6?=
 =?utf-8?B?TVRsanZseG1CdFZQbjZodGxyZElubUM5WnFyT1pqSjhLYStDZXNNb0FNdnNX?=
 =?utf-8?B?VXB4NlYzZEdQd1BOdVVGT2tkb1c0TXRrSTRibnVGbUszTjByWXRvNmJOV0xO?=
 =?utf-8?B?Wk9uTUFUbFc4K3dmVlBaVGFSZ0dodzBabFdTQnFrL25MYmEyeGJ1VVdhWnBT?=
 =?utf-8?B?NkZhRjBvUDJlRTJVZStnS3RkK3ZDVGZFUzZvQWY4U25BNUJwZm9jZVpjOEh3?=
 =?utf-8?B?QUovdUVSRnFlZ21SS0I2RmU3SktCODRqTUNHVi9uMXVqTGMvMzlLZkl4ZE5m?=
 =?utf-8?B?cHA3WHJzTjdCZ040TjRyaGY3NytvRnduQUpkMG50OEthcTZ2bmR4NVZqYlFQ?=
 =?utf-8?B?Rm84ZE1ZOHIraFIyU25YdGtJU0lGd3ZreWJWOVlFZ1JkSWh5dDZwQ01LNmV0?=
 =?utf-8?B?WmlSaHdDaUFZSzBPcnhjeHI3a3RwZkZXem1PWUJJSmNzOXgxemp5UUVhRkoy?=
 =?utf-8?B?SmwvQXBuNHZqcFlDWi9LVytYK1k2V201L3JYRkkwZDc4VFNRNHY5dXZjZGtQ?=
 =?utf-8?B?U3pmaW5HUWgwbXhrWTJXMURXcDR6UiswbU1XRUpKOWdEQ0pXY3d6TUErK1dp?=
 =?utf-8?B?KzhhdTlxNWRXSitjQU5xYjRRMEFNRnRuUjFhb3dXbXkyUlBTaHJldnBiNEVO?=
 =?utf-8?B?dzhBOHE0YTVyV0xJM2hjWnpGSnQ1MSswNTBsTkZIcCtTVU00NVd3Wk1PaEtx?=
 =?utf-8?B?S3YzaWRJV1Y1MEowWVJZMThlbzBqNnR0S0k0cVNOS2pwYnZOQVJzdk9UYWQr?=
 =?utf-8?B?KzhZLzRjTGRCSjFiZWQzbmswRG5tR0p4SndFV1poV2tPbDA5a1grcjF3K0JT?=
 =?utf-8?B?eDRYbWtxUWMwN3gwL1c5SGRqZWppRmZYUmFSZmpyS2ZRS1lOUE9RdEJFZml6?=
 =?utf-8?B?TlpRMEkxNVR6R2QvRFlUZVBzUkZVRWVxUkxEbFBoclZyOUdnS0ZXdWVZMHNF?=
 =?utf-8?B?R1MyYzNQaVhEdm9yRlROTGVzMVlhc1BxSGtFSHg0OUpMTmRmQ3pwRG1tK1Zx?=
 =?utf-8?B?VDlXaGJtRkdOTXJ3WEY3OVlzc1NKYVZUQ2ZMQzlKYWxMdVgwTG1nMHJDRVBz?=
 =?utf-8?B?czJhekRxMXYrYlArZjRqS3FiTEZldFBiNFBNeE1pK2FRVFNCakV4by9pNmd1?=
 =?utf-8?B?L3JuTytkd3Z5SUcwcDFlajdvU3pmekxMRlpCM1M5ZVUvQ2dxYy8wNmY0U1ht?=
 =?utf-8?B?U0R2bUVsREowOGtrTlRIVGhYK0Z6VnFidmNwd2R2dlF5bUVsRkVqRW1mMGVT?=
 =?utf-8?B?blhXakQ4RkNlVDdWZ3ExQkpPb2JKb3hsRUI1TlBVYXlKZXk4Qmg1a1NVZmVQ?=
 =?utf-8?B?YnhLeXJkTi9kNm1WbkZTMm5WL3c5OCtVOStWS2RRbkUzNjUzZjZwM09jbmxa?=
 =?utf-8?Q?CN/kerLlBtNDGiS8Kq7PS01QR?=
X-MS-Exchange-CrossTenant-Network-Message-Id: acce535f-074e-4484-bfbf-08dbcee06d2c
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6779.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 07:12:30.3776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 30ZCvrWjp+ofGXbbwgh4DUn13EltKS8xglQBaJpr4d9nXvCeGDpw30x6LBkBXeDd1Fg7eyFTsAUQVbCI12F5ng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8439
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 17 Oct 2023 00:13:00 -0700 (PDT)

hi, Anjali Kulkarni,

On Fri, Oct 13, 2023 at 11:00:31PM +0000, Anjali Kulkarni wrote:
> 
> 
> > On Oct 4, 2023, at 8:40 AM, Jakub Kicinski <kuba@kernel.org> wrote:
> > 
> > On Wed, 20 Sep 2023 14:51:32 +0800 kernel test robot wrote:
> >> kernel test robot noticed "BUG:kernel_NULL_pointer_dereference,address" on:
> >> 
> >> commit: 2aa1f7a1f47ce8dac7593af605aaa859b3cf3bb1 ("connector/cn_proc: Add filtering to fix some bugs")
> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > 
> > Anjali, have you had the chance to look into this?
> 
> Hi,
> I was unable to reproduce the issues with the steps given - many packages are missing, etc. - I am still trying though - however, the stack trace of this issue shows it is a NULL pointer de-reference (it looks like in cn_filter() function) - and I found a potential suspect where a check for NULL pointer was missing. So I’ve sent out the patch fix for this - is it possible for someone to please test with this fix and let me know if the issue is resolved? The fix looks like:

I applied below patch upon v6.6-rc6, the issue reported by original report was
gone.

(and I confirmed the issue still can be reproduced on v6.6-rc6)

Tested-by: kernel test robot <oliver.sang@intel.com>

> 
> diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c
> index 05d562e9c8b1..a8e55569e4f5 100644
> --- a/drivers/connector/cn_proc.c
> +++ b/drivers/connector/cn_proc.c
> @@ -54,7 +54,7 @@ static int cn_filter(struct sock *dsk, struct sk_buff *skb, void *data)
>         enum proc_cn_mcast_op mc_op;
>         uintptr_t val;
> 
> -       if (!dsk || !data)
> +       if (!dsk || !data || !dsk->sk_user_data)
>                 return 0;
> 
>         ptr = (__u32 *)data;
> --  2.42.0
> 
>