Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Tue, 17 Oct 2023 07:57:15 +0000
From:   Sakari Ailus <sakari.ailus@linux.intel.com>
To:     Jai Luthra <j-luthra@ti.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Maxime Ripard <mripard@kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] media: platform: cadence: select MIPI_DPHY dependency
Message-ID: <ZS4+WwbItuFeOIdD@kekkonen.localdomain>
References: <20231017-cdns_phy_config-v1-1-583243d1c187@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231017-cdns_phy_config-v1-1-583243d1c187@ti.com>
Precedence: bulk

Hi Jai,

Thanks for the patch.

On Tue, Oct 17, 2023 at 01:07:24PM +0530, Jai Luthra wrote:
> The driver uses MIPI DPHY helper routines from the PHY core. Make sure
> we select the relevant config for compilation.
> 
> Fixes: a91d06f46bf7 ("media: cadence: csi2rx: Configure DPHY using link freq")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310170258.UzSN4RUB-lkp@intel.com/
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> ---
>  drivers/media/platform/cadence/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/cadence/Kconfig b/drivers/media/platform/cadence/Kconfig
> index 480325d053de..317bd9e2e728 100644
> --- a/drivers/media/platform/cadence/Kconfig
> +++ b/drivers/media/platform/cadence/Kconfig
> @@ -8,6 +8,7 @@ config VIDEO_CADENCE_CSI2RX
>  	select MEDIA_CONTROLLER
>  	select VIDEO_V4L2_SUBDEV_API
>  	select V4L2_FWNODE
> +	select GENERIC_PHY_MIPI_DPHY

Selecting GENERIC_PHY_MIPI_DPHY isn't enough as it depends on GENERIC_PHY.
I'll add the missing select line while applying this.

>  	help
>  	  Support for the Cadence MIPI CSI2 Receiver controller.
>  
> 

-- 
Regards,

Sakari Ailus