Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <2a86074f-94a9-667d-6e94-c582d49b7588@intel.com>
Date:   Tue, 17 Oct 2023 16:51:40 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 01/17] iommu: Add hwpt_type with user_data for
 domain_alloc_user op
Content-Language: en-US
To:     Nicolin Chen <nicolinc@nvidia.com>,
        Jason Gunthorpe <jgg@nvidia.com>
CC:     <joro@8bytes.org>, <alex.williamson@redhat.com>,
        <kevin.tian@intel.com>, <robin.murphy@arm.com>,
        <baolu.lu@linux.intel.com>, <cohuck@redhat.com>,
        <eric.auger@redhat.com>, <kvm@vger.kernel.org>,
        <mjrosato@linux.ibm.com>, <chao.p.peng@linux.intel.com>,
        <yi.y.sun@linux.intel.com>, <peterx@redhat.com>,
        <jasowang@redhat.com>, <shameerali.kolothum.thodi@huawei.com>,
        <lulu@redhat.com>, <suravee.suthikulpanit@amd.com>,
        <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>, <zhenzhong.duan@intel.com>,
        <joao.m.martins@oracle.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-2-yi.l.liu@intel.com>
 <20231010165844.GQ3952@nvidia.com>
 <03ba68e9-33ef-35c1-5720-8f559f94f8a1@intel.com>
 <20231012133917.GL3952@nvidia.com>
 <3659d9a7-d9e9-bb73-daf5-41c765e99c8c@intel.com>
 <20231013140456.GR3952@nvidia.com> <ZSmE6unIukqJ3GKu@Asurada-Nvidia>
 <79f0cab5-39ad-3d98-3896-6e1ba7b8db21@intel.com>
 <20231016115407.GO3952@nvidia.com> <ZS1+VMEo+0bCecui@Asurada-Nvidia>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <ZS1+VMEo+0bCecui@Asurada-Nvidia>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1pNUFdkN2N4dThnYmRqVW5HbUV2Vk1CT1IwT2xQWHQ1cngzQy95Q1pQSXZR?=
 =?utf-8?B?RWV4UDQ0eUFNRis1NnB1OG9iMHNwRUFlRmtPTHd4QkNsbU56czhIVlRlVkRV?=
 =?utf-8?B?SUlyams2eDFKZ0cwaWZtaGVwN3VHdTdUNUV6azNqVno5VmRsenV1Z1hzUDhE?=
 =?utf-8?B?RkRpbE4yR3J3dmpvbmI5dThLYUlVYlRXOWU2U3ZyMXRRbzNpTXVIaVo4d01u?=
 =?utf-8?B?alJtMUZUaWQ5K2N5VlN2VkY4MGZpaUR0VDZ3ekZMbHh4R3NlclRNcHkrTnBT?=
 =?utf-8?B?SmxLZkdrSENiMi9SY3NJT2NLa1NHMnpZTDlvMWEwaGZjbmd5VW9GQy9OYVJK?=
 =?utf-8?B?dmRkLzdxUW52V1MwUFp6bEFlRjd4MTdaamhYSTV4VUxUV0RFcll1WWtlQVJx?=
 =?utf-8?B?SjV4WXMvSU1xSTFtVzFYNHQzdjNWMkpyNEYzSHVrRjZyMEVEamw3Z3QwQi9w?=
 =?utf-8?B?NjdQS2tMeEx6dUlDam5va2RjUjk4L0FvQXlCTmFzSlFDTFVYWC9saDIvRlVw?=
 =?utf-8?B?dEhObHk2cU5lOWIveTgzUWUyNnBGd1pyQ2lxVjg2RXFQUVlERVhGZzVMNlo3?=
 =?utf-8?B?MEo3UDFNR0hvU3lkZ3puUG8vNlpkMDEvbVlwbU9jbm9CS0tSUnhtd2piNXBD?=
 =?utf-8?B?T2htUzgvbVZxK2Z6RStQRGxCTytmUVVkY1RxaGkwRWQxRmRCTk9jSWw2K3VZ?=
 =?utf-8?B?bnZOSFBHUytqY0x1d0RwSEZ3cWFHMnBFcjRQdUt2aFo2TlpkU2hFUXRIcXJh?=
 =?utf-8?B?T2s0Sm5iL1YwZWF2TmoxQW5EUzBVUWFNZlZsMjhxWXMzaG1MamVGREp2Wi94?=
 =?utf-8?B?WndBTE8yQWJpMUFiM1hhRWU5N01EaExJUDFheWJMTThMVTg2ang2dzExVUxS?=
 =?utf-8?B?Mm5HYUZSa3dXUTJmVkp3eTZYUTR6cGRZaEVPeC9YSVJKcEJuZUFONDdqYXFt?=
 =?utf-8?B?KzNSK3JkWHR3dC9uTDFYMTlnc2pWL0lvVXUrNUVyRzUrY0ZtTk1Udm9FT3FD?=
 =?utf-8?B?cldQdmpTY2JZcmlhbU5WY2J5YlBPNUxWK3NiQ2xqb2dhRU4wOVVXVSs0eG9a?=
 =?utf-8?B?MzdVWlMwV1dvbktPQTFuVmZsZnNBemw3OHptRmp0elBGNmVwWlhrcUNDS25k?=
 =?utf-8?B?ZkpoZk5IMTJjdTZvTUVob0lQU2J2OXVXT3hmbkEzTnExZk9kQ25WUmJRYVNI?=
 =?utf-8?B?MlVLWlAzbDdVMDh1VXpHTUt2aGY5TnlxeXoxL3JlZHdGYVROeW15Z0V1MXpi?=
 =?utf-8?B?d3FpV3dmc0tuby9PbHRIb3NENCtzTlNZYy9Lbkh4bUU0R2sySTRIVVJyZjl2?=
 =?utf-8?B?MG1Zck1aKzZVa05CdWlIN2E4MzZsSERibW9NbjZLQzBGcFVhRnpGbFlTMjVj?=
 =?utf-8?B?NFJ0d0hFNUZsR1RVemV5cS9Pc0ZCbmYvYWhpOVJwOEFqL1pJb1dZKy83dG5X?=
 =?utf-8?B?Ylg3U0tOeWV6bGlYRlFlYlB6dUV5cU96OTJlbUxQQ2hocW81Z2RLZnJ2MjRZ?=
 =?utf-8?B?eFhONUhqTkZZaUpZNFVrQkZiTGswOHFhdGp5UUgzSjJVM0VtM0VhVG50ck9L?=
 =?utf-8?B?aW8wZm9sM3MzNFUveVFFaHZNM3JyaENHVnZRZlQ1SmtERjFCOFdqWDk0N0pM?=
 =?utf-8?B?N003MXBnYmxhbER1aWNWS2RuSGtrb0lhc0VxUy9aRWx5NXhmZ2F0UWNrUzRz?=
 =?utf-8?B?UW1ZRzkzWjIxQTFmbkRtem0yRVgwVzl2bEhQM2dsOUZJMEgwa1M2Vk9pSUE2?=
 =?utf-8?B?MFZTSXBxcnNDN2lsdS84VlJBYStsTmNQYVZja1ZBL2lyQzI3UzhyWlhqOUF2?=
 =?utf-8?B?R1Q2emNaRWNwczZacjZhem05V1B4TnQ4RDY5YlNBZHB0MWl0cG1TaUU5WkFO?=
 =?utf-8?B?OVFJMncrRDA4L1UvMGs1UUh2OFFISjJZTDVqYVNaNWR0SjdZTVdkMGlMRlAr?=
 =?utf-8?B?V25zWUkwVjZQWTdETjB2MFQzTm1hWnJZWHZkZjY3TGIyblcvVU5KMFVob2My?=
 =?utf-8?B?S0xGSFJrZ1JRMmMrMGZaeXNQTUZqcHRlNkRBbFJmaTdHWHpONWVwQkNINUJU?=
 =?utf-8?B?eGxLL2JsQWd1bUVsL1dTUFRzZEI5VFMrOWszNWxmU01wbWNCZHc3R29teTZj?=
 =?utf-8?Q?iRYo2u/JD+xym0FTitTzWhWjk?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 73420bc4-5803-46ea-4dd2-08dbceedf483
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 08:49:21.1306
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J54qmPKuIBMf8ujge1juevUKNisUDc14OJ6B8VI3NVatun539Wn5Hl2112T9OaN2zDbNZNV99tO+pF0HT9Piug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7584
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 17 Oct 2023 01:50:29 -0700 (PDT)

On 2023/10/17 02:17, Nicolin Chen wrote:
> On Mon, Oct 16, 2023 at 08:54:07AM -0300, Jason Gunthorpe wrote:
>> On Mon, Oct 16, 2023 at 11:28:15AM +0800, Yi Liu wrote:
>>> On 2023/10/14 01:56, Nicolin Chen wrote:
>>>> On Fri, Oct 13, 2023 at 11:04:56AM -0300, Jason Gunthorpe wrote:
>>>>> On Fri, Oct 13, 2023 at 12:33:13PM +0800, Yi Liu wrote:
>>>>>
>>>>>> not really. Below the users of the struct iommu_user_data in my current
>>>>>> iommufd_nesting branch. Only the domain_alloc_user op has type as there
>>>>>> can be multiple vendor specific alloc data types. Basically, I'm ok to
>>>>>> make the change you suggested, just not sure if it is good to add type
>>>>>> as it is only needed by one path.
>>>>>
>>>>> I don't think we should ever have an opaque data blob without a type
>>>>> tag..
>>>>
>>>> I can add those "missing" data types, and then a driver will be
>>>> responsible for sanitizing the type along with the data_len.
>>>>
>>>> I notice that the enum iommu_hwpt_data_type in the posted patch
>>>> is confined to the alloc_user uAPI. Perhaps we should share it
>>>> with invalidate too:
>>>
>>> invalidation path does not need a type field today as the data
>>> type is vendor specific, vendor driver should know the data type
>>> when calls in.
>>
>> I'm not keen on that, what if a driver needs another type in the
>> future?  You'd want to make the invalidation data format part of the
>> domain allocation?
> 
> The invalidation data has hwpt_id so it's tied to a hwpt and its
> hwpt->domain. Would it be reasonable to have a different type of
> invalidation data for the same type of hwpt?

this seems like what Jason asks. A type of hwpt can have two kinds
of invalidation data types. Is it really possible?

> With this being asked, I added it for our next version. At this
> moment, it only does a sanity job:
> 
> // API
> __iommu_copy_struct_from_user(void *dst_data,
> 			      const struct iommu_user_data *src_data,
> 			      unsigned int data_type, size_t data_len,
> 			      size_t min_len)
> {
> 	if (src_data->type != data_type)
> 		return -EINVAL;
> 
> // Caller
> 	rc = iommu_copy_struct_from_user(&user_cfg, user_data,
> 					 IOMMU_HWPT_DATA_SELFTEST, iotlb);
> 	if (rc)
> 		return ERR_PTR(rc);
> 
> Thanks
> Nic

-- 
Regards,
Yi Liu