Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3058844rdg; Tue, 17 Oct 2023 03:26:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqmGRB1EjskFIbA/Vqmm6LH9F0bR5jr2KUoNiucqYmbQXpfgILLu2YNPjEhwJ0D4gI0MXZ X-Received: by 2002:a17:902:e547:b0:1c9:ea6e:5a63 with SMTP id n7-20020a170902e54700b001c9ea6e5a63mr1550327plf.32.1697538418812; Tue, 17 Oct 2023 03:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697538418; cv=none; d=google.com; s=arc-20160816; b=f2oHRTXcPblN/NVHggs5/ym3+kgLjOqEfbBoTO1y0gSf3TCZPHzHs7D9yAQ++o+7ea XsVd5UOWFc5d0+oNxWAxH/opzYnW5yfGVsjwD9MSyx3q5032nfOkB1L5mFVI93GFZ5n8 LkwyqsmMgNf8BDYAl3WqOok/Mc7yyWTV0I1XzlrfxTdOoim7tbIWQWm4g+PiOYivHze5 IhndTACf+ryZFtEaUbT7P5fa0SyIAMk9BVt9fqE3QO7VEG1d0hGBECgaw01HnAt5paOs +49V4eI2MU1h23gLmYMMufTTNev0JAorEdePI0QQrdidQWN0z7G8xj6G2Gbrl1tAOKNB 8EDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=igOicrJvnJr7CKWsaEkShUy2TgT5ZY4do4G2bRlQorU=; fh=9Fw/MLhadlemxY+SuBxjovokYQGlCM/IHGuz/mx2IHo=; b=hMDs0y9bLVMrzn56c89Gx32uIUtu7mVp4KtnNoeETMwXJgOZtkM2EBmG2ePLfn+iK0 t39S4L08P6Mb3YkG0d0uW1KCxfEvuxWUNU3Oh7ZLILGZDQLzP3MjR1BfQYP1XJaua+f3 q0KrlN9zPji4gobL/9N3E0KNymOBzzU/1gvpIwTJPw+mvFfA7OwhtnxfP7sicvyYoZ7u bbY5vBNQ0vl/pk45y8qi8DNzQy6/CUIsHbP/HojPDkIDGmoZyeGIiF+AiaC5GzJk+BLu 8nh6i1PrYsCaCYtFsfQDhg1fTd7TrNDw1SL6FRJVfUHm4TSwfkUeIlsTxN6aILFDMihL zRig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id l18-20020a170903121200b001b9be3b94dfsi1444461plh.268.2023.10.17.03.26.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 03:26:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id D23C080AD12B; Tue, 17 Oct 2023 03:26:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234925AbjJQK0s (ORCPT + 99 others); Tue, 17 Oct 2023 06:26:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234833AbjJQK0q (ORCPT ); Tue, 17 Oct 2023 06:26:46 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90804B0; Tue, 17 Oct 2023 03:26:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20331C433C8; Tue, 17 Oct 2023 10:26:38 +0000 (UTC) Date: Tue, 17 Oct 2023 11:26:36 +0100 From: Catalin Marinas To: Alexandru Elisei Cc: Hyesoo Yu , will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC 06/37] mm: page_alloc: Allocate from movable pcp lists only if ALLOC_FROM_METADATA Message-ID: References: <20230823131350.114942-1-alexandru.elisei@arm.com> <20230823131350.114942-7-alexandru.elisei@arm.com> <20231010074823.GA2536665@tiffany> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 17 Oct 2023 03:26:57 -0700 (PDT) On Mon, Oct 16, 2023 at 01:41:15PM +0100, Alexandru Elisei wrote: > On Thu, Oct 12, 2023 at 10:25:11AM +0900, Hyesoo Yu wrote: > > I don't think it would be effcient when the majority of movable pages > > do not use GFP_TAGGED. > > > > Metadata pages have a low probability of being in the pcp list > > because metadata pages is bypassed when freeing pages. > > > > The allocation performance of most movable pages is likely to decrease > > if only the request with ALLOC_FROM_METADATA could be allocated. > > You're right, I hadn't considered that. > > > > > How about not including metadata pages in the pcp list at all ? > > Sounds reasonable, I will keep it in mind for the next iteration of the > series. BTW, I suggest for the next iteration we drop MIGRATE_METADATA, only use CMA and assume that the tag storage itself supports tagging. Hopefully it makes the patches a bit simpler. -- Catalin