Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   "Gangurde, Abhijit" <abhijit.gangurde@amd.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "maz@kernel.org" <maz@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "git (AMD-Xilinx)" <git@amd.com>,
        "Anand, Harpreet" <harpreet.anand@amd.com>,
        "Jansen Van Vuuren, Pieter" <pieter.jansen-van-vuuren@amd.com>,
        "Agarwal, Nikhil" <nikhil.agarwal@amd.com>,
        "Simek, Michal" <michal.simek@amd.com>,
        "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
        "Gupta, Nipun" <Nipun.Gupta@amd.com>
Subject: RE: [PATCH v4] cdx: add MSI support for CDX bus
Thread-Topic: [PATCH v4] cdx: add MSI support for CDX bus
Thread-Index: AQHZ5Ld0MJVuHirK7E+yMAFiVI63j7A7ItEAgBLqy5A=
Date:   Tue, 17 Oct 2023 11:24:33 +0000
Message-ID: <DM4PR12MB7765E0AE903633FD575E1A518FD6A@DM4PR12MB7765.namprd12.prod.outlook.com>
References: <20230911135259.14046-1-nipun.gupta@amd.com>
 <2023100531-matron-oversold-4a73@gregkh>
In-Reply-To: <2023100531-matron-oversold-4a73@gregkh>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ActionId=4a10bf14-e978-42f8-a23f-0e8fe7dfc4a2;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ContentBits=0;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Enabled=true;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Method=Privileged;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Name=Non-Business-AIP
 2.0;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SetDate=2023-10-17T11:23:53Z;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM4PR12MB7765:EE_|IA0PR12MB8280:EE_
x-ms-office365-filtering-correlation-id: 46a3198f-b126-4d03-50aa-08dbcf03a354
x-ld-processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: X/3MWziOZj3i3iznNTPadlpv7j5g+CCQ+PP6gVTOsO4pvjHfgyx8hnZXqG2FBLJR2vevStqXhYo/Zi5RIcHy//2lzAe1eL9JZ43tYtALSy3ly806KV2ax+lLTy5NtBc99U9GPpaUj0MJOT+JZPEoT1SSs/lWizS9PjhbccSu9l3ClswVpxJJf+NKeTcnZE1L9G9qn8ROSRvA+Thrv3UCcbaUmqTOvEqsX7RMvp+G2WW0PPtMZIo40XJMN7bnGDlhz8IBXYwExmAr2fFzE2hsK/X2usu4F775fsTgiBSBRAAm8T+byVay2HbQS84Ws7e0to7i2kCYgoEV/b/VL0iQGHPZ7Pb0n+vp24CkSW/+zYj7L76SLAEI0bUoHn1PpvFrf4grMbCiEGpW2KDgCV2mL+Z+emtF28EoEfxLdnNszMO0LzcxxMWR++bQbtD14OrShzh7BVUcJLnmrwcB48/nCm5IQj2ZDQoEGGa0kJKCjwi5dKkwbm8gv9bNK2dZvfDqXIGDuyld5imqW84pyyaxNzmL0L8VG6B2q21U8a/z1FsGfOBWaijA6Qiz15D1iVZ6PCCwG/lsZEbqE2UXJa+wxelH7z4qXyrxv1xQHBCjOCKmvQpPO2MlcBIGYl0p524L
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB7765.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(136003)(366004)(396003)(39860400002)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(86362001)(33656002)(55016003)(54906003)(66946007)(64756008)(76116006)(66446008)(66556008)(6916009)(9686003)(38100700002)(66476007)(38070700005)(122000001)(8936002)(71200400001)(316002)(83380400001)(6506007)(7696005)(8676002)(4326008)(478600001)(2906002)(5660300002)(41300700001)(52536014);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HOf71twDyX58JPQHelYDCXq30k4KazEgCLv0qF2WjT4IIhqD+gNZ8e2D544C?=
 =?us-ascii?Q?KGBh8Aw3NgDDOgkTyLIatUfH2OMAx9O/A88J5yADVjVRIZoHKExbtdOO18nn?=
 =?us-ascii?Q?ZOyLGGrH4ZpHVfSy3zmxh/YW3qYZQfmkGMx14Lmpybcm5oE7nwzJHN0kdWHP?=
 =?us-ascii?Q?G9Og5L3aov2+cC+VQaqvHPks8pjkOrYXcZ8vD9H2cy7n5Y6sjQTCazGwZN5I?=
 =?us-ascii?Q?WJFdLzV6LTkaiK4yJMA8sfx7e29hF9OaKV2zuF/WuRE9/J/qHUBDSSZwlWxY?=
 =?us-ascii?Q?T6aLdoCoBnOV6ZqbTnCJv8B3JnL4KlQpsOCDJwG2rCKOnRZSXk+1q1sOwbwk?=
 =?us-ascii?Q?hZvQoIsoA6cd7b6phtRKAVQ+uWQgWN4LwMnB9f7/rBZDayCIkiQXLwsDOrIA?=
 =?us-ascii?Q?mVh6NqHsZHwHoE5+AEfvCHIbFQZDsxr2lvXUwD0DAGq/SojiEKLpz0L6J7y8?=
 =?us-ascii?Q?0ZIk7poi8WmFNpNt/B0nJ91Sd5ldU/k77obsgLzo9lgx1Kaouu201Hnw91UO?=
 =?us-ascii?Q?xEoVCf7kgiN6FbJk46tJkvRDmKfJBLsLatAfCVgPO6QxPUJUm2J0yIoKitKw?=
 =?us-ascii?Q?g7UplvYAOb11ausNhW90lh6tZ1PDRBpraLsTdjnIC0U7cNVznnGYRVALPvi2?=
 =?us-ascii?Q?CrodqQZIJ3v8YCwkA1LGFZZx7QAIore18yZY2MLa9ld8kYAtP4o0Lro9GgnZ?=
 =?us-ascii?Q?+gJhQSBsMb/2CQRvfue7mdQSWJMYPT9/gfJDga+qtaCqzWY31CraNJ9x2J/D?=
 =?us-ascii?Q?Ig444Di8weKR23y0fRTmUbSONFdOkueVsmSildfeCqjynBA/C1hw402fRaZ5?=
 =?us-ascii?Q?ll+s4TtALTWPd9b1m6rDKWjKWMbkan39T8CKi4AQ28LHAF28fD/h1uIgesHD?=
 =?us-ascii?Q?iVJmfe1lDdtB54me//7REIj93QEWvr0dUozB33fTyThwCEF6CnyASCM0bMjD?=
 =?us-ascii?Q?D6LwoF/rFVst42aOnURL2SIlFSpbYJgJCU7bc/9Q9lYArPsWTRmbyXi09z1E?=
 =?us-ascii?Q?cMzVDAbjqKZBQRh5iCrKiypFg/TYpg3VcJ01NTq6XeB3Nzg2NUNziCJzn042?=
 =?us-ascii?Q?h0iCp5ToNz3AB9Z1jeZ6HR0fbx3Ml5iBW9Jr6XpqT7rvAenbk20Wk0rhdM3B?=
 =?us-ascii?Q?gyl0xXXh5+ltxp5fzLeu1fenx68cyETt6uqKSVIDb89bMu2QH6u94skSUeaJ?=
 =?us-ascii?Q?JbcoJyP3cOiqmK0IgL0Lb0YQ0DGjfiol6TeFGM7Sbj/n1oSWOCnnBe7i/dX3?=
 =?us-ascii?Q?7eR8wIW0H6PnuEY2IiXCwLss2kPfUI8EFGzowCaB4RYZGBbwgLAARinNOcNw?=
 =?us-ascii?Q?io2oJ9FltrRKU+GKyRbnkG4MQuIqhfFK2Fv6C3O6b+fNEDOs1aCGvGAiysJm?=
 =?us-ascii?Q?VJlR8fa4Bvp3V5I0ny3EdcIKI5Kl6w0TpLSx65+A3eNQPyC+UX29ebFgpMd0?=
 =?us-ascii?Q?9fGCe8IxZXox4/xtHQMFtNbyN5tVLXR5F6I3ZhijRKYlHfR10U8Oj6egaPgB?=
 =?us-ascii?Q?kIUwKSVU5B13Zuvqrqw0wtIZO+oR1WwW8jIuvR43aUEOEgnM5+Y/Dt7pxEA2?=
 =?us-ascii?Q?/P5evhXMGSoOpOrQMqELJo5yZ+0KNX7eg9BrL8vR8JipwxJpBaMprxYRISIj?=
 =?us-ascii?Q?Zhdvv7m93rktDjg6Zsmxg9M=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB7765.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46a3198f-b126-4d03-50aa-08dbcf03a354
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2023 11:24:33.5099
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2TrRdUDHGQW1iXVHMMhPnh8bwByDVH7RJER8sQkUuM9uwyxT7xXgj7QBWWYCX8um/yrynYEQA3All4fLKKYS7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8280
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 17 Oct 2023 04:24:47 -0700 (PDT)

> > +}
> > +
> > +static struct irq_chip cdx_msi_irq_chip =3D {
> > +	.name			=3D "CDX-MSI",
> > +	.irq_mask		=3D irq_chip_mask_parent,
> > +	.irq_unmask		=3D irq_chip_unmask_parent,
> > +	.irq_eoi		=3D irq_chip_eoi_parent,
> > +	.irq_set_affinity	=3D msi_domain_set_affinity,
> > +	.irq_write_msi_msg	=3D cdx_msi_write_msg,
> > +	.irq_bus_lock		=3D cdx_msi_write_irq_lock,
> > +	.irq_bus_sync_unlock	=3D cdx_msi_write_irq_unlock
> > +};
> > +
> > +int cdx_msi_domain_alloc_irqs(struct device *dev, unsigned int irq_cou=
nt)
> > +{
> > +	int ret;
> > +
> > +	ret =3D msi_setup_device_data(dev);
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret =3D msi_domain_alloc_irqs_range(dev, MSI_DEFAULT_DOMAIN,
> > +					  0, irq_count - 1);
> > +	if (ret)
> > +		dev_err(dev, "Failed to allocate IRQs: %d\n", ret);
> > +
> > +	return ret;
> > +}
> > +EXPORT_SYMBOL_GPL(cdx_msi_domain_alloc_irqs);
>=20
> meta-comment, CDX really should have a module namespace one of these
> days, right?
>=20

Will include the module namespace change in other cdx patch series.

Thanks,
Abhijit