Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <9fcf96ac-e480-fa22-7357-04760ed1e47d@intel.com>
Date:   Tue, 17 Oct 2023 13:35:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH net-next v2 03/11] pds_core: devlink health: use retained
 error fmsg API
Content-Language: en-US
To:     Jiri Pirko <jiri@resnulli.us>
CC:     <netdev@vger.kernel.org>, "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Shannon Nelson <shannon.nelson@amd.com>,
        Michael Chan <michael.chan@broadcom.com>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        "George Cherian" <george.cherian@marvell.com>,
        Danielle Ratson <danieller@nvidia.com>,
        Moshe Shemesh <moshe@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        "Ariel Elior" <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        "Igor Russkikh" <irusskikh@marvell.com>,
        Coiby Xu <coiby.xu@gmail.com>,
        "Brett Creeley" <brett.creeley@amd.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        "Linu Cherian" <lcherian@marvell.com>,
        Geetha sowjanya <gakula@marvell.com>,
        "Jerin Jacob" <jerinj@marvell.com>,
        hariprasad <hkelam@marvell.com>,
        "Subbaraya Sundeep" <sbhatta@marvell.com>,
        Ido Schimmel <idosch@nvidia.com>,
        Petr Machata <petrm@nvidia.com>,
        Eran Ben Elisha <eranbe@nvidia.com>,
        Aya Levin <ayal@mellanox.com>,
        Leon Romanovsky <leon@kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>
References: <20231017105341.415466-1-przemyslaw.kitszel@intel.com>
 <20231017105341.415466-4-przemyslaw.kitszel@intel.com>
 <ZS5qztBDc3ebxypI@nanopsycho> <ZS5s7QE07YkO55O7@nanopsycho>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <ZS5s7QE07YkO55O7@nanopsycho>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXByTW8xREJyVXhYdE5NQVhzclFlbE9haEovU085YlllWjQ1WkdFclpSWlJm?=
 =?utf-8?B?TFBNU3M5akgrcmp0OHF0WWNKaXhMcEYzbWE5SlFjNVZ1cW5GOGw3L3MxOUVP?=
 =?utf-8?B?NE1abHpDU045ajJWblRGd2VuSzhCeWh5Um0vQTY0Y2xCZ0dmbzlHSFp3Sjlw?=
 =?utf-8?B?MC9UR3NRZlFXejJFdUttL2t6ckhOd3Bwa0owZ2hVUEN2UkdzeDVwbzJzeGRk?=
 =?utf-8?B?a2p6K1E0Q29SNENvY2E2Y1pFZ0RWNkJKWngrS2xIRmxQV1FicVlKWmNuNWp6?=
 =?utf-8?B?OGZNZWtZVlg4NGZiamdlazR1NDBMSzJtM2F3TFdkV2RvOEFNd2FRdWg3TzdG?=
 =?utf-8?B?RFFsVENwT3RYYlFKbkpaQ05IaEk0QkFZbGhhYzNBNG5FbFZ6UkRrNHZjL3lC?=
 =?utf-8?B?MlpQWnd5TER3ZnhaMDRvaG8xSzZSU2NpTDJsdnE0S1dDQmVkWi9Nc2dicitN?=
 =?utf-8?B?bzFQV1p3NXFSWUQ4cTYyNFZNZjdSRjVQUmlrd21leHE1V1hIVDYxNUkzRk1K?=
 =?utf-8?B?eDVWLzF1ckZpUm1sbjZMTFZsSDFQdmx4b1d3SVV2M1dva2Mzd004Y09JMFV2?=
 =?utf-8?B?K2psSEYvUzVxS3BXTVBtWndoL1JSTmUrWENDKzVoRUYwVWVUY2pLdnVFSmF4?=
 =?utf-8?B?RVNndmdpd05UL1YzTlN1QTQyc2M2bUVXOWloeE14VVVPN2x6SzJTdk9wdWN1?=
 =?utf-8?B?TE9SMWNzZjRJN0NjOVJ2Ty9MSHBmelQwRWs2NVhteUsvbVN0a0IrZmZiOE5W?=
 =?utf-8?B?WDFpY2NzeTcvQkV2VTA5RTZLUHVKTFFLQ3VoUmJoN1FtNlozN29uVVJyYmdn?=
 =?utf-8?B?MDNhZVJjaHhHbnY2TzJXbWZCTVJMblBuN0pGZWJRSUtzaWNWd095eU9SLzNa?=
 =?utf-8?B?Z1JxaTU1VEpDZjRWdklDQTBjSWtBdUtaRmNVVGp4cWtOQW5CNVVoL1g2dysw?=
 =?utf-8?B?MWdGN0RWbkRabWwzQTdGRzcxUXM3VDVZMEIzY2VJTFRBVTMveVBRWHlXSmJG?=
 =?utf-8?B?WFF5Ty9PYW1BUVB6dWlmbFI1L3c5NExoRG5YL3Y1c2htSGx2ZmJXVVVuMEZi?=
 =?utf-8?B?UDM0YWg3Uk5MRGFlN0FVQ00vOUlzT0Vwc3J6NmZqQ0s3dE5KNzhGdlkyWVlM?=
 =?utf-8?B?T3dPM2U5Z0lWUGIwV1BMUlRWT0ZydGdIWXJwVTlYeFNzL0VoR1dsV3llaTFK?=
 =?utf-8?B?eW5kdXBRR1VXR0N3ZXBEQy85UkJvcTF0Y3BiclFuaHRIcXlRNG1mYlhid2lY?=
 =?utf-8?B?OFg0T0pONFdOb1N0ZGsyUHZnZG9Kd1ZYS1JVS09vdjF6M1puSWFuVlNtbEEw?=
 =?utf-8?B?ZGRsUXdmSlAxWk54a3IvQnBDQUFLUURHaGNrWTZVdHdjZ2orSk9jaWFiN2I4?=
 =?utf-8?B?bVJNM08yQkxLMHNBdUVXWEc0d0ZaL3hMb2t5UjNZMkp4dFNDWEVSemNVSVhD?=
 =?utf-8?B?dzFqL0s4eXdGUFNKSlNaeHNuWjNMNitnYkVFcEJoVmJydi9lUGR0M1Z3Qkpw?=
 =?utf-8?B?c1k2OGxzeElFY2NNRDh4ZXZoRm1uVUxPaFYvSzV4SjdUM3hhMGNmek8wRlc1?=
 =?utf-8?B?cGFTTUtUUW5oVWZWN2htN3MrSWFYQ2dUTmgwSjBtQ3ZZbDhPcHlHdmVhSTQr?=
 =?utf-8?B?MDdIRlcydkUrTW14dGQ4dXpFZXRVMnU3SDhYMzJWTmFvQlIzcitYTlFLWm1o?=
 =?utf-8?B?ejVEY3k4Y3BUWGxmb2VpaHMxM2tnajMxam1XbndMSFA0cTVWMGoxUHdwZy9Q?=
 =?utf-8?B?SENtcHZDcVE2d1RLV1N1WWk1Z2tONGJBOVRiWTlSWHc3Q3lkaTZBSXI4dEZT?=
 =?utf-8?B?dWlKWm1xSHp1R2tmUHhUa2hidTl6VGRuclQxQ3JvR043RGMwYXFROHZkYk94?=
 =?utf-8?B?ZStZQ3crV1FNa3R6MjdLUmNVSmg1UG00NysyU2dEODJsdzBOYVhZeXVGeEc3?=
 =?utf-8?B?aUpTeDQ1MmpzYnMraHhvcEp4VFpYaVc1NGtEbTA5YTlkN2NnVEV3MFQxaWZj?=
 =?utf-8?B?R3Y5dHlPWGVLOGR2SXorMHFBNXVjNXAwREJEcE1yU2ZQdXNxMHVBMFo0UTNj?=
 =?utf-8?B?cXZ5Q3BRclU0c3hEV3p5Y1NoMS9Edmx2M2VtcERjcWlRUnpVK0Q1N2ZCQTNz?=
 =?utf-8?B?NWFvUmc3dm1nZG5OVFZJNGVqc0lzbGRhYU5TQVRmVDJzVG41QXdteDBpRzY1?=
 =?utf-8?B?L1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 757018d1-92cb-4ecd-8365-08dbcf052408
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 11:35:19.1716
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aB1SF6pp+5BpxZsiz7BTieCG1dAvQoVovJheJBpMfszF+zKKeTxiGdAqDA7P/aO05nGlWw6mqtpAJ+0jGVAYp1+Obucu8q5RLbAiSq8cG+M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6606
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 17 Oct 2023 04:35:37 -0700 (PDT)

On 10/17/23 13:15, Jiri Pirko wrote:
> Tue, Oct 17, 2023 at 01:06:54PM CEST, jiri@resnulli.us wrote:
>> Tue, Oct 17, 2023 at 12:53:33PM CEST, przemyslaw.kitszel@intel.com wrote:
>>> Drop unneeded error checking.
>>>
>>> devlink_fmsg_*() family of functions is now retaining errors,
>>> so there is no need to check for them after each call.
>>>
>>> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
>>> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>>> ---
>>> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-57 (-57)
>>> ---
>>> drivers/net/ethernet/amd/pds_core/devlink.c | 29 ++++++---------------
>>> 1 file changed, 8 insertions(+), 21 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c
>>> index d9607033bbf2..8b2b9e0d59f3 100644
>>> --- a/drivers/net/ethernet/amd/pds_core/devlink.c
>>> +++ b/drivers/net/ethernet/amd/pds_core/devlink.c
>>> @@ -154,33 +154,20 @@ int pdsc_fw_reporter_diagnose(struct devlink_health_reporter *reporter,
>>> 			      struct netlink_ext_ack *extack)
>>> {
>>> 	struct pdsc *pdsc = devlink_health_reporter_priv(reporter);
>>> -	int err;
>>>
>>> 	mutex_lock(&pdsc->config_lock);
>>> -
>>> 	if (test_bit(PDSC_S_FW_DEAD, &pdsc->state))
>>> -		err = devlink_fmsg_string_pair_put(fmsg, "Status", "dead");
>>> +		devlink_fmsg_string_pair_put(fmsg, "Status", "dead");
>>> 	else if (!pdsc_is_fw_good(pdsc))
>>> -		err = devlink_fmsg_string_pair_put(fmsg, "Status", "unhealthy");
>>> +		devlink_fmsg_string_pair_put(fmsg, "Status", "unhealthy");
>>> 	else
>>> -		err = devlink_fmsg_string_pair_put(fmsg, "Status", "healthy");
>>> -
>>> +		devlink_fmsg_string_pair_put(fmsg, "Status", "healthy");
>>> 	mutex_unlock(&pdsc->config_lock);
>>>
>>> -	if (err)
>>> -		return err;
>>> -
>>> -	err = devlink_fmsg_u32_pair_put(fmsg, "State",
>>> -					pdsc->fw_status &
>>> -						~PDS_CORE_FW_STS_F_GENERATION);
>>> -	if (err)
>>> -		return err;
>>> -
>>> -	err = devlink_fmsg_u32_pair_put(fmsg, "Generation",
>>> -					pdsc->fw_generation >> 4);
>>> -	if (err)
>>> -		return err;
>>> +	devlink_fmsg_u32_pair_put(fmsg, "State",
>>> +				  pdsc->fw_status & ~PDS_CORE_FW_STS_F_GENERATION);
>>> +	devlink_fmsg_u32_pair_put(fmsg, "Generation", pdsc->fw_generation >> 4);
>>> +	devlink_fmsg_u32_pair_put(fmsg, "Recoveries", pdsc->fw_recoveries);
>>>
>>> -	return devlink_fmsg_u32_pair_put(fmsg, "Recoveries",
>>> -					 pdsc->fw_recoveries);
>>> +	return 0;
>>
>> Could you please covert the function to return void? Please make sure
>> to do this in the rest of the patchset as well.
>>
>> Thanks!
> 
> Sorry, I messed up, this is a cb. Looks fine.

Thanks :)

I was also tempted to convert, but there are other possibilities of
error to report from callbacks :)
There are still some places in mlx5 that seems as possible candidates,
but this series is big enough to draw the line here.

> 
> pw-bot: under-review
> 
>>
>> pw-bot: cr
>>
>>
>>> }
>>> -- 
>>> 2.40.1
>>>