Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3114899rdg; Tue, 17 Oct 2023 05:17:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZd1xrF5e26B5aAvBt4eTIY14PXv5xyjgsS7AEalhYP9hHnCT3b1Wub7Hieg/afAgc/Ay5 X-Received: by 2002:a05:6a00:1913:b0:6be:23dd:d62c with SMTP id y19-20020a056a00191300b006be23ddd62cmr2237072pfi.2.1697545049071; Tue, 17 Oct 2023 05:17:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697545049; cv=none; d=google.com; s=arc-20160816; b=j28ZX/kLnInum/vZXi3LZwz7b8SjHQiImJNx+MK82lfKDWxxVWQH17QMXHtK65m4ZK 7NoR0LvGuHEb9t4fFHg32vMpOpZVKy47EhsGHFaPVLvWmQLnOovbt6SL8uzqLbMDbNYk Uzp9OH5iAi8l3n2UpHn1ZINy5YkZ7ks6EoIKpswe/1+kY3kcK6A4tUA83p7V4NqH+mJZ SRr0DbuRMt+ObvKJ3fSKeeByciHJ4SPVA1SIBFqBcUoK64UvaPyuFc7Lv9uGaCzmyq9n mZOzNHOmlTFoS69YM34BhphEpqTgLOxKpAbHSQJZKIOVE1nAURvNPc7+t06JAuOZ3Kf8 /zTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :feedback-id:references:in-reply-to:message-id:subject:cc:from:to :date:dkim-signature; bh=KRuOAkjZGIG2r6IHWGXC+XJV7uOGD+ibR185OeoHuMA=; fh=SnXm01JQmaIjTEvKvPdnSus94jlYPLqYNymibM4vIAs=; b=u8oyty+52aGmqRZZajK16l0k9XPFWABSBpTgHmKAVXcrnxmvKF9rl2gwTnRx7ITXzN aarU7l4SsvkIbjhwUFaxORH57B371oCRytADLvAzqK2Xxmj+OUyElsKP6N7KyxYU30to CEuCJt5ITub5N1hyGg3gDb8YPKH52nmm6SqE1gjrllR+x681u4FmuWWhFon9TjCFfF2e elfw7JXYxAou4M8tIKrP/X2Hy+v1afvY3DMnwhls2cFT7QP8QSFnfyYA0hILS1oyfU4i X89266yMlx4mD6A7Kd3FRdeQQX5VCHfm591O8DR8dWcm/jjsvosWBWFSYzRznmJaB5/W 6JZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@emersion.fr header.s=protonmail2 header.b=k3UmlNWn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=emersion.fr Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id t12-20020a056a0021cc00b0068fb95e5401si1524423pfj.65.2023.10.17.05.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 05:17:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@emersion.fr header.s=protonmail2 header.b=k3UmlNWn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=emersion.fr Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A4BFC80ACC4C; Tue, 17 Oct 2023 05:17:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235130AbjJQMRG (ORCPT + 99 others); Tue, 17 Oct 2023 08:17:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343676AbjJQMQt (ORCPT ); Tue, 17 Oct 2023 08:16:49 -0400 Received: from mail-4317.proton.ch (mail-4317.proton.ch [185.70.43.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 599274211 for ; Tue, 17 Oct 2023 05:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail2; t=1697544993; x=1697804193; bh=KRuOAkjZGIG2r6IHWGXC+XJV7uOGD+ibR185OeoHuMA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=k3UmlNWn5P5Td8hjdwUp95U4IftjG9+b1n6Oiiu5y1ewdu6gkeC0vRe/3qPTlOkg0 0GaftVq2ZVI3j+GXD7LQwqpRlboVcaLHdDverCZGYOUqwq81NVSW6Fi0oUApbh28nF i5qy8AslUqpgNwNTo0WfogygI8zFBkf8Xeqp/ZYTwYuOvW4fCLpr71l23eQFKEpX4I 9SAoY1bPfegihPTKLs18xreecaBmDyBScWu/VVdBRyIat+JJWp4FAEz7NHXVGhmxOO LCmMg/cORkdaacYCvjRmRzAHCC9v6xPELro2ssWget9xFDw3aPdMbKZ73PVtvRdG5x WNZdIFH+yxLjg== Date: Tue, 17 Oct 2023 12:16:20 +0000 To: =?utf-8?Q?Andr=C3=A9_Almeida?= From: Simon Ser Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, pierre-eric.pelloux-prayer@amd.com, =?utf-8?Q?=27Marek_Ol=C5=A1=C3=A1k=27?= , =?utf-8?Q?Michel_D=C3=A4nzer?= , Randy Dunlap , Pekka Paalanen , hwentlan@amd.com, kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, joshua@froggi.es Subject: Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes Message-ID: <3r5-_03WC5dK3LaRt1Is78zD_bmT2aaGc5h9jpUGzo2o5GCtGP1zpQNzUxglsieewFklY7xwTrOS9jtI18YlNnnzHNx2Ccw9yM2NuJpDQZU=@emersion.fr> In-Reply-To: References: <20231017092837.32428-1-andrealmeid@igalia.com> <20231017092837.32428-5-andrealmeid@igalia.com> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 17 Oct 2023 05:17:26 -0700 (PDT) After discussing with Andr=C3=A9 it seems like we missed a plane type check here. We need to make sure FB_ID changes are only allowed on primary planes.