Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
CC:     <mathieu.poirier@linaro.org>, <jonathan.cameron@huawei.com>,
        <linux-kernel@vger.kernel.org>, <yangyicong@hisilicon.com>,
        <alexander.shishkin@linux.intel.com>, <helgaas@kernel.org>,
        <linux-pci@vger.kernel.org>, <prime.zeng@hisilicon.com>,
        <linuxarm@huawei.com>, <hejunhao3@huawei.com>
Subject: Re: [PATCH v3 0/5] Several updates for PTT driver
To:     <suzuki.poulose@arm.com>
References: <20231010084731.30450-1-yangyicong@huawei.com>
From:   Yicong Yang <yangyicong@huawei.com>
Message-ID: <fc5ef77c-f4c6-adac-38ab-37e1a23270ef@huawei.com>
Date:   Tue, 17 Oct 2023 20:21:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <20231010084731.30450-1-yangyicong@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Suzuki,

a gentle ping..

Hope all previous comments are addressed/clarified. Any further comment on this?

Thanks.

On 2023/10/10 16:47, Yicong Yang wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
> 
> This series contains several updates for PTT driver:
> - Disable interrupt when trace stops, reverse to what we do in trace start
> - Always handle the interrupt in hardirq context
> - Optimize the AUX buffer handling to make consumer have more time to process
>   the data
> - Since we're a uncore PMU so block any task attach operation
> - Add a dummy pmu::read() callback since the perf core may use
> 
> Change since v2:
> - Add fix tag for Patch 5/5
> - refine the commit in Patch 3/5, trying to make it more clear
> Link: https://lore.kernel.org/all/20230914112223.27165-1-yangyicong@huawei.com/
> 
> Change since v1:
> - Add Jonathan's tag, thanks
> Link: https://lore.kernel.org/all/20230809081825.11518-1-yangyicong@huawei.com/
> 
> Junhao He (1):
>   hwtracing: hisi_ptt: Add dummy callback pmu::read()
> 
> Yicong Yang (4):
>   hwtracing: hisi_ptt: Disable interrupt after trace end
>   hwtracing: hisi_ptt: Handle the interrupt in hardirq context
>   hwtracing: hisi_ptt: Optimize the trace data committing
>   hwtracing: hisi_ptt: Don't try to attach a task
> 
>  drivers/hwtracing/ptt/hisi_ptt.c | 33 +++++++++++++++++++++-----------
>  drivers/hwtracing/ptt/hisi_ptt.h |  1 +
>  2 files changed, 23 insertions(+), 11 deletions(-)
>