Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3119615rdg; Tue, 17 Oct 2023 05:25:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzHBpJB2DnRO1jqdXIyV/QbELNqqzwnyw/675Z9gyOFdhq0TpVYigCmWqWbAmDgeN8mfYD X-Received: by 2002:a05:6a21:3397:b0:16c:13b1:2c6d with SMTP id yy23-20020a056a21339700b0016c13b12c6dmr2118308pzb.56.1697545557809; Tue, 17 Oct 2023 05:25:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697545557; cv=none; d=google.com; s=arc-20160816; b=S7b6JK0EcGpjWdQ5tlYlTuXYymZ8CXgtv0X37dSyUetzgtznAJCJ0FCgqvc7SeaQbc cdzbJdsNSN8oeBHmX/4NcDBBLMvBLDHwyl61kU8x42ntzcIYXm5QjlKq70lRXCuSrGUB Iy9Dor8qSDKlugh7v4XB9xcIujEtcCNFRJJ33blqG91RzLoaHJb8Rv0aiSyTxMdCCR7G op2jYHP+y2kqOTgr4i0G1RXXcUnYu42+BFkjVpyxd2U3F2JKfakBPdECjsLnBDwtMCd1 JxqLLmUig1Xb8SKCEPuH+jbDdn7QUKyuNaOBYB57y1cjJzRmUnjndzISzytat55XvYr6 7j0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ozeZwgkp+vRFcuajR4h9TKlzl5D3KSTpbDUYKL1UCt8=; fh=sBGWNMaNxWCS+0iazesiENXLF9k2WAUgjt9xlOOZ5xM=; b=YDLpBq9oxg/rSwxVRnPWHo6oz+1rnWD0uYohTz6pj2NPVdlA2giBSzbH/aqmn0VPTm cNJaBYqs0g1l7zsCp+CO3RgOFeoNjzFzvqm3F7WxIBIzA//sGxBZSFl/KKjeiaX7AJPS Cmuw14HLGTZf/iBJpRiqb/I1ke6Fy1sftOJhGEqToXV4zGI/HjcUMYyN+hoCHijzDz5P C+dQDGqN2mfmweqlCH+r1bNASE+kik4ALmzuTR5YMGXUjamVJ/g0l26w6LOUf07MWqZG Z08eBDxvB8q8k6515EYiQcHe+9cSXUCtofdoUN4l3rEjSihwrir9bBtowq9cQr58NN8a stNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="tdy/y2VS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id c10-20020a655a8a000000b00584ca25959csi1647948pgt.540.2023.10.17.05.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 05:25:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="tdy/y2VS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id E8B3B80774A2; Tue, 17 Oct 2023 05:25:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233857AbjJQMZI (ORCPT + 99 others); Tue, 17 Oct 2023 08:25:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232763AbjJQMZB (ORCPT ); Tue, 17 Oct 2023 08:25:01 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1145E18A for ; Tue, 17 Oct 2023 05:24:59 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4056ce55e7eso54080805e9.2 for ; Tue, 17 Oct 2023 05:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697545497; x=1698150297; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ozeZwgkp+vRFcuajR4h9TKlzl5D3KSTpbDUYKL1UCt8=; b=tdy/y2VShZEBLwVBWn4+mLZ59ZtvonngZje7+RE3gZaVnWDbMUODGS5XfnJ1XlWKpb VcqGAKp5mxgGehMaCVqxf+PfsO7BnUQwTEGkUVsNzm7GlvOgghKtozG7uB2VTEnfBDrB GjAzyMSetyEJJ/j0/rwvXAtkYOXcIxxVFrhmU3AGV8P47MjC858ntcbk96jzZ3h0I38J Wd5aNoDS4il9jAORfLrvMSnld46fkjc/vPNC45PVuq2RaBoslOobs1HstURumBIiD4ZF 8K/H3W9yLbzrLuM31ofCzgzZz52AgUmTtQIutZe1sIAhz9q+Hl0ZleQRCiCE3Wuk44GK Lpzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697545497; x=1698150297; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ozeZwgkp+vRFcuajR4h9TKlzl5D3KSTpbDUYKL1UCt8=; b=oGkFFkuRGUTDidBrmGIxzQS+mbskflJOgnxMCesDlsaDD3Wq/sZjodNIaKQg/p4d38 AvTdfjjFLNCqHOlaGIPAGxvQ3h5Vrmlvx58Z8cgPtlD870PB10R3qE4RcxnWcbOyTdmZ RL470zU28yjbq7kzl4a/fEj6O44VX9gdERt4Yd9UUi6ySHmqJLLJKuoWb4a4yN5UZ5N/ 4E8y/ic2L6cptT/9MhkdlQsemiYUk8WLZCX5H1j3r2FH5tzDqZPpyyIAkn385eaQy8V9 LOstT2I20ECXDelDtxleOSnuAeIhMpoCES3ZrbkpjMsPtggQ9iV0t6eoVJDoRKGOaQ/M O0zw== X-Gm-Message-State: AOJu0YyPNWLVsGUHZhIewzD+JaTsQta61+SYVNdsFNtcRRHmogqv0e5r BFl9AhrKry/6yxoE8JVv8Jwaig== X-Received: by 2002:a05:600c:1990:b0:401:c338:ab94 with SMTP id t16-20020a05600c199000b00401c338ab94mr1531267wmq.29.1697545497386; Tue, 17 Oct 2023 05:24:57 -0700 (PDT) Received: from [172.30.204.57] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id q8-20020a05600c46c800b004063c9f68f2sm1524491wmo.26.2023.10.17.05.24.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 05:24:56 -0700 (PDT) Message-ID: <044c2493-1294-4760-8e33-51f631265d59@linaro.org> Date: Tue, 17 Oct 2023 14:24:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/a6xx: add QMP dependency To: Arnd Bergmann , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , David Airlie , Daniel Vetter Cc: Arnd Bergmann , Sean Paul , Marijn Suijten , Ulf Hansson , Thomas Zimmermann , Randy Dunlap , Neil Armstrong , Akhil P Oommen , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20231016200415.791090-1-arnd@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20231016200415.791090-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 17 Oct 2023 05:25:20 -0700 (PDT) On 10/16/23 22:04, Arnd Bergmann wrote: > From: Arnd Bergmann > > When QMP is in a loadable module, the A6xx GPU driver fails to link > as built-in: > > x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume': > a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send' > > Add the usual dependency that still allows compiling without QMP but > otherwise avoids the broken combination of options. > > Fixes: 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume") > Signed-off-by: Arnd Bergmann > --- Right, thanks! Reviewed-by: Konrad Dybcio Konrad