Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Tue, 17 Oct 2023 15:41:38 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v3 54/73] pinctrl: intel: drop the wrappers around
 pinctrl_gpio_direction_input()
Message-ID: <ZS6BAkfFeA+6GYfz@smile.fi.intel.com>
References: <20231017120431.68847-1-brgl@bgdev.pl>
 <20231017120431.68847-55-brgl@bgdev.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231017120431.68847-55-brgl@bgdev.pl>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Oct 17, 2023 at 02:04:12PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> pinctrl_gpio_direction_input() now has the same signature as the
> wrappers around it so we can drop them.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Now, for the sake of symmetry can you add (at least to the all
Intel drivers you modified in this series) the following:


int pinctrl_gpio_direction_output_with_value(struct gpio_chip *gc,
					     unsigned int offset, int value)
{
	gc->set(gc, offset, value);
        return pinctrl_gpio_direction_output(gc, offset);
}


?

And respectively in this driver

	.direction_output = pincttl_gpio_direction_output_with_value,


-- 
With Best Regards,
Andy Shevchenko