Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3134896rdg; Tue, 17 Oct 2023 05:55:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFvroLRM71tMgJPHtLB08lZNC5PARIuVpbEndEJQn3Pv4YbkrpDp2nZL2xhTBz6+s4LMrxv X-Received: by 2002:a05:6a20:9185:b0:14d:7130:7bb3 with SMTP id v5-20020a056a20918500b0014d71307bb3mr1972690pzd.13.1697547341756; Tue, 17 Oct 2023 05:55:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697547341; cv=none; d=google.com; s=arc-20160816; b=uQK4Yy9TndLPgWN/heqH5/F7as4UvqcPLSq7hi4jor14kqOgrGFpxEhT2Yo2Crs/1R Vq3hX1d/gHzaavKX/+RvAk/dNhhwYrJNjmyx5wDHwDYmNN7w+SZQslPof5Acf790Qq13 7hvp1+WKblzgA1RswD5cUTnQWlWC9MrOB8lmraXu4k7LBpaeUV9S/oRbIZCFu9UjUYkU BenA7w54/ngHAE36tb4NiKHKhPn19hGyWDqTVt8CeNKjgHwBfONkc4Q27AeYhbaS7aIL CeNxh8HCSqJ+OGAfXKq8+C56+asPamAflZcML1Cub2d5fWRbO8MdSVKy921FGMPKmQYp GUFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=HLLvSBwIjtShz33SHc8amiPKaUDBrwQERh0Pk//Em8s=; fh=zFCBYproKpn3bwEbOQGJfx4TWmoY1ZxQUPBowMvMSE0=; b=R6K7X6VpW56A9h4S+pDfANNdIx53AIBZAwLMqfcEwSXcY8Lo+vG2MWHait2Hey54lD oj07fpbSSWCRhvptva7yQDTzTG6ia0b0KcbNsEsBELJs2mhNIpxMM2K43tEQSgrELv7P 3FzyJPt5mEfKmop0bSZ52fu1LuDT3ALaVD8rj8JiKo7xXAbIdt4SUIlNy4gYi0lJKlKM Kdawz8E3JrRLospm/u3m8KBgD6RyQy03mKgcuql8QeBae74pEfhfaPLDG0iMOZMkOt6m IP96coSoOCbm+ZqnnBjVAHy82zTRwMY1jbPMZX1doytqYsAxPujhjYLXxIF41v1cZvNp w2wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=cjUZixZJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id t12-20020a17090ad50c00b0026d0f7c6b17si8320738pju.30.2023.10.17.05.55.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 05:55:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=cjUZixZJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 4B44C8048E6B; Tue, 17 Oct 2023 05:55:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234659AbjJQMzY (ORCPT + 99 others); Tue, 17 Oct 2023 08:55:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234486AbjJQMzW (ORCPT ); Tue, 17 Oct 2023 08:55:22 -0400 Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26511F1 for ; Tue, 17 Oct 2023 05:55:20 -0700 (PDT) Received: by mail-ua1-x935.google.com with SMTP id a1e0cc1a2514c-7b6b4c2f1a0so530117241.1 for ; Tue, 17 Oct 2023 05:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1697547319; x=1698152119; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HLLvSBwIjtShz33SHc8amiPKaUDBrwQERh0Pk//Em8s=; b=cjUZixZJJdTGNpuhC+V1f7YJzNqeMgIGBYDXj/i7Y0PU9vqLydHO4h5nzExCt4EcBm 3J9lZJANuuIM5Sl4EOkbG5D/YpPZBgfB+eyLj/UtODRO6M0/slMce/YikEfm3f3o2e40 M06b1NuY3btmDm2A+359SjIXSevDn8Rk/sZsdaCvDCSNJ/E55mf8Wto3/slX6ZGl6O/y VkOHL9E4NpUJ9k3iFCroXrR7ZnFG4iQ9g1CT47HrCkfPqOSBFE01hcKos+U4HU/0M4VA ecec6boPdYia8Ay2AziHfGXjlgOrSNSxxG6Pcj/4PRkL5jxmShPT4O0JaGPPv3uzc2Gx zeXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697547319; x=1698152119; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HLLvSBwIjtShz33SHc8amiPKaUDBrwQERh0Pk//Em8s=; b=Bs1BvFhhBwjF+dOfk6lqYMWV4bXc3oMchcXSltG9XzFaO3cf0cVwb50LBTOZ7JQmSH bwRFVAQQFLwW+FdXFdsQn5ho5345tmvUMN1zaa5xu9HvD/mReRoxxkYrDiT5WvgsMRiy TkIMHVWOfy6ulcWh9WCKUAaYEqIvcwWLfYHYiVLNtP2dmRLm3gOUNVk4Ot/M3rTfZ4f8 f8Kx5SuZRsG2cYTdJq/LartBQcj3KVA1jMbFnhXeudfIC72Spyn3n08581mFfCBUwcoB FUGX2a3ohYgLMcLUfqcdzkD+ASz0VdB3yIiRcIDGuWpd2T4GfNWMEFuIPN0Vof2JF82H mIdw== X-Gm-Message-State: AOJu0YxEMpXqkz4bFYEhNArO6B4hjI7YIox/TucuLhtBUf5nkXFsSTX5 /0RwtFIKcfU6HSukepq3ZRzyqDPIJyFUq9cMrFoiag== X-Received: by 2002:a67:e195:0:b0:457:6858:af77 with SMTP id e21-20020a67e195000000b004576858af77mr2089439vsl.26.1697547319115; Tue, 17 Oct 2023 05:55:19 -0700 (PDT) MIME-Version: 1.0 References: <20231017120431.68847-1-brgl@bgdev.pl> <20231017120431.68847-55-brgl@bgdev.pl> In-Reply-To: From: Bartosz Golaszewski Date: Tue, 17 Oct 2023 14:55:07 +0200 Message-ID: Subject: Re: [PATCH v3 54/73] pinctrl: intel: drop the wrappers around pinctrl_gpio_direction_input() To: Andy Shevchenko Cc: Bartosz Golaszewski , Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 17 Oct 2023 05:55:35 -0700 (PDT) On Tue, Oct 17, 2023 at 2:46=E2=80=AFPM Andy Shevchenko wrote: > > On Tue, Oct 17, 2023 at 02:44:25PM +0200, Bartosz Golaszewski wrote: > > On Tue, 17 Oct 2023 at 14:41, Andy Shevchenko > > wrote: > > > > > > On Tue, Oct 17, 2023 at 02:04:12PM +0200, Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > > > > > pinctrl_gpio_direction_input() now has the same signature as the > > > > wrappers around it so we can drop them. > > > > > > Reviewed-by: Andy Shevchenko > > > > > > Now, for the sake of symmetry can you add (at least to the all > > > Intel drivers you modified in this series) the following: > > > > Good idea but this is v6.8 material, I don't want to extend this > > series anymore at this point. > > Then let's postpone at least Intel and Cypress patches after v6.8-rc1 is = out. > But then we'd have to postpone the renaming and we'd be stuck with both variants in the tree. This is suboptimal. We'd also have this huge series spanning two subsystems for 3 months during the v6.8 release cycle in the tree causing conflicts and other issues. I'd prefer to merge this during the v6.7 merge window and then we can keep on improving it without affecting both trees. Linus will be taking those subsequent patches as usual. Linus, what do you think? Bart