Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   "Hennerich, Michael" <Michael.Hennerich@analog.com>
To:     David Lechner <dlechner@baylibre.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
CC:     David Lechner <dlechner@baylibre.com>,
        Jonathan Cameron <jic23@kernel.org>,
        "Sa, Nuno" <Nuno.Sa@analog.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iio: resolver: ad2s1210: add reset gpio support
Thread-Topic: [PATCH] iio: resolver: ad2s1210: add reset gpio support
Thread-Index: AQHaAEeEZrW9+LMH/kKVC8C74GE9yLBOAAXA
Date:   Tue, 17 Oct 2023 13:46:51 +0000
Message-ID: <SN7PR03MB7132A5B955A660700220ADA78ED6A@SN7PR03MB7132.namprd03.prod.outlook.com>
References: <20231016154311.38547-1-dlechner@baylibre.com>
In-Reply-To: <20231016154311.38547-1-dlechner@baylibre.com>
Accept-Language: de-DE, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VwABa3bf/7EZwE7iYiGSCO++FVu0UBLwxr2b0RtZB/V6XHSY6td0aK1uYfMY?=
 =?us-ascii?Q?0+JjbZuCuJX9jcB+r6lEiA27sZvPAxSZ6J/o3ngLZVHfDcYsVOPLsa0l3UCb?=
 =?us-ascii?Q?pHBDG+gayY+dJrCopf+4Fltb/xtPhFZfvSEnVKngV+vPyRv7+ibHZS2J9EV1?=
 =?us-ascii?Q?fS1/1+BRF80sO1kzVs/f0Pat67Eq+XnhBZ7B0Q0163BIllHOzY1FJARsTZu0?=
 =?us-ascii?Q?bHbuIQeytkIR3R6QJQAF+vNZ6atff0oqjDqAHx6DSZ6xPiMDZQmOBrVRFDex?=
 =?us-ascii?Q?Tp8VhEdLm3KSGYwpZqJ98Weikon6gdCBXSU3ilqqkHLnY27qOItM3iKXhO2x?=
 =?us-ascii?Q?l6LfdRKMHJwM079DknvPKvysW5WbVxlvs5T9Bxb3Vu13SjPMj9Jxl6dXh6mP?=
 =?us-ascii?Q?/LreP+HfmrXynLyirLX4Cgr/1pAWk3nAyYO/agEWlOO11/cBNSlyvt6ExZ+k?=
 =?us-ascii?Q?dVQzUL7u5P+mA7/t98KVzrH/Nym4hte85fA6xTrEUbnqAsLphULPwcjqA6qp?=
 =?us-ascii?Q?CxmxoC50wSo7ZLjYJu2dvI4QMizG59P1JHXH+/weT7/lPPl2vz2T76C624XN?=
 =?us-ascii?Q?5OKvMoiktOnvPgp08ZD93DM4W1qxZpyDR0k8GtZnzsWclRt1ltLTuDDi9Eo6?=
 =?us-ascii?Q?+O5n0GXrZGy0M9w7jpAXBU6hpb9fEIiJufeUI+pCi8RG6rmEOMHbVpavamp0?=
 =?us-ascii?Q?chAiN2z0LxVbBTAPiGfezaopylxacI47dnrqfv885BlpKKyiFHtyioG17E0e?=
 =?us-ascii?Q?Q8XculwDVd8lLoW7mN2QoZgPxUNXfYey73X80/u5E+ETJ9aQdQFqp4Gdi/L8?=
 =?us-ascii?Q?3NQHlVEkmslSg035DOW/jGh0MOh7sph8DOS1pPVC10QSpLaHHjFAs+viF7Z9?=
 =?us-ascii?Q?C82R3iMgxSRdDzt85hyyRq2rduhn9tvnWVDyYa/TXpZtccUvQU4gUwjARBmW?=
 =?us-ascii?Q?RRKnfZV4jDovirYQa0/CLJJuOmENU6mcBuJW78rmihwSnM3RJzDjG4Cj1pMo?=
 =?us-ascii?Q?QTR4CZYHKJ3DVOLrjqN3Tq6EULhM7bm1uoStC6CC+JZpDFyFUBBiSPXHkrNn?=
 =?us-ascii?Q?2Yf7a9Kg6vjnBEYjQnx948yChLKJnSIAwL4YqCk/bnLnRrlnqSC6GX1HJswf?=
 =?us-ascii?Q?/52+oGWkXEg60fSiC3oYaBgzWw/Qa6Th4LmIb64s3JUpZnm+UfQWqkFdSkZl?=
 =?us-ascii?Q?XSeWEjLW5fNtLD3PNQyzvImIBI8qx+tTxW7op+RvAH1E4+OLSK3G6WTgEO7A?=
 =?us-ascii?Q?WGVW3I5EyF0p9qyWV5nXSoiAKs84+z49x1tIYyeOKelao6FRd+6F9Lvsuexs?=
 =?us-ascii?Q?pH+20j86uNfKUr5zeaa+FUdaNPU5BqpmRofFLRVoZow4ajUkCuftUfoTFCys?=
 =?us-ascii?Q?/mMESJHBLvmehTjTppFh7p0X2H3ImFhOPo2yIKUOTwQqwbdYj/cFJKKSsH/7?=
 =?us-ascii?Q?EDdwH9wWv8rX67oI6chXWUyAhI1+1Us5wivKJBYps/oGiShOKYlYipbxPeKz?=
 =?us-ascii?Q?6DKNTVQDRyabWlLzY0fU2LzreW1nTUGiMUWEvL/8JfKe9kgCfRxEqiTNjOZA?=
 =?us-ascii?Q?xOMGssXW+b1pA+ke9tpY8L2Kl307/btPBzyJ9ov/dLJ5wDTsGldpjrUDoyBb?=
 =?us-ascii?Q?pA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN7PR03MB7132.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09374c7f-1db9-40f5-0c20-08dbcf17845c
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2023 13:46:51.4530
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x2FC7mzWDDEoWoGsJfrkTza9/eXD80UWHMtBl6ySOXPFNGaDR+vdbQgp4zryBCnXR9wNZ3GRU1El1eTI1ukwVb4zWTzG7JDm0tNhpXVSvl8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5772
X-Proofpoint-GUID: QS-oeZWQEyuNhlwFnDJXpKKPravhPRoe
X-Proofpoint-ORIG-GUID: QS-oeZWQEyuNhlwFnDJXpKKPravhPRoe
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-17_02,2023-10-17_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 adultscore=0
 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 mlxscore=0
 lowpriorityscore=0 impostorscore=0 malwarescore=0 suspectscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2309180000 definitions=main-2310170116
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 17 Oct 2023 06:47:25 -0700 (PDT)


> -----Original Message-----
> From: David Lechner <dlechner@baylibre.com>
> Sent: Montag, 16. Oktober 2023 17:43
> To: linux-iio@vger.kernel.org
> Cc: David Lechner <dlechner@baylibre.com>; Jonathan Cameron
> <jic23@kernel.org>; Hennerich, Michael <Michael.Hennerich@analog.com>;
> Sa, Nuno <Nuno.Sa@analog.com>; linux-kernel@vger.kernel.org
> Subject: [PATCH] iio: resolver: ad2s1210: add reset gpio support
>=20
>=20
> This adds support for the optional reset gpio to the ad2s1210 resolver dr=
iver. If
> the gpio is present in the device tree, it is toggled during driver probe=
 before the
> reset of the device initialization. As per the devicetree bindings, it is=
 expected for
> the gpio to configured as active low.
>=20
> Suggested-by: Michael Hennerich <Michael.Hennerich@analog.com>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

>  drivers/iio/resolver/ad2s1210.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>=20
> diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1=
210.c
> index 8646389ec88d..a414eef12e5e 100644
> --- a/drivers/iio/resolver/ad2s1210.c
> +++ b/drivers/iio/resolver/ad2s1210.c
> @@ -1426,6 +1426,7 @@ static int ad2s1210_setup_gpios(struct
> ad2s1210_state *st)  {
>  	struct device *dev =3D &st->sdev->dev;
>  	struct gpio_descs *resolution_gpios;
> +	struct gpio_desc *reset_gpio;
>  	DECLARE_BITMAP(bitmap, 2);
>  	int ret;
>=20
> @@ -1481,6 +1482,17 @@ static int ad2s1210_setup_gpios(struct
> ad2s1210_state *st)
>  					     "failed to set resolution gpios\n");
>  	}
>=20
> +	/* If the optional reset GPIO is present, toggle it to do a hard reset.=
 */
> +	reset_gpio =3D devm_gpiod_get_optional(dev, "reset",
> GPIOD_OUT_HIGH);
> +	if (IS_ERR(reset_gpio))
> +		return dev_err_probe(dev, PTR_ERR(reset_gpio),
> +				     "failed to request reset GPIO\n");
> +
> +	if (reset_gpio) {
> +		udelay(10);
> +		gpiod_set_value(reset_gpio, 0);
> +	}
> +
>  	return 0;
>  }
>=20
> --
> 2.42.0