Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 17 Oct 2023 16:57:24 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: mdio-mux: fix C45 access returning -EIO after
 API change
Message-ID: <20231017135724.pl5neb2ubjdopf6l@skbuf>
References: <20231017113222.3135895-1-vladimir.oltean@nxp.com>
 <ZS6Mskpb6gDpBD3z@shell.armlinux.org.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZS6Mskpb6gDpBD3z@shell.armlinux.org.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EOpXffOBBM1B641rGUpLHDHao6Ux9N31b+7+38Brs7MG5v+Pxbt9mY96VQfw?=
 =?us-ascii?Q?5g9t3yan7qxumtM1XpqgB56939yjXBrMLtITnj4Ig9WKcaksozVaBYOLD3y4?=
 =?us-ascii?Q?jEBwfJNmw6QguGjdhKYPDwdUXu8+xBxH44bc4RIAKe7PHFvQgZDwZTGaQX7/?=
 =?us-ascii?Q?0DBen8qdUTVc9H3slS1W3y3BQB9fPM2fiy10srz2f+DzDW/uPcYuZZUtcVQK?=
 =?us-ascii?Q?T4Nc//XRv2RZv2P0s8mom2Ffsp0LZDeHCRlnJeFQIH3K4yNTejX5z50PcoPQ?=
 =?us-ascii?Q?GJU/lyV31b67fNwH+aOAGKoQxOciN8E4wCcFu1nqoowA6RsoPQMF8xLcu/7I?=
 =?us-ascii?Q?lhLeMpzjLHgGAGtDrz0xfbK6vHZz4s7ZDNENxhZm+Ju+BslNYHCAL05/P8ww?=
 =?us-ascii?Q?O7RyDQSnVkUCChoG9oF5wGpin7AAItqJKWNEjJTO3Yb2G9b+rvmYKP15EZm8?=
 =?us-ascii?Q?f6sSp5GNhdNCD5dnh4CRFLaepFi1QChekc8GKLyAufxO8xEybm2HcTzwvhYB?=
 =?us-ascii?Q?sgMvFf6YRZmCQZvbI7R91XNR3yisdEUVrc8P1KBjOTePKZyNmddmFik1BUCM?=
 =?us-ascii?Q?FqzfpVJIoJeH5zaq5yAJu0IJlUa/bTp51c1tt0Sxislwp3ud4E6YVD1LKx8m?=
 =?us-ascii?Q?fcFK6VY4uqY5wCmAXJj6kLLXncY4b2KMjgHDbE8IkC3azaVvPU19itcD0Hur?=
 =?us-ascii?Q?7plScpME58fbnX9sGgvBeQHaX9c0/d3KdFP932izEaMKLYDcV+JDdsLUJTdj?=
 =?us-ascii?Q?fQkvcDwq2MnO8UZmethAczNUkQmUt3P/7KrHzHpsydhBh0cuQgIMvca5YoZj?=
 =?us-ascii?Q?t5g4xcHbPkyFoPhzG2sOKBVkYIiFXXwSPiciSS6VwrgwqFOMKDlEUhzm5IR/?=
 =?us-ascii?Q?+zmQG+/PhepcdGYcZs2BnixRNpGo7H3eFvC4766HE5V7FqPNIeup8kB/z0AS?=
 =?us-ascii?Q?30esn26XhJShquoQmSC7JrSzDcQCc6Ppu8k8kNk6ZiJSaQhmBYiJuYU9cu+T?=
 =?us-ascii?Q?67ytInsaACqGLW7ElJb84qqFBXoVTtql4JZ3ofpdHrLd6bu1lvKoZVjbWAQx?=
 =?us-ascii?Q?POSGvI0QlFKRF2ZsBmOdK3/r5DTS8OPh6wcD2tfW568nU8XoHFenvwGJf1ov?=
 =?us-ascii?Q?99bilB6ZjLUS/igZYptoKcUHlGtvO125PU5z5HaewS739d/hRsXZseTIfZT/?=
 =?us-ascii?Q?kkNhqT9gpT9bM4HIuOhA7IRSBdwlRCxr/OsZqTmw62jbWshZ2cjZJxa8YOr7?=
 =?us-ascii?Q?iVo/6AvBJoYNG0owRnGhcCzrHV0qTZITSIbl8caf9OGVNOuoh8TGl16H6oCY?=
 =?us-ascii?Q?ng1Bks3Vd4NPnEZ6SJfgWG4UmsgD2glbKHfX/TDPTzeSw3PckL8vMvES9kq4?=
 =?us-ascii?Q?9cEpa+nPcnashzuw/0vSvlE/5/pg0aMn80cVtieYz9Ti+62TzpFf7OBOsFqI?=
 =?us-ascii?Q?IJ0kA3ANnS1BSPE/ygmTQ9hU/FxBMI/G8sPRCmdJh0UVZRPs1KP2InuA7g1T?=
 =?us-ascii?Q?oz6sS6rIg9Vq+iqUhVUfZCEww/BGc7FFoYFXcUOLMy+6Z6ysZUSSIzqCmhoR?=
 =?us-ascii?Q?QfCV/dMN/z7Rj8/J7RpXa+wdHF8T6VPla1qldyt/VB7SthczigL7Vk2vQ331?=
 =?us-ascii?Q?0Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c058229b-1b8a-453c-5636-08dbcf18ffbf
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 13:57:28.2797
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4732p6wJx1qSUrFGiFsiLszbqaNAnkRiG3ZckruHaqIw0uNS9qjPDlSEUvBQ35IY1y22wp/zkZGvsV1r5VKbdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8565
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 17 Oct 2023 06:57:47 -0700 (PDT)

On Tue, Oct 17, 2023 at 02:31:30PM +0100, Russell King (Oracle) wrote:
> What if the parent bus doesn't have read_c45 or write_c45 ?

Good question. Predictably, the kernel crashes.

> Maybe make these conditional on the parent bus implementing the c45
> read/write ops?

I can do that, and send a v2 right away. Thanks for the hint.